[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651268#comment-13651268
]
Jian He commented on YARN-582:
--
bq. Why not simply create it once in the RMAppAttemptImpl and
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651422#comment-13651422
]
Hadoop QA commented on YARN-582:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651530#comment-13651530
]
Bikas Saha commented on YARN-582:
-
Looks good. +1.
Restore appToken for
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651633#comment-13651633
]
Vinod Kumar Vavilapalli commented on YARN-582:
--
Looks good to me too.
Can you
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13651634#comment-13651634
]
Jian He commented on YARN-582:
--
tested, works on branch-2
Restore appToken
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649910#comment-13649910
]
Vinod Kumar Vavilapalli commented on YARN-582:
--
bq. Alternatively, it could
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650390#comment-13650390
]
Hadoop QA commented on YARN-582:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649449#comment-13649449
]
Bikas Saha commented on YARN-582:
-
bq. RMAppAttemptImpl.appAttemptTokens should simply be
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648037#comment-13648037
]
Bikas Saha commented on YARN-582:
-
Is the null check necessary? the underlying protobuf
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648040#comment-13648040
]
Bikas Saha commented on YARN-582:
-
Also, we could be better off storing credentials in
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646806#comment-13646806
]
Jian He commented on YARN-582:
--
new patch addressed last comments
Restore
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646835#comment-13646835
]
Hadoop QA commented on YARN-582:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646095#comment-13646095
]
Hadoop QA commented on YARN-582:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13646282#comment-13646282
]
Bikas Saha commented on YARN-582:
-
Why is this inside the try instead of where the existing
14 matches
Mail list logo