[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-23 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689374#comment-15689374 ] Varun Saxena commented on YARN-5911: Thanks [~Naganarasimha] for the review and commit and thanks

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688868#comment-15688868 ] Hudson commented on YARN-5911: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10878 (See

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-22 Thread Naganarasimha G R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686532#comment-15686532 ] Naganarasimha G R commented on YARN-5911: - Thanks [~varun_saxena], Patch looks fine and will commit

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-21 Thread sandflee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684917#comment-15684917 ] sandflee commented on YARN-5911: sorry, not noticed it was removed in the patch, patch LGTM >

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683929#comment-15683929 ] Varun Saxena commented on YARN-5911: bq. seems no need to keep var stopped in DrainDispatcher?

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-21 Thread sandflee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683146#comment-15683146 ] sandflee commented on YARN-5911: seems no need to keep var stopped in DrainDispatcher? > DrainDispatcher

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682986#comment-15682986 ] Hadoop QA commented on YARN-5911: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-21 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15682941#comment-15682941 ] Varun Saxena commented on YARN-5911: Thanks sandflee and Bibin for review. You are correct. We can

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-18 Thread sandflee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678114#comment-15678114 ] sandflee commented on YARN-5911: thanks [~varun_saxena], one minor comment: if events not drained, we

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-18 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677090#comment-15677090 ] Bibin A Chundatt commented on YARN-5911: Thank you [~varun_saxena] for jira. Overall patch looks

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675964#comment-15675964 ] Hadoop QA commented on YARN-5911: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true

2016-11-17 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675927#comment-15675927 ] Varun Saxena commented on YARN-5911: Added the test case in TestAsyncDispatcher itself instead of