[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146737#comment-16146737
]
Hudson commented on YARN-6027:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12271 (See
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891719#comment-15891719
]
Varun Saxena commented on YARN-6027:
[~sjlee0], thanks!
While cherry-picking there was a conflict and I
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891589#comment-15891589
]
Rohith Sharma K S commented on YARN-6027:
-
Thanks [~sjlee0] and [~varun_saxena] for reviewing and
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891269#comment-15891269
]
Sangjin Lee commented on YARN-6027:
---
Committing the addendum patch to YARN-5355-branch-2.
> Support
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891235#comment-15891235
]
Sangjin Lee commented on YARN-6027:
---
The YARN-5355-branch-2 branch is failing compilation at
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890484#comment-15890484
]
Sangjin Lee commented on YARN-6027:
---
+1. Thanks [~rohithsharma]!
> Support fromid(offset) filter for
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890390#comment-15890390
]
Varun Saxena commented on YARN-6027:
Thanks [~rohithsharma] for the patch.
The latest patch looks good
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890173#comment-15890173
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890099#comment-15890099
]
Varun Saxena commented on YARN-6027:
Yes.
> Support fromid(offset) filter for /flows API
>
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890096#comment-15890096
]
Rohith Sharma K S commented on YARN-6027:
-
>From above, basically 2 points to be considered right?
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890033#comment-15890033
]
Varun Saxena commented on YARN-6027:
Thanks [~rohithsharma] for the patch.
You have turned
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889646#comment-15889646
]
Varun Saxena commented on YARN-6027:
Give me a couple of hours. Will review in detail...
> Support
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889636#comment-15889636
]
Rohith Sharma K S commented on YARN-6027:
-
[~varun_saxena] do you have any additional comments on
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889629#comment-15889629
]
Varun Saxena commented on YARN-6027:
[~rohithsharma], can you fix the pending checkstyles? Seem
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889608#comment-15889608
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889593#comment-15889593
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889497#comment-15889497
]
Rohith Sharma K S commented on YARN-6027:
-
Thanks [~sjlee0] and [~varun_saxena] for the review.
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888660#comment-15888660
]
Varun Saxena commented on YARN-6027:
bq. Specifically my proposal is to change the existing calls by
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888630#comment-15888630
]
Sangjin Lee commented on YARN-6027:
---
OK how about this? The {{TimelineUIDConverter}} class also uses
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888616#comment-15888616
]
Varun Saxena commented on YARN-6027:
By the way, findbugs warning is an extant warning which means it
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888606#comment-15888606
]
Varun Saxena commented on YARN-6027:
Same here. Clueless about the findbugs warning. Had tried a few
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888594#comment-15888594
]
Sangjin Lee commented on YARN-6027:
---
Thanks for the updated patch [~rohithsharma].
I'm not sure what the
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888491#comment-15888491
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888417#comment-15888417
]
Varun Saxena commented on YARN-6027:
For some reason, Jenkins hasn't invoked. Will do so manually.
>
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887442#comment-15887442
]
Varun Saxena commented on YARN-6027:
bq. Any converter class that does both can implement both separate
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887179#comment-15887179
]
Rohith Sharma K S commented on YARN-6027:
-
bq. I am also not 100% sold on RowKey. Again, it is not
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886893#comment-15886893
]
Sangjin Lee commented on YARN-6027:
---
To me {{RowKeyConverter}} is really an orthogonal conversion from
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886195#comment-15886195
]
Varun Saxena commented on YARN-6027:
[~rohithsharma],
bq. both are same right? any issues will happen
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886146#comment-15886146
]
Rohith Sharma K S commented on YARN-6027:
-
bq. RowKeyConverter interface's type parameter can
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886075#comment-15886075
]
Varun Saxena commented on YARN-6027:
Thanks [~rohithsharma] for the patch.
The approach looks fine to
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885408#comment-15885408
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883397#comment-15883397
]
Sangjin Lee commented on YARN-6027:
---
Thanks for the clarification. I forgot that this is something that
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882074#comment-15882074
]
Rohith Sharma K S commented on YARN-6027:
-
bq. Is there a reason not to simply use it?
The row key
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881960#comment-15881960
]
Rohith Sharma K S commented on YARN-6027:
-
bq. I am a little curious about this refactoring. Is the
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881523#comment-15881523
]
Sangjin Lee commented on YARN-6027:
---
In addition to [~varun_saxena]'s comments, I have a couple of
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881025#comment-15881025
]
Varun Saxena commented on YARN-6027:
Thanks [~rohithsharma] for the patch. As discussed offline, I am
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880860#comment-15880860
]
Sangjin Lee commented on YARN-6027:
---
Thanks [~rohithsharma] for the updated patch. I'll review it today.
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880419#comment-15880419
]
Varun Saxena commented on YARN-6027:
At a broad level, I am fine with the approach of doing FROM_ID
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880321#comment-15880321
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873201#comment-15873201
]
Varun Saxena commented on YARN-6027:
I think whatever you said about fromId being different for
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872992#comment-15872992
]
Rohith Sharma K S commented on YARN-6027:
-
I am confused with the whole stuff what are we going to
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872457#comment-15872457
]
Varun Saxena commented on YARN-6027:
By the way can we refactor the Timeline UID converter class to
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872385#comment-15872385
]
Varun Saxena commented on YARN-6027:
bq. IIUC, FROM_ID will be different for different storage layers.
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872295#comment-15872295
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872014#comment-15872014
]
Rohith Sharma K S commented on YARN-6027:
-
Given this JIRA require to handle common implementation
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871560#comment-15871560
]
Varun Saxena commented on YARN-6027:
[~rohithsharma], we had discussed this in yesterday's call. I
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871517#comment-15871517
]
Rohith Sharma K S commented on YARN-6027:
-
I would be more leaning towards adding new field FROM_ID
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871125#comment-15871125
]
Rohith Sharma K S commented on YARN-6027:
-
bq. we're exposing a lot of immediate values in the
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871122#comment-15871122
]
Rohith Sharma K S commented on YARN-6027:
-
bq. On a related note, how would the client provide the
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868746#comment-15868746
]
Li Lu commented on YARN-6027:
-
Thanks [~rohithsharma]! Generally fine but one nit is that we're exposing a lot
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868739#comment-15868739
]
Sangjin Lee commented on YARN-6027:
---
On a related note, how would the client provide the value for
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865941#comment-15865941
]
Varun Saxena commented on YARN-6027:
[~rohithsharma], we can probably pass encoded ID in info field
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865883#comment-15865883
]
Varun Saxena commented on YARN-6027:
bq. define new character set for separator.
No matter what we
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865833#comment-15865833
]
Rohith Sharma K S commented on YARN-6027:
-
bq. What about escaping / in cluster ? Do we want to
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864389#comment-15864389
]
Varun Saxena commented on YARN-6027:
Thanks [~rohithsharma] for the patch. Few comments.
# I think we
[
https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863439#comment-15863439
]
Hadoop QA commented on YARN-6027:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
56 matches
Mail list logo
