[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199968#comment-16199968
]
Varun Vasudev commented on YARN-6033:
-
[~leftnoteasy] - do you mind committing this to branch-2?
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199215#comment-16199215
]
Hadoop QA commented on YARN-6033:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120407#comment-16120407
]
Hudson commented on YARN-6033:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12155 (See
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120363#comment-16120363
]
Wangda Tan commented on YARN-6033:
--
Committed to trunk, thanks [~vvasudev] and thanks reviews from
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119438#comment-16119438
]
Sunil G commented on YARN-6033:
---
I am fine with latest patch.
Thanks.
> Add support for sections in
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119013#comment-16119013
]
Hadoop QA commented on YARN-6033:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118863#comment-16118863
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118843#comment-16118843
]
Wangda Tan commented on YARN-6033:
--
[~sunilg]/[~vvasudev], could one of you help bless the latest patch.
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118834#comment-16118834
]
Miklos Szegedi commented on YARN-6033:
--
+1 (non-binding). Thank you for the fixes, [~wangda]. Note:
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117677#comment-16117677
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117675#comment-16117675
]
Miklos Szegedi commented on YARN-6033:
--
Thank you for the patch [~wangda]. The last comments are style
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117604#comment-16117604
]
Miklos Szegedi commented on YARN-6033:
--
{code}
485 cfg->size = 0;
486 conf_file =
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117495#comment-16117495
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117351#comment-16117351
]
Wangda Tan commented on YARN-6033:
--
Thanks [~miklos.szeg...@cloudera.com], will update patch shortly.
>
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117247#comment-16117247
]
Miklos Szegedi commented on YARN-6033:
--
[~wangda], sorry there is an issue in the latest change:
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117084#comment-16117084
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116907#comment-16116907
]
Miklos Szegedi commented on YARN-6033:
--
[~wangda], I agree that is a much cleaner and standard
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115557#comment-16115557
]
Wangda Tan commented on YARN-6033:
--
[~miklos.szeg...@cloudera.com],
I think the better solution should
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115181#comment-16115181
]
Miklos Szegedi commented on YARN-6033:
--
Sorry, I think I found one more in the latest patch.
{code}
58
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115111#comment-16115111
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113803#comment-16113803
]
Hadoop QA commented on YARN-6033:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113603#comment-16113603
]
Wangda Tan commented on YARN-6033:
--
[~miklos.szeg...@cloudera.com], regardless if you're committer or not,
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113592#comment-16113592
]
Miklos Szegedi commented on YARN-6033:
--
I am not a committer, so you do not need my approval. I just
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113478#comment-16113478
]
Miklos Szegedi commented on YARN-6033:
--
Thank you, [~vvasudev] and [~wangda]. I looked through the
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113289#comment-16113289
]
Wangda Tan commented on YARN-6033:
--
Latest patch looks good to me too, waiting for +1 from
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112595#comment-16112595
]
Sunil G commented on YARN-6033:
---
I think I am fine with latest patch here. I will wait for
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112257#comment-16112257
]
Varun Vasudev commented on YARN-6033:
-
{quote}
How about the name? I think we should should call trim
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111913#comment-16111913
]
Miklos Szegedi commented on YARN-6033:
--
I found one more thing:
{code}
struct configuration CFG =
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111531#comment-16111531
]
Miklos Szegedi commented on YARN-6033:
--
Thanks, [~vvasudev].
bq. I would prefer not to do this, we
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110901#comment-16110901
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107847#comment-16107847
]
Miklos Szegedi commented on YARN-6033:
--
Thank you, [~vvasudev] for the patch. I have some
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106623#comment-16106623
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106603#comment-16106603
]
Hadoop QA commented on YARN-6033:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100861#comment-16100861
]
Wangda Tan commented on YARN-6033:
--
While doing compilation with the patch, I found it breaks build for
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095405#comment-16095405
]
Wangda Tan commented on YARN-6033:
--
[~vvasudev],
While doing test for YARN-6223 (based on this patch). I
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084718#comment-16084718
]
Wangda Tan commented on YARN-6033:
--
Thanks [~vvasudev],
bq. I've avoided this for now. My thinking was
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083853#comment-16083853
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083811#comment-16083811
]
Hadoop QA commented on YARN-6033:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077103#comment-16077103
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green} 1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077029#comment-16077029
]
Wangda Tan commented on YARN-6033:
--
Thanks [~vvasudev] for the patch. I just took a look at the patch, in
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820719#comment-15820719
]
Sunil G commented on YARN-6033:
---
Thanks [~vvasudev] for patch
Few doubts/comments:
1. one doubt. In
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798202#comment-15798202
]
Varun Vasudev commented on YARN-6033:
-
[~sunilg], [~sidharta-s] - can you please take a look? Thanks!
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798013#comment-15798013
]
Hadoop QA commented on YARN-6033:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797706#comment-15797706
]
Hadoop QA commented on YARN-6033:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
44 matches
Mail list logo
