[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954485#comment-15954485 ] Wangda Tan commented on YARN-6406: -- LGTM, +1. Thanks [~asuresh], will commit tomorrow. > Garbage Collect

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954339#comment-15954339 ] Hadoop QA commented on YARN-6406: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953895#comment-15953895 ] Wangda Tan commented on YARN-6406: -- Filed YARN-6429 and will work on that once this patch is done. >

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953889#comment-15953889 ] Wangda Tan commented on YARN-6406: -- bq. I think the right approach is to fix the test case (which might be

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951845#comment-15951845 ] Arun Suresh commented on YARN-6406: --- Thanks for the review [~leftnoteasy], bq. Why changes of AppInfo

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951819#comment-15951819 ] Hadoop QA commented on YARN-6406: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951798#comment-15951798 ] Wangda Tan commented on YARN-6406: -- Thanks [~asuresh] for working on the fix, my comments: 1) Why

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951542#comment-15951542 ] Jason Lowe commented on YARN-6406: -- Yep, the refcount was only added because of the possibility of the two

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951526#comment-15951526 ] Arun Suresh commented on YARN-6406: --- bq. Regarding to this, I don't think we need the #ref any more,

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951418#comment-15951418 ] Wangda Tan commented on YARN-6406: -- Nice catch [~arun.sur...@gmail.com]. [~asuresh]/[~jlowe], I totally

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946028#comment-15946028 ] Jason Lowe commented on YARN-6406: -- I haven't dug into YARN-6040, but in general I'm a big +1 for having

[jira] [Commented] (YARN-6406) Garbage Collect unused SchedulerRequestKeys

[ https://issues.apache.org/jira/browse/YARN-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945990#comment-15945990 ] Arun Suresh commented on YARN-6406: --- [~leftnoteasy] / [~jlowe] Thoughts ? > Garbage Collect unused