[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-31 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951256#comment-15951256 ] Yufei Gu commented on YARN-6411: Thanks [~jlowe] for the review and commit! > Clean up the overwrite of

[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-31 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951132#comment-15951132 ] Hudson commented on YARN-6411: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11508 (See

[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-31 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951087#comment-15951087 ] Jason Lowe commented on YARN-6411: -- +1 lgtm. Committing this. > Clean up the overwrite of

[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-30 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949756#comment-15949756 ] Yufei Gu commented on YARN-6411: The test failure is unrelated.

[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949707#comment-15949707 ] Hadoop QA commented on YARN-6411: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-30 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949443#comment-15949443 ] Yufei Gu commented on YARN-6411: Thanks [~jlowe] for the review. After patch v1, I found that we have a

[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-30 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949230#comment-15949230 ] Jason Lowe commented on YARN-6411: -- Thanks for the patch! Looks good overall. It would be nice to

[jira] [Commented] (YARN-6411) Clean up the overwrite of createDispatcher() in subclass of MockRM

2017-03-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948695#comment-15948695 ] Hadoop QA commented on YARN-6411: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||