[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451041#comment-16451041
]
Hudson commented on YARN-6623:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227526#comment-16227526
]
Andrew Wang commented on YARN-6623:
---
Hi Varun, do you mind adding a release note for this JIRA, given
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210188#comment-16210188
]
Wangda Tan commented on YARN-6623:
--
Attached patch LGTM, thanks [~vvasudev].
> Add support to turn off
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207833#comment-16207833
]
Eric Yang commented on YARN-6623:
-
[~vvasudev] I opened YARN-7344 to track failed unit test issues on
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207265#comment-16207265
]
Varun Vasudev commented on YARN-6623:
-
[~leftnoteasy] - can you take a look at the branch-2 patch
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207264#comment-16207264
]
Varun Vasudev commented on YARN-6623:
-
[~eyang] - the tests did run as part of the trunk pre-commit
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206764#comment-16206764
]
Eric Yang commented on YARN-6623:
-
The current trunk seems to fail on these test cases:
{code}
[ FAILED
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206761#comment-16206761
]
Eric Yang commented on YARN-6623:
-
Talked to [~wangda] and he said the test can be triggered using:
{code}
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206736#comment-16206736
]
Eric Yang commented on YARN-6623:
-
[~vvasudev] How is the C++ test case getting triggered? mvn clean test
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206505#comment-16206505
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206061#comment-16206061
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205697#comment-16205697
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193974#comment-16193974
]
Eric Yang commented on YARN-6623:
-
[~ebadger] In some secure environment, I have seen that
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193001#comment-16193001
]
Eric Badger commented on YARN-6623:
---
bq. It can be deprecated or used for fast-failing containers. I'm
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192875#comment-16192875
]
Varun Vasudev commented on YARN-6623:
-
{quote}
There's already a config in yarn-site.xml
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192537#comment-16192537
]
Jian He commented on YARN-6623:
---
Got a question, for this config added
docker.allowed.networks=## comma
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186186#comment-16186186
]
Andrew Wang commented on YARN-6623:
---
Sorry, this missed the train for RC0. We'll pick it up for GA, or
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185866#comment-16185866
]
Varun Vasudev commented on YARN-6623:
-
Thanks for the reviews [~ebadger],
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185134#comment-16185134
]
Hudson commented on YARN-6623:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12994 (See
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185131#comment-16185131
]
Wangda Tan commented on YARN-6623:
--
[~andrew.wang], I just saw your email for branch-3.0.0-beta1 cut, is
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185129#comment-16185129
]
Wangda Tan commented on YARN-6623:
--
Discussed with [~eyang] / [~vvasudev] / [~shaneku...@gmail.com],
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184433#comment-16184433
]
Andrew Wang commented on YARN-6623:
---
Thanks Varun. Considering this is targeted at 2.8.2, if we're okay
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184415#comment-16184415
]
Miklos Szegedi commented on YARN-6623:
--
If the decision is to ignore this bug for beta1, how about
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184174#comment-16184174
]
Shane Kumpf commented on YARN-6623:
---
Thanks for addressing my comments. I can confirm that docker inspect
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183909#comment-16183909
]
Varun Vasudev commented on YARN-6623:
-
[~andrew.wang] - the one thing you should be aware of is that
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183050#comment-16183050
]
Andrew Wang commented on YARN-6623:
---
Folks, this is currently marked as the last blocker for beta1. I
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181845#comment-16181845
]
Eric Yang commented on YARN-6623:
-
[~wangda] How does a non-privileged user acquire excessive permission by
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181628#comment-16181628
]
Wangda Tan commented on YARN-6623:
--
[~eyang],
Thanks for the comments. I'm agree with #2, which we
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181413#comment-16181413
]
Eric Yang commented on YARN-6623:
-
A couple concerns:
# Moving code from Java to C without findbugs check
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179552#comment-16179552
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179268#comment-16179268
]
Eric Badger commented on YARN-6623:
---
Looks good to me! +1 (non-binding) pending jenkins
> Add support to
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179207#comment-16179207
]
Eric Badger commented on YARN-6623:
---
Hey [~vvasudev], thanks for the updated patch! The changes related
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178317#comment-16178317
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178263#comment-16178263
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177577#comment-16177577
]
Varun Vasudev commented on YARN-6623:
-
[~andrew.wang] - YARN-4266 adds a new field for the Docker
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177578#comment-16177578
]
Varun Vasudev commented on YARN-6623:
-
[~andrew.wang] - YARN-4266 adds a new field for the Docker
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177381#comment-16177381
]
Junping Du commented on YARN-6623:
--
Hi [~vvasudev], do you agree with what we discussed in security alias
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176868#comment-16176868
]
Andrew Wang commented on YARN-6623:
---
Varun, can we commit the trunk/branch-3.0 patch today? YARN-4266 is
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176435#comment-16176435
]
Arun Suresh commented on YARN-6623:
---
Thanks for the heads up [~djp].. Kindly do push this into branch-2
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176346#comment-16176346
]
Varun Vasudev commented on YARN-6623:
-
[~leftnoteasy] - please don't commit the patch tomorrow. I need
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175908#comment-16175908
]
Junping Du commented on YARN-6623:
--
bq. I plan to commit the patch to trunk/branch-3.0 tomorrow if no more
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175755#comment-16175755
]
Wangda Tan commented on YARN-6623:
--
Thanks [~vvasudev] and all other folks for the hard work to finish /
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175416#comment-16175416
]
Eric Badger commented on YARN-6623:
---
Given that docker is alpha in 2.8.2, I agree with [~vinodkv] that we
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175386#comment-16175386
]
Junping Du commented on YARN-6623:
--
bq. We have already documented that the docker feature is alpha, not
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175308#comment-16175308
]
Vinod Kumar Vavilapalli commented on YARN-6623:
---
[~djp], this is too big a change and a patch
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175249#comment-16175249
]
Miklos Szegedi commented on YARN-6623:
--
Indeed, I verified and we still need the strlen in the first
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175201#comment-16175201
]
Varun Vasudev commented on YARN-6623:
-
{noformat}
How would you detect the condition where the
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175181#comment-16175181
]
Varun Vasudev commented on YARN-6623:
-
[~djp] - makes sense to push it into 2.8.2; [~andrew.wang] -
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173952#comment-16173952
]
Miklos Szegedi commented on YARN-6623:
--
[~vvasudev], thank you for the updated patch. I will review it
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173856#comment-16173856
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173795#comment-16173795
]
Junping Du commented on YARN-6623:
--
Thanks [~vvasudev] for working hard on this effort and everyone for
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170280#comment-16170280
]
Varun Vasudev commented on YARN-6623:
-
Thanks for the feedback [~miklos.szeg...@cloudera.com],
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169141#comment-16169141
]
Shane Kumpf commented on YARN-6623:
---
Thanks for the patch [~vvasudev]! Overall it looks great. Thanks for
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165527#comment-16165527
]
Miklos Szegedi commented on YARN-6623:
--
Thank you for the patch [~vvasudev] and for the reviews
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157393#comment-16157393
]
Eric Badger commented on YARN-6623:
---
I think we may want to look further into the issue with the c99 vs.
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157236#comment-16157236
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157134#comment-16157134
]
Eric Badger commented on YARN-6623:
---
{quote}
Additionally, the native code doesn't compile for me on my
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155591#comment-16155591
]
Eric Badger commented on YARN-6623:
---
{{git apply}} is failing for me on DockerClient.java. It looks like
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152960#comment-16152960
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147810#comment-16147810
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147713#comment-16147713
]
Eric Badger commented on YARN-6623:
---
Hey [~vvasudev], thanks for the update. It looks like most of my
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144207#comment-16144207
]
Wangda Tan commented on YARN-6623:
--
Thanks [~vvasudev],
Apologize for the delays. I haven't done any
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142372#comment-16142372
]
Eric Badger commented on YARN-6623:
---
{noformat}
container-executor.c:run_docker()
+ docker_command =
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140761#comment-16140761
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137515#comment-16137515
]
Eric Badger commented on YARN-6623:
---
Hey [~vvasudev], I’ve finished my comments on the production code
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135420#comment-16135420
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135306#comment-16135306
]
Eric Badger commented on YARN-6623:
---
[~vvasudev], I started reviewing the .003 patch, but I see that
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135245#comment-16135245
]
Varun Vasudev commented on YARN-6623:
-
{quote}
#define EXECUTOR_PATH_MAX 131072
This is lots
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135223#comment-16135223
]
Shane Kumpf commented on YARN-6623:
---
{quote}
#define EXECUTOR_PATH_MAX 131072
This is lots of
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135193#comment-16135193
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131651#comment-16131651
]
Miklos Szegedi commented on YARN-6623:
--
Thank you for the patch, [~vvasudev]. I had time to check only
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128525#comment-16128525
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127536#comment-16127536
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127494#comment-16127494
]
Eric Badger commented on YARN-6623:
---
I'll review the patch sometime this week
> Add support to turn off
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126228#comment-16126228
]
Hadoop QA commented on YARN-6623:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116129#comment-16116129
]
Varun Vasudev commented on YARN-6623:
-
To fix this, we need support for sections provided by YARN-6033.
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112271#comment-16112271
]
Varun Vasudev commented on YARN-6623:
-
Just to note - we should document this in the release notes
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111776#comment-16111776
]
Miklos Szegedi commented on YARN-6623:
--
I updated this to blocker, because I think 3.0 should not ship
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111499#comment-16111499
]
Miklos Szegedi commented on YARN-6623:
--
[~dan...@cloudera.com], this is needed I think for defense in
[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015619#comment-16015619
]
Daniel Templeton commented on YARN-6623:
It's not obvious to me why having two ways to disable
80 matches
Mail list logo
