[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261504#comment-16261504
]
Haibo Chen commented on YARN-7390:
--
The unit test issue is bogus, no actual unit test failures caused by
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261478#comment-16261478
]
Hadoop QA commented on YARN-7390:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261312#comment-16261312
]
Haibo Chen commented on YARN-7390:
--
+1 on the branch-2 patch pending Jenkins.
> All reservation related
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261291#comment-16261291
]
Haibo Chen commented on YARN-7390:
--
Reopened to trigger the branch-2 jenkins job.
> All reservation
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259991#comment-16259991
]
Subru Krishnan commented on YARN-7390:
--
[~yufeigu]/[~haibo.chen], thanks for fixing this. Shouldn't it
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255806#comment-16255806
]
Hudson commented on YARN-7390:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13247 (See
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255783#comment-16255783
]
Yufei Gu commented on YARN-7390:
Thanks [~haibo.chen] for review and commit.
> All reservation related
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254205#comment-16254205
]
Haibo Chen commented on YARN-7390:
--
+1. Will commit it later today if there is no objection
> All
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254061#comment-16254061
]
Hadoop QA commented on YARN-7390:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241016#comment-16241016
]
Hadoop QA commented on YARN-7390:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238279#comment-16238279
]
Hadoop QA commented on YARN-7390:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238023#comment-16238023
]
Yufei Gu commented on YARN-7390:
Thanks for the review, [~haibo.chen]. Uploaded patch v3 for all comments.
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227136#comment-16227136
]
Haibo Chen commented on YARN-7390:
--
Thanks @Yufei for the update!
1) testAMRMToken() should probably call
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221644#comment-16221644
]
Hadoop QA commented on YARN-7390:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219729#comment-16219729
]
Haibo Chen commented on YARN-7390:
--
I see. Was thinking that the failure was caused merely by
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219687#comment-16219687
]
Subru Krishnan commented on YARN-7390:
--
Thanks [~yufeigu] and [~haibo.chen] for your thoughts.
I am
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219625#comment-16219625
]
Haibo Chen commented on YARN-7390:
--
Like Yufei said, we have considered parameterizing all unit tests that
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219584#comment-16219584
]
Yufei Gu commented on YARN-7390:
Yeah, I agreed. I actually pointed out the same thing when I review
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219547#comment-16219547
]
Subru Krishnan commented on YARN-7390:
--
[~yufeigu], thanks for the clarification. I prefer
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219537#comment-16219537
]
Yufei Gu commented on YARN-7390:
Thanks for the review, [~subru]. You need to set scheduler class to Fair
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219439#comment-16219439
]
Subru Krishnan commented on YARN-7390:
--
Thanks [~yufeigu] for the quick fix. The patch LGTM, can you
[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217947#comment-16217947
]
Hadoop QA commented on YARN-7390:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
22 matches
Mail list logo