[jira] [Commented] (YARN-746) rename Service.register() and Service.unregister() to registerServiceListener() unregisterServiceListener() respectively
[
https://issues.apache.org/jira/browse/YARN-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683282#comment-13683282
]
Hudson commented on YARN-746:
-
Integrated in Hadoop-Yarn-trunk #240 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/240/])
YARN-746. Renamed Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively.
Contributed by Steve Loughran. (Revision 1492780)
Result = SUCCESS
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1492780
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/FilterService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/AuxServices.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
rename Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively
--
Key: YARN-746
URL: https://issues.apache.org/jira/browse/YARN-746
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Steve Loughran
Assignee: Steve Loughran
Fix For: 2.1.0-beta
Attachments: YARN-746-001.patch
make it clear what you are registering on a {{Service}} by naming the methods
{{registerServiceListener()}} {{unregisterServiceListener()}} respectively.
This only affects a couple of production classes; {{Service.register()}} and
is used in some of the lifecycle tests of the YARN-530. There are no tests of
{{Service.unregister()}}, which is something that could be corrected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-746) rename Service.register() and Service.unregister() to registerServiceListener() unregisterServiceListener() respectively
[
https://issues.apache.org/jira/browse/YARN-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683370#comment-13683370
]
Hudson commented on YARN-746:
-
Integrated in Hadoop-Mapreduce-trunk #1457 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1457/])
YARN-746. Renamed Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively.
Contributed by Steve Loughran. (Revision 1492780)
Result = FAILURE
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1492780
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/FilterService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/AuxServices.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
rename Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively
--
Key: YARN-746
URL: https://issues.apache.org/jira/browse/YARN-746
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Steve Loughran
Assignee: Steve Loughran
Fix For: 2.1.0-beta
Attachments: YARN-746-001.patch
make it clear what you are registering on a {{Service}} by naming the methods
{{registerServiceListener()}} {{unregisterServiceListener()}} respectively.
This only affects a couple of production classes; {{Service.register()}} and
is used in some of the lifecycle tests of the YARN-530. There are no tests of
{{Service.unregister()}}, which is something that could be corrected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-746) rename Service.register() and Service.unregister() to registerServiceListener() unregisterServiceListener() respectively
[
https://issues.apache.org/jira/browse/YARN-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683384#comment-13683384
]
Hudson commented on YARN-746:
-
Integrated in Hadoop-Hdfs-trunk #1430 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1430/])
YARN-746. Renamed Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively.
Contributed by Steve Loughran. (Revision 1492780)
Result = FAILURE
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1492780
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/FilterService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/AuxServices.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
rename Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively
--
Key: YARN-746
URL: https://issues.apache.org/jira/browse/YARN-746
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Steve Loughran
Assignee: Steve Loughran
Fix For: 2.1.0-beta
Attachments: YARN-746-001.patch
make it clear what you are registering on a {{Service}} by naming the methods
{{registerServiceListener()}} {{unregisterServiceListener()}} respectively.
This only affects a couple of production classes; {{Service.register()}} and
is used in some of the lifecycle tests of the YARN-530. There are no tests of
{{Service.unregister()}}, which is something that could be corrected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-746) rename Service.register() and Service.unregister() to registerServiceListener() unregisterServiceListener() respectively
[
https://issues.apache.org/jira/browse/YARN-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682459#comment-13682459
]
Vinod Kumar Vavilapalli commented on YARN-746:
--
Looks good. +1. Checking this in.
rename Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively
--
Key: YARN-746
URL: https://issues.apache.org/jira/browse/YARN-746
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Steve Loughran
Assignee: Steve Loughran
Attachments: YARN-746-001.patch
make it clear what you are registering on a {{Service}} by naming the methods
{{registerServiceListener()}} {{unregisterServiceListener()}} respectively.
This only affects a couple of production classes; {{Service.register()}} and
is used in some of the lifecycle tests of the YARN-530. There are no tests of
{{Service.unregister()}}, which is something that could be corrected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-746) rename Service.register() and Service.unregister() to registerServiceListener() unregisterServiceListener() respectively
[
https://issues.apache.org/jira/browse/YARN-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682477#comment-13682477
]
Hudson commented on YARN-746:
-
Integrated in Hadoop-trunk-Commit #3912 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/3912/])
YARN-746. Renamed Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively.
Contributed by Steve Loughran. (Revision 1492780)
Result = SUCCESS
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1492780
Files :
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/AbstractService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/FilterService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/service/Service.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/AuxServices.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
rename Service.register() and Service.unregister() to
registerServiceListener() unregisterServiceListener() respectively
--
Key: YARN-746
URL: https://issues.apache.org/jira/browse/YARN-746
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Steve Loughran
Assignee: Steve Loughran
Fix For: 2.1.0-beta
Attachments: YARN-746-001.patch
make it clear what you are registering on a {{Service}} by naming the methods
{{registerServiceListener()}} {{unregisterServiceListener()}} respectively.
This only affects a couple of production classes; {{Service.register()}} and
is used in some of the lifecycle tests of the YARN-530. There are no tests of
{{Service.unregister()}}, which is something that could be corrected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
