[jira] [Commented] (YARN-7966) Remove method AllocationConfiguration#getQueueAcl and related unit tests
[ https://issues.apache.org/jira/browse/YARN-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441941#comment-16441941 ] Sen Zhao commented on YARN-7966: Thanks [~yufeigu] for review. > Remove method AllocationConfiguration#getQueueAcl and related unit tests > > > Key: YARN-7966 > URL: https://issues.apache.org/jira/browse/YARN-7966 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.1.0 >Reporter: Yufei Gu >Assignee: Sen Zhao >Priority: Minor > Labels: newbie++ > Fix For: 3.2.0 > > Attachments: YARN-7966.001.patch, YARN-7966.002.patch > > > AllocationConfiguration#getQueueAcl isn't needed any more after YARN-4997. We > should remove it and its related unit test. All its logic is reimplemented in > AllocationFileLoaderService#getDefaultPermissions. class > AllocationConfiguration doesn't have any API annotation, it is considered as > private. So it is OK to remove its public method. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7966) Remove method AllocationConfiguration#getQueueAcl and related unit tests
[ https://issues.apache.org/jira/browse/YARN-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441936#comment-16441936 ] Yufei Gu commented on YARN-7966: Committed to trunk. Thanks [~Sen Zhao] for the patch. > Remove method AllocationConfiguration#getQueueAcl and related unit tests > > > Key: YARN-7966 > URL: https://issues.apache.org/jira/browse/YARN-7966 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler >Affects Versions: 3.1.0 >Reporter: Yufei Gu >Assignee: Sen Zhao >Priority: Minor > Labels: newbie++ > Fix For: 3.2.0 > > Attachments: YARN-7966.001.patch, YARN-7966.002.patch > > > AllocationConfiguration#getQueueAcl isn't needed any more after YARN-4997. We > should remove it and its related unit test. All its logic is reimplemented in > AllocationFileLoaderService#getDefaultPermissions. class > AllocationConfiguration doesn't have any API annotation, it is considered as > private. So it is OK to remove its public method. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
