[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511814#comment-16511814 ] Hudson commented on YARN-8259: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #144

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511444#comment-16511444 ] genericqa commented on YARN-8259: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-12 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510290#comment-16510290 ] Shane Kumpf commented on YARN-8259: --- Thanks for the input everyone. {quote}Could you add

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-12 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510275#comment-16510275 ] Eric Yang commented on YARN-8259: - 4 People have expressed opinion to go with option #1.

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-11 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508657#comment-16508657 ] Eric Badger commented on YARN-8259: --- I would give a slight preference to proposal #1 bec

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-11 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508516#comment-16508516 ] Eric Yang commented on YARN-8259: - I prefer #3 to keep abstraction in place, and improve p

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508198#comment-16508198 ] Jim Brennan commented on YARN-8259: --- I think we should go with Option 1 with documentati

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-10 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507437#comment-16507437 ] Shane Kumpf commented on YARN-8259: --- [~eyang], [~Jim_Brennan], [~ebadger], [~jlowe] - an

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-31 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497266#comment-16497266 ] Shane Kumpf commented on YARN-8259: --- Thanks for the feedback, [~ebadger]. {quote}if the

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-31 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497239#comment-16497239 ] Eric Badger commented on YARN-8259: --- For proposal #1, if the yarn user is whitelisted fo

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-31 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496492#comment-16496492 ] Shane Kumpf commented on YARN-8259: --- I've been doing additional testing here and could u

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-22 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484271#comment-16484271 ] Eric Yang commented on YARN-8259: - [~shaneku...@gmail.com] The proposal for implementing bo

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-22 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483845#comment-16483845 ] Shane Kumpf commented on YARN-8259: --- {quote}System administrator can reserve one cpu core

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483057#comment-16483057 ] Eric Yang commented on YARN-8259: - System administrator can reserve one cpu core for node m

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483041#comment-16483041 ] Eric Badger commented on YARN-8259: --- Also, I have tested the current patch for correctnes

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483038#comment-16483038 ] Eric Badger commented on YARN-8259: --- bq. If hidepid option is used by system administrato

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483032#comment-16483032 ] Jason Lowe commented on YARN-8259: -- I do agree with Shane that there are already subsystem

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483029#comment-16483029 ] Jason Lowe commented on YARN-8259: -- Ah comment race with [~eyang], I'll defer until his co

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483028#comment-16483028 ] Jason Lowe commented on YARN-8259: -- Thanks for the patch! +1 lgtm. I'll commit this tomo

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482992#comment-16482992 ] Eric Yang commented on YARN-8259: - If I am not mistaken, DockerContainerRuntime is running

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482729#comment-16482729 ] genericqa commented on YARN-8259: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |