[jira] [Commented] (YARN-836) Cleanup Apps & ConverterUtils & StringHelper & Times to avoid duplicate APIs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/YARN-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685457#comment-13685457
 ] 

Hadoop QA commented on YARN-836:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12588118/YARN-836.1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/1294//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1294//console

This message is automatically generated.

> Cleanup Apps & ConverterUtils & StringHelper & Times to avoid duplicate APIs
> 
>
> Key: YARN-836
> URL: https://issues.apache.org/jira/browse/YARN-836
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
> Attachments: YARN-836.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-836) Cleanup Apps & ConverterUtils & StringHelper & Times to avoid duplicate APIs

[Zhijie Shen (JIRA)]

[ 
https://issues.apache.org/jira/browse/YARN-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685020#comment-13685020
 ] 

Zhijie Shen commented on YARN-836:
--

Did some investigation. Bellow is the summary:

1. Methods in Times can be integrated to Time (hadoop-common).

2. join and percent in StringHelper are duplicate with those in StringUtils 
(hadoop-common). It's better to combine them as well.

3. toAppID in Apps is duplicate with toApplicationID in ConverterUtils

> Cleanup Apps & ConverterUtils & StringHelper & Times to avoid duplicate APIs
> 
>
> Key: YARN-836
> URL: https://issues.apache.org/jira/browse/YARN-836
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Zhijie Shen
>Assignee: Zhijie Shen
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira