[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926297#comment-16926297
]
Jonathan Hung commented on YARN-8361:
-
I've ported this to branch-3.1.
> Change App N
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545572#comment-16545572
]
Wangda Tan commented on YARN-8361:
--
Thanks [~Zian Chen] for the patch and thanks reviews
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543711#comment-16543711
]
Wangda Tan commented on YARN-8361:
--
LGTM +1, thanks [~Zian Chen] and reviews from [~suma.
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543598#comment-16543598
]
Zian Chen commented on YARN-8361:
-
Thanks [~suma.shivaprasad] for the review. [~leftnoteas
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543571#comment-16543571
]
Suma Shivaprasad commented on YARN-8361:
Thanks [~Zian Chen] Patch 003 LGTM. +1
>
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543549#comment-16543549
]
Zian Chen commented on YARN-8361:
-
Failed UT not related to this patch. [~suma.shivaprasad
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542360#comment-16542360
]
genericqa commented on YARN-8361:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1654#comment-1654
]
Zian Chen commented on YARN-8361:
-
[~suma.shivaprasad] , thanks for the review, Fixed the
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539411#comment-16539411
]
Suma Shivaprasad commented on YARN-8361:
[~Zian Chen] Patch 002 LGTM. +1
> Change
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523111#comment-16523111
]
genericqa commented on YARN-8361:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522987#comment-16522987
]
Zian Chen commented on YARN-8361:
-
[~suma.shivaprasad], thanks for the comments. Fixed the
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498383#comment-16498383
]
Suma Shivaprasad commented on YARN-8361:
[~Zian Chen] Patch looks good overall. I
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490146#comment-16490146
]
genericqa commented on YARN-8361:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490014#comment-16490014
]
Wangda Tan commented on YARN-8361:
--
+1, thanks [~Zian Chen], will commit once Jenkins come
[
https://issues.apache.org/jira/browse/YARN-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489896#comment-16489896
]
Zian Chen commented on YARN-8361:
-
[~leftnoteasy] , can you help review the patch? Thanks
15 matches
Mail list logo