[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-11 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683284#comment-16683284 ] Sunil Govindan commented on YARN-8877: -- In this context, {{attributes: null}} looks f

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-11 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683272#comment-16683272 ] Weiwei Yang commented on YARN-8877: --- Hi [~sunilg] Thanks for the comments. {quote}toInd

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-11 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683247#comment-16683247 ] Sunil Govindan commented on YARN-8877: -- Hi [~cheersyang]  Some minor nits: 1. toInd

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-08 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680617#comment-16680617 ] Wangda Tan commented on YARN-8877: -- [~cheersyang], make sense to me. > Extend service sp

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-06 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677460#comment-16677460 ] Weiwei Yang commented on YARN-8877: --- Hi [~leftnoteasy] I was thinking to put a more nea

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-06 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677039#comment-16677039 ] Wangda Tan commented on YARN-8877: -- [~cheersyang],  If YARN-8940 will satisfy all needs

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676354#comment-16676354 ] Hadoop QA commented on YARN-8877: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-05 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676284#comment-16676284 ] Weiwei Yang commented on YARN-8877: --- Thanks [~leftnoteasy] for the review, I uploaded th

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-11-05 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675496#comment-16675496 ] Wangda Tan commented on YARN-8877: -- Thanks [~cheersyang],  In general patch looks good,

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-10-23 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661623#comment-16661623 ] Weiwei Yang commented on YARN-8877: --- Hi [~sunilg], [~leftnoteasy] Pls help to review th

[jira] [Commented] (YARN-8877) Extend service spec to allow setting resource attributes

2018-10-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651500#comment-16651500 ] Hadoop QA commented on YARN-8877: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote