[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-03-28 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804075#comment-16804075 ] Szilard Nemeth commented on YARN-9318: -- Hi [~sunilg]! Do you think branh-3.2 / branch-3.1 patches

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-28 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780653#comment-16780653 ] Szilard Nemeth commented on YARN-9318: -- Hi [~templedf]! I have branch-3.2 and branch-3.1 patches as

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779635#comment-16779635 ] Hudson commented on YARN-9318: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16080 (See

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779621#comment-16779621 ] Szilard Nemeth commented on YARN-9318: -- Thanks [~templedf]! Sorry about the colons! >

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779591#comment-16779591 ] Hadoop QA commented on YARN-9318: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779582#comment-16779582 ] Daniel Templeton commented on YARN-9318: The @param tag shouldn't have a colon after the name, but

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779539#comment-16779539 ] Szilard Nemeth commented on YARN-9318: -- Updated the patch with javadocs. Please check it! >

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779516#comment-16779516 ] Daniel Templeton commented on YARN-9318: Nice. Love that you added JavaDocs. Could you finish out

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779447#comment-16779447 ] Hadoop QA commented on YARN-9318: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-27 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779387#comment-16779387 ] Szilard Nemeth commented on YARN-9318: -- Sure, I updated the patch with this (almost). multiplyTo

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778721#comment-16778721 ] Daniel Templeton commented on YARN-9318: That looks much cleaner. My last comment is that in the

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778706#comment-16778706 ] Hadoop QA commented on YARN-9318: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-26 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778661#comment-16778661 ] Szilard Nemeth commented on YARN-9318: -- Hi [~templedf]! Thanks for the review! 1. / 2. As discussed

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778600#comment-16778600 ] Daniel Templeton commented on YARN-9318: Thanks for the patch, [~snemeth]. I have a few comments:

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-25 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777137#comment-16777137 ] Sunil Govindan commented on YARN-9318: -- Thanks [~snemeth] I ll take a u look today >

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776276#comment-16776276 ] Hadoop QA commented on YARN-9318: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-24 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776217#comment-16776217 ] Szilard Nemeth commented on YARN-9318: -- Hi [~sunilg]! Sure, good idea as these are indeed similar

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-23 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776105#comment-16776105 ] Sunil Govindan commented on YARN-9318: -- Thanks for the patch [~snemeth]. I would like to optimize

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773199#comment-16773199 ] Hadoop QA commented on YARN-9318: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9318) Resources#multiplyAndRoundUp does not consider Resource Types

2019-02-20 Thread Gergely Pollak (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773147#comment-16773147 ] Gergely Pollak commented on YARN-9318: -- [~snemeth] thank you for the patch, LGTM +1 (Non-binding). >