[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801020#comment-16801020 ] Hudson commented on YARN-9391: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16277 (See

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-25 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801008#comment-16801008 ] Eric Badger commented on YARN-9391: --- +1 lgtm > Disable PATH variable to be passed to Docker container >

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-25 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800961#comment-16800961 ] Eric Yang commented on YARN-9391: - +1 verified with mapreduce, non-entrypoint mode, and entrypoint mode.

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-25 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800957#comment-16800957 ] Jim Brennan commented on YARN-9391: --- [~ebadger], [~eyang] patch 001 is ready for review.   > Disable

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800930#comment-16800930 ] Hadoop QA commented on YARN-9391: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-20 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797182#comment-16797182 ] Jim Brennan commented on YARN-9391: --- OK.  I will put up a patch to fix this issue.   > Disable PATH

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796620#comment-16796620 ] Eric Yang commented on YARN-9391: - [~Jim_Brennan] Yes, this is the cause to add the NM variables to

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796597#comment-16796597 ] Jim Brennan commented on YARN-9391: --- [~eyang] if the concern is only for Nodemanager white-list

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796569#comment-16796569 ] Eric Yang commented on YARN-9391: - In non-entry point mode docker, container works more like a chroot

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796560#comment-16796560 ] Jim Brennan commented on YARN-9391: --- [~ebadger] I assume you are referring to the PATH variable in

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796533#comment-16796533 ] Eric Badger commented on YARN-9391: --- bq. I think this issue is specific to the entry-point case where

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796521#comment-16796521 ] Jim Brennan commented on YARN-9391: --- {quote} The whitelist needs to behave differently for docker

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796467#comment-16796467 ] Eric Badger commented on YARN-9391: --- bq. When filtering PATH variable from environment white list, it

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796238#comment-16796238 ] Eric Yang commented on YARN-9391: - [~ebadger] When filtering PATH variable from environment white list, it

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796227#comment-16796227 ] Jim Brennan commented on YARN-9391: --- [~ebadger] you are correct.  It doesn't look like we explicitly add

[jira] [Commented] (YARN-9391) Disable PATH variable to be passed to Docker container

2019-03-19 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796216#comment-16796216 ] Eric Badger commented on YARN-9391: --- We can already do this today by changing the whitelist to not