[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141103#comment-17141103 ] Hudson commented on YARN-9460: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18370 (See

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-17 Thread Jira
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138552#comment-17138552 ] Hudáky Márton Gyula commented on YARN-9460: --- +1 (non-binding) > QueueACLsManager and

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-15 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135684#comment-17135684 ] Surendra Singh Lilhore commented on YARN-9460: -- +1, LGTM > QueueACLsManager and

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133381#comment-17133381 ] Hadoop QA commented on YARN-9460: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133345#comment-17133345 ] Peter Bacsko commented on YARN-9460: +1 (non-binding) pending Jenkins > QueueACLsManager and

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-11 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133277#comment-17133277 ] Bilwa S T commented on YARN-9460: - added @SuppressWarnings("checkstyle:visibilitymodifier") to avoid

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-11 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133081#comment-17133081 ] Peter Bacsko commented on YARN-9460: Thanks [~BilwaST] I have no further comments. > QueueACLsManager

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-10 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130456#comment-17130456 ] Bilwa S T commented on YARN-9460: - Hi [~pbacsko] # I will update 

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130447#comment-17130447 ] Peter Bacsko commented on YARN-9460: Another comment: {noformat} if (scheduler

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-10 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130411#comment-17130411 ] Peter Bacsko commented on YARN-9460: Thanks for the new patch [~BilwaST]. There are some checkstyle

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129680#comment-17129680 ] Hadoop QA commented on YARN-9460: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-05 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127016#comment-17127016 ] Hadoop QA commented on YARN-9460: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-05 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126919#comment-17126919 ] Bilwa S T commented on YARN-9460: - Hi [~pbacsko] Thanks for review. Yes you are correct. behaviour wont

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-05 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126673#comment-17126673 ] Peter Bacsko commented on YARN-9460: [~BilwaST] I have a comment. Right now if the scheduler is not

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-06-05 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126465#comment-17126465 ] Bilwa S T commented on YARN-9460: - cc [~inigoiri] > QueueACLsManager and ReservationsACLManager should

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-28 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118868#comment-17118868 ] Bilwa S T commented on YARN-9460: - [~snemeth] Please review when you have free time > QueueACLsManager

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-14 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107552#comment-17107552 ] Bilwa S T commented on YARN-9460: - Hi [~snemeth] can you please review this? > QueueACLsManager and

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-08 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102384#comment-17102384 ] Hadoop QA commented on YARN-9460: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102016#comment-17102016 ] Hadoop QA commented on YARN-9460: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-07 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101920#comment-17101920 ] Bilwa S T commented on YARN-9460: - Hi [~snemeth] Thanks for clarification. I didn't add SchedulerType

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-05 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099779#comment-17099779 ] Szilard Nemeth commented on YARN-9460: -- Hi [~BilwaST], Oh, I see what is your question now. I think

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-05 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099773#comment-17099773 ] Bilwa S T commented on YARN-9460: - Hi [~snemeth] Thanks for the clarification. This is clear from Jira

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-05-05 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099760#comment-17099760 ] Szilard Nemeth commented on YARN-9460: -- Hi [~BilwaST], One example of using instanceof is here:

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2020-04-28 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094724#comment-17094724 ] Bilwa S T commented on YARN-9460: - Hi [~snemeth]  I had one small doubt. So we make these as configurable

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2019-04-08 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812916#comment-16812916 ] Bibin A Chundatt commented on YARN-9460: Porbably in YARN-9459 then.. Probably best to include in

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2019-04-08 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812455#comment-16812455 ] Szilard Nemeth commented on YARN-9460: -- Hi [~bibinchundatt]! It's a good idea but ClientRMService

[jira] [Commented] (YARN-9460) QueueACLsManager and ReservationsACLManager should not use instanceof checks

2019-04-08 Thread Bibin A Chundatt (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812437#comment-16812437 ] Bibin A Chundatt commented on YARN-9460: Thank you [~snemeth] for raising Consider