[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148084#comment-17148084
]
Hudson commented on YARN-9903:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18389 (See
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148075#comment-17148075
]
Jim Brennan commented on YARN-9903:
---
Thanks [~epayne]! I appreciate the followup on those test
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148071#comment-17148071
]
Eric Payne commented on YARN-9903:
--
[~Jim_Brennan], RE unit test failures for branch-3.2:
I ran all of
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146725#comment-17146725
]
Hadoop QA commented on YARN-9903:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146497#comment-17146497
]
Jim Brennan commented on YARN-9903:
---
[~epayne] I have uploaded a patch for branch-3.2 and I have
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145096#comment-17145096
]
Jim Brennan commented on YARN-9903:
---
Thanks [~epayne]! I will put up a patch for branch-3.2 and check
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145091#comment-17145091
]
Eric Payne commented on YARN-9903:
--
[~Jim_Brennan], Thanks for the work on this JIRA and especially for
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144944#comment-17144944
]
Jim Brennan commented on YARN-9903:
---
Thanks [~pbacsko]!
{quote}I'm not sure if it's really necessary to
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144642#comment-17144642
]
Peter Bacsko commented on YARN-9903:
_"Please let me know if you are OK with this change. Without it,
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144463#comment-17144463
]
Hadoop QA commented on YARN-9903:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144439#comment-17144439
]
Jim Brennan commented on YARN-9903:
---
The two tests I added are basically the same, except that the first
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144432#comment-17144432
]
Eric Payne commented on YARN-9903:
--
Thanks [~Jim_Brennan] for the updated patch. I have a question about
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144290#comment-17144290
]
Jim Brennan commented on YARN-9903:
---
patch 004 fixes the checkstyle issues.
> Support reservations
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144241#comment-17144241
]
Jim Brennan commented on YARN-9903:
---
I will put up a patch 004 to fix the checkstyle issues.
>
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144239#comment-17144239
]
Hadoop QA commented on YARN-9903:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144181#comment-17144181
]
Jim Brennan commented on YARN-9903:
---
[~epayne], I have added unit tests in patch 003. I originally
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126160#comment-17126160
]
Eric Payne commented on YARN-9903:
--
[~Jim_Brennan] it looks like the patch applies cleanly all the way
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125358#comment-17125358
]
Jim Brennan commented on YARN-9903:
---
Thanks [~epayne]! I will work on adding a unit test for this.
>
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125351#comment-17125351
]
Eric Payne commented on YARN-9903:
--
[~Jim_Brennan], The code changes in the latest patch look good. Can
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125136#comment-17125136
]
Eric Payne commented on YARN-9903:
--
As [~Jim_Brennan] pointed out, our usage of node labels is somewhat
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124985#comment-17124985
]
Jim Brennan commented on YARN-9903:
---
We have been running with this patch in branch-2.8 for years on
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124801#comment-17124801
]
Peter Bacsko commented on YARN-9903:
[~Jim_Brennan] thanks for the patch. From your comment, I assume
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124478#comment-17124478
]
Hadoop QA commented on YARN-9903:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124325#comment-17124325
]
Jim Brennan commented on YARN-9903:
---
Uploaded patch 002, which removes an extraneous file.
> Support
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120212#comment-17120212
]
Hadoop QA commented on YARN-9903:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119910#comment-17119910
]
Jim Brennan commented on YARN-9903:
---
[~tarunparimi], [~pbacsko] we have been reviewing internal Verizon
26 matches
Mail list logo
