[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-29 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984802#comment-16984802 ] Adam Antal commented on YARN-9923: -- Resolved last test failure and checkstyle. Will not make final class

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-28 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984516#comment-16984516 ] Hadoop QA commented on YARN-9923: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-28 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984394#comment-16984394 ] Adam Antal commented on YARN-9923: -- The {{NodeHealthChecker}} instance can be null - thus the NPEs. Fixed

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983638#comment-16983638 ] Hadoop QA commented on YARN-9923: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-27 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983403#comment-16983403 ] Adam Antal commented on YARN-9923: -- Uploaded patchset v6. - I was thinking about putting the docker

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982712#comment-16982712 ] Hadoop QA commented on YARN-9923: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-26 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982573#comment-16982573 ] Adam Antal commented on YARN-9923: -- Uploaded patchset v5: - Removed the java-based Docker health checker

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-15 Thread Eric Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975492#comment-16975492 ] Eric Yang commented on YARN-9923: - {quote}Just to be sure, we can enforce the code to have no more than

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-15 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975252#comment-16975252 ] Adam Antal commented on YARN-9923: -- Thanks for your response [~eyang]. Let's stick to the script

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-14 Thread Eric Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974676#comment-16974676 ] Eric Yang commented on YARN-9923: - [~adam.antal] {quote}do you mean that there was no public or

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-14 Thread Adam Antal (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974423#comment-16974423 ] Adam Antal commented on YARN-9923: -- Hi [~eyang], Thanks for sharing these concerns. I can see you point

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-14 Thread Eric Yang (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974392#comment-16974392 ] Eric Yang commented on YARN-9923: - [~adam.antal], thank you for the patch. There are a number of people

[jira] [Commented] (YARN-9923) Introduce HealthReporter interface and implement running Docker daemon checker

2019-11-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973382#comment-16973382 ] Hadoop QA commented on YARN-9923: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||