Yufei Gu created YARN-6307: ------------------------------ Summary: Refactor FairShareComparator#compare Key: YARN-6307 URL: https://issues.apache.org/jira/browse/YARN-6307 Project: Hadoop YARN Issue Type: Bug Components: fairscheduler Reporter: Yufei Gu Assignee: Yufei Gu
The method did three things: check the min share ratio, check weight ratio, break tied by submit time and name. They are mixed with each other which is not easy to read and maintenance, poor style. Additionally, there are potential performance issues, like no need to calculate weight ratio every time. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org