[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-06-06 Thread Chen He (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen He updated YARN-2117:
--

Attachment: YARN-2117-v2.patch

Thank you [~zjshen]. Patch updated.

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
  Labels: newbie
 Attachments: YARN-2117-v2.patch, YARN-2117.patch


 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-06-02 Thread Chen He (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen He updated YARN-2117:
--

Attachment: YARN-2117.patch

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
  Labels: newbie
 Attachments: YARN-2117.patch


 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-06-02 Thread Chen He (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen He updated YARN-2117:
--

Attachment: YARN-2117.patch

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
  Labels: newbie
 Attachments: YARN-2117.patch


 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-06-02 Thread Chen He (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen He updated YARN-2117:
--

Attachment: (was: YARN-2117.patch)

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
  Labels: newbie
 Attachments: YARN-2117.patch


 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-06-01 Thread Chen He (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen He updated YARN-2117:
--

Attachment: YARN-2117.patch

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Priority: Minor
  Labels: newbie
 Attachments: YARN-2117.patch


 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-06-01 Thread Chen He (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen He updated YARN-2117:
--

Attachment: (was: YARN-2117.patch)

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
  Labels: newbie

 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-05-31 Thread Zhijie Shen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-2117:
--

Issue Type: Sub-task  (was: Bug)
Parent: YARN-1935

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Priority: Minor
  Labels: newbie

 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block

2014-05-31 Thread Zhijie Shen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-2117:
--

Labels: newbie  (was: )

 Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() 
 should be enclosed in finally block
 ---

 Key: YARN-2117
 URL: https://issues.apache.org/jira/browse/YARN-2117
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Ted Yu
Priority: Minor
  Labels: newbie

 Here is related code:
 {code}
 Reader reader = new FileReader(signatureSecretFile);
 int c = reader.read();
 while (c  -1) {
   secret.append((char) c);
   c = reader.read();
 }
 reader.close();
 {code}
 If IOException is thrown out of reader.read(), reader would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)