[jira] [Updated] (YARN-3682) Decouple PID-file management from ContainerExecutor
[ https://issues.apache.org/jira/browse/YARN-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated YARN-3682: -- Labels: oct16-hard (was: ) > Decouple PID-file management from ContainerExecutor > --- > > Key: YARN-3682 > URL: https://issues.apache.org/jira/browse/YARN-3682 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Vinod Kumar Vavilapalli >Assignee: Vinod Kumar Vavilapalli > Labels: oct16-hard > Attachments: YARN-3682-20150526.1.txt, YARN-3682-20150526.txt, > YARN-3682-20150529.1.txt > > > The PID-files management currently present in ContainerExecutor really > doesn't belong there. I know the original history of why we added it, that > was about the only right place to put it in at that point of time. > Given the evolution of executors for Windows etc, the ContainerExecutor is > getting more complicated than is necessary. > We should pull the PID-file management into its own entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-3682) Decouple PID-file management from ContainerExecutor
[ https://issues.apache.org/jira/browse/YARN-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated YARN-3682: -- Attachment: YARN-3682-20150529.1.txt Fixing tests, appeasing Jenkins.. Decouple PID-file management from ContainerExecutor --- Key: YARN-3682 URL: https://issues.apache.org/jira/browse/YARN-3682 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Vinod Kumar Vavilapalli Attachments: YARN-3682-20150526.1.txt, YARN-3682-20150526.txt, YARN-3682-20150529.1.txt The PID-files management currently present in ContainerExecutor really doesn't belong there. I know the original history of why we added it, that was about the only right place to put it in at that point of time. Given the evolution of executors for Windows etc, the ContainerExecutor is getting more complicated than is necessary. We should pull the PID-file management into its own entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3682) Decouple PID-file management from ContainerExecutor
[ https://issues.apache.org/jira/browse/YARN-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated YARN-3682: -- Attachment: YARN-3682-20150526.1.txt Updated patch. Apparently, I already forgot how to write code that compiles. Decouple PID-file management from ContainerExecutor --- Key: YARN-3682 URL: https://issues.apache.org/jira/browse/YARN-3682 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Vinod Kumar Vavilapalli Attachments: YARN-3682-20150526.1.txt, YARN-3682-20150526.txt The PID-files management currently present in ContainerExecutor really doesn't belong there. I know the original history of why we added it, that was about the only right place to put it in at that point of time. Given the evolution of executors for Windows etc, the ContainerExecutor is getting more complicated than is necessary. We should pull the PID-file management into its own entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (YARN-3682) Decouple PID-file management from ContainerExecutor
[ https://issues.apache.org/jira/browse/YARN-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kumar Vavilapalli updated YARN-3682: -- Attachment: YARN-3682-20150526.txt Here's a quick patch to stop the pid-file related methods from being part of the interface. - Created a new ContainerPidFilesManager, which is still embedded inside the ContainerExecutor. We can move it out later along with larger refactor efforts. - Straight-forward refactor, so no new tests. Realized that the argument passing in the NodeManager has gotten really bad. Will file a ticket to bring some sanity back. Decouple PID-file management from ContainerExecutor --- Key: YARN-3682 URL: https://issues.apache.org/jira/browse/YARN-3682 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Vinod Kumar Vavilapalli Attachments: YARN-3682-20150526.txt The PID-files management currently present in ContainerExecutor really doesn't belong there. I know the original history of why we added it, that was about the only right place to put it in at that point of time. Given the evolution of executors for Windows etc, the ContainerExecutor is getting more complicated than is necessary. We should pull the PID-file management into its own entity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
