[jira] [Updated] (YARN-6156) AM blacklisting consider node label partition
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated YARN-6156: --- Description: As per the current implementation for AM blacklisting, disabling is based on complete cluster resource. Incase of partitioned cluster though, nodes applicable for AM labels only should be considered as total nodes. Additionally for unmanaged AM as AM blacklisting is not done, it is equivalent to blacklisting being disabled for this app. Hence we do not need to create a SimpleBlacklistManager object. We can create DisableBlacklistManager object instead. {code} BlacklistManager currentAMBlacklist; if (currentAttempt != null) { currentAMBlacklist = currentAttempt.getAMBlacklist(); } else { if (amBlacklistingEnabled) { currentAMBlacklist = new SimpleBlacklistManager( scheduler.getNumClusterNodes(), blacklistDisableThreshold); } else { currentAMBlacklist = new DisabledBlacklistManager(); } } {code} was: As per the current implementation for AM blacklisting disabling is based on completed custer resource. Incase of partitioned cluster, nodes applicable for AM labels only should be considered as total nodes. > AM blacklisting consider node label partition > -- > > Key: YARN-6156 > URL: https://issues.apache.org/jira/browse/YARN-6156 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt > Attachments: YARN-6156.0001.patch, YARN-6156.0002.patch, > YARN-6156.0003.patch, YARN-6156.0004.patch, YARN-6156.0005.patch, > YARN-6156.0006.patch > > > As per the current implementation for AM blacklisting, disabling is based on > complete cluster resource. > Incase of partitioned cluster though, nodes applicable for AM labels only > should be considered as total nodes. > Additionally for unmanaged AM as AM blacklisting is not done, it is > equivalent to blacklisting being disabled for this app. Hence we do not need > to create a SimpleBlacklistManager object. > We can create DisableBlacklistManager object instead. > {code} > BlacklistManager currentAMBlacklist; > if (currentAttempt != null) { > currentAMBlacklist = currentAttempt.getAMBlacklist(); > } else { > if (amBlacklistingEnabled) { > currentAMBlacklist = new SimpleBlacklistManager( > scheduler.getNumClusterNodes(), blacklistDisableThreshold); > } else { > currentAMBlacklist = new DisabledBlacklistManager(); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6156) AM blacklisting consider node label partition
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bibin A Chundatt updated YARN-6156: --- Attachment: YARN-6156.0006.patch [~sunilg]/[~varun_saxena] Minor change in patch for checking unmanager AM.For unmanaged AM we can always set to Disable blacklist manager. > AM blacklisting consider node label partition > -- > > Key: YARN-6156 > URL: https://issues.apache.org/jira/browse/YARN-6156 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt > Attachments: YARN-6156.0001.patch, YARN-6156.0002.patch, > YARN-6156.0003.patch, YARN-6156.0004.patch, YARN-6156.0005.patch, > YARN-6156.0006.patch > > > As per the current implementation for AM blacklisting disabling is based on > completed custer resource. > Incase of partitioned cluster, nodes applicable for AM labels only should be > considered as total nodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6156) AM blacklisting consider node label partition
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bibin A Chundatt updated YARN-6156: --- Attachment: YARN-6156.0005.patch Thank you [~varun_saxena] and [~sunilg] for review . Attaching patch after checkstyle fix > AM blacklisting consider node label partition > -- > > Key: YARN-6156 > URL: https://issues.apache.org/jira/browse/YARN-6156 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt > Attachments: YARN-6156.0001.patch, YARN-6156.0002.patch, > YARN-6156.0003.patch, YARN-6156.0004.patch, YARN-6156.0005.patch > > > As per the current implementation for AM blacklisting disabling is based on > completed custer resource. > Incase of partitioned cluster, nodes applicable for AM labels only should be > considered as total nodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6156) AM blacklisting consider node label partition
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bibin A Chundatt updated YARN-6156: --- Attachment: YARN-6156.0004.patch > AM blacklisting consider node label partition > -- > > Key: YARN-6156 > URL: https://issues.apache.org/jira/browse/YARN-6156 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt > Attachments: YARN-6156.0001.patch, YARN-6156.0002.patch, > YARN-6156.0003.patch, YARN-6156.0004.patch > > > As per the current implementation for AM blacklisting disabling is based on > completed custer resource. > Incase of partitioned cluster, nodes applicable for AM labels only should be > considered as total nodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-6156) AM blacklisting consider node label partition
[ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bibin A Chundatt updated YARN-6156: --- Summary: AM blacklisting consider node label partition (was: AM blacklisting consider node label partirion) > AM blacklisting consider node label partition > -- > > Key: YARN-6156 > URL: https://issues.apache.org/jira/browse/YARN-6156 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Bibin A Chundatt >Assignee: Bibin A Chundatt > Attachments: YARN-6156.0001.patch, YARN-6156.0002.patch, > YARN-6156.0003.patch > > > As per the current implementation for AM blacklisting disabling is based on > completed custer resource. > Incase of partitioned cluster, nodes applicable for AM labels only should be > considered as total nodes. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org