[jira] [Updated] (YARN-7586) Application Placement should be done before ACL checks in ResourceManager
[ https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated YARN-7586: --- Attachment: YARN-7586.4.patch Thanks [~sunilg] Attached patch with comments addressed. RMActiveServiceContext ensures that PlacementManager is no null since is it created during its construction. This is just a saftey check to make sure its set. Have added an additional check to log the error and throw an exception if the specified queue is also invalid > Application Placement should be done before ACL checks in ResourceManager > - > > Key: YARN-7586 > URL: https://issues.apache.org/jira/browse/YARN-7586 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Blocker > Attachments: YARN-7586.1.patch, YARN-7586.2.patch, YARN-7586.3.patch, > YARN-7586.4.patch > > > YARN-7419 moved Application placement from RMAppManager to RMAppImpl which > causes issues since ApplicationSubmissionContext still has the original queue > specified by the user and not the mapped queue . This causes issues while > doing ACL checks in RMAppManager -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7586) Application Placement should be done before ACL checks in ResourceManager
[ https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated YARN-7586: --- Attachment: YARN-7586.3.patch Thanks [~sunilg] Attached patch with comments addressed > Application Placement should be done before ACL checks in ResourceManager > - > > Key: YARN-7586 > URL: https://issues.apache.org/jira/browse/YARN-7586 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Blocker > Attachments: YARN-7586.1.patch, YARN-7586.2.patch, YARN-7586.3.patch > > > YARN-7419 moved Application placement from RMAppManager to RMAppImpl which > causes issues since ApplicationSubmissionContext still has the original queue > specified by the user and not the mapped queue . This causes issues while > doing ACL checks in RMAppManager -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7586) Application Placement should be done before ACL checks in ResourceManager
[ https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated YARN-7586: --- Attachment: YARN-7586.2.patch Added UT. Thanks [~wangda]. I did not understand where the logic for application timeout validation needs to be moved ? This was in original code before YARN-7419 changes > Application Placement should be done before ACL checks in ResourceManager > - > > Key: YARN-7586 > URL: https://issues.apache.org/jira/browse/YARN-7586 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Blocker > Attachments: YARN-7586.1.patch, YARN-7586.2.patch > > > YARN-7419 moved Application placement from RMAppManager to RMAppImpl which > causes issues since ApplicationSubmissionContext still has the original queue > specified by the user and not the mapped queue . This causes issues while > doing ACL checks in RMAppManager -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7586) Application Placement should be done before ACL checks in ResourceManager
[ https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated YARN-7586: - Target Version/s: 3.1.0 > Application Placement should be done before ACL checks in ResourceManager > - > > Key: YARN-7586 > URL: https://issues.apache.org/jira/browse/YARN-7586 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Blocker > Attachments: YARN-7586.1.patch > > > YARN-7419 moved Application placement from RMAppManager to RMAppImpl which > causes issues since ApplicationSubmissionContext still has the original queue > specified by the user and not the mapped queue . This causes issues while > doing ACL checks in RMAppManager -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7586) Application Placement should be done before ACL checks in ResourceManager
[ https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated YARN-7586: --- Attachment: YARN-7586.1.patch > Application Placement should be done before ACL checks in ResourceManager > - > > Key: YARN-7586 > URL: https://issues.apache.org/jira/browse/YARN-7586 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Blocker > Attachments: YARN-7586.1.patch > > > YARN-7419 moved Application placement from RMAppManager to RMAppImpl which > causes issues since ApplicationSubmissionContext still has the original queue > specified by the user and not the mapped queue . This causes issues while > doing ACL checks in RMAppManager -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7586) Application Placement should be done before ACL checks in ResourceManager
[ https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated YARN-7586: --- Description: YARN-7419 moved Application placement from RMAppManager to RMAppImpl which causes issues since ApplicationSubmissionContext still has the original queue specified by the user and not the mapped queue . This causes issues while doing ACL checks in RMAppManager (was: YARN-7473 moved Application placement from RMAppManager to RMAppImpl which causes issues since ApplicationSubmissionContext still has the original queue specified by the user and not the mapped queue . This causes issues while doing ACL checks in RMAppManager) > Application Placement should be done before ACL checks in ResourceManager > - > > Key: YARN-7586 > URL: https://issues.apache.org/jira/browse/YARN-7586 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Blocker > > YARN-7419 moved Application placement from RMAppManager to RMAppImpl which > causes issues since ApplicationSubmissionContext still has the original queue > specified by the user and not the mapped queue . This causes issues while > doing ACL checks in RMAppManager -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Updated] (YARN-7586) Application Placement should be done before ACL checks in ResourceManager
[ https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated YARN-7586: --- Priority: Blocker (was: Major) > Application Placement should be done before ACL checks in ResourceManager > - > > Key: YARN-7586 > URL: https://issues.apache.org/jira/browse/YARN-7586 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Blocker > > YARN-7473 moved Application placement from RMAppManager to RMAppImpl which > causes issues since ApplicationSubmissionContext still has the original queue > specified by the user and not the mapped queue . This causes issues while > doing ACL checks in RMAppManager -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org