[ https://issues.apache.org/jira/browse/YARN-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091364#comment-14091364 ]
Zhijie Shen edited comment on YARN-2302 at 8/8/14 10:12 PM: ------------------------------------------------------------ [~djp], thanks for your review. The general response to your comments on ApplicationHistoryServer is that protected vars/methods are the legacy things. Anyway before it grows worse, I did some more refactoring for this class in the new patch. In addition, I address the Log level issue in the new patch as well. was (Author: zjshen): [~djp], thanks for your review. The general response to your comments on ApplicationHistoryServer is that protected vars/methods are the legacy things. Anyway before it grows worth, I did some more refactoring for this class in the new patch. In addition, I address the Log level issue in the new patch as well. > Refactor TimelineWebServices > ---------------------------- > > Key: YARN-2302 > URL: https://issues.apache.org/jira/browse/YARN-2302 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Zhijie Shen > Assignee: Zhijie Shen > Attachments: YARN-2302.1.patch, YARN-2302.2.patch > > > Now TimelineWebServices contains non-trivial logic to process the HTTP > requests, manipulate the data, check the access, and interact with the > timeline store. > I propose the move the data-oriented logic to a middle layer (so called > TimelineDataManager), and TimelineWebServices only processes the requests, > and call TimelineDataManager to complete the remaining tasks. > By doing this, we make the generic history module reuse TimelineDataManager > internally (YARN-2033), invoking the putting/getting methods directly. > Otherwise, we have to send the HTTP requests to TimelineWebServices to query > the generic history data, which is not an efficient way. -- This message was sent by Atlassian JIRA (v6.2#6252)