[jira] [Comment Edited] (YARN-5271) ATS client doesn't work with Jersey 2 on the classpath

[Weiwei Yang (JIRA)]

[ 
https://issues.apache.org/jira/browse/YARN-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1584#comment-1584
 ] 

Weiwei Yang edited comment on YARN-5271 at 11/15/16 10:03 AM:
--

Hi [~jojochuang]

Thanks for looking at this one. You are absolutely right I should use spyClient 
instead of the client, I have fixed that in v2 patch (one for trunk and one for 
branch-2.8). I tested if I remove the code fix, the UT will fail like following,

{code}
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.558 sec <<< 
FAILURE! - in org.apache.hadoop.yarn.client.api.impl.TestYarnClient
testTimelineClientInitFailure(org.apache.hadoop.yarn.client.api.impl.TestYarnClient)
  Time elapsed: 0.465 sec  <<< ERROR!
java.lang.NoClassDefFoundError: Mock a failure when init timeline instance
at 
org.apache.hadoop.yarn.client.api.impl.TestYarnClient.testTimelineClientInitFailure(TestYarnClient.java:170)
{code} 

 Also I have revised the warning message according to your comment. Thank you!


was (Author: cheersyang):
Hi [~jojochuang]

Thanks for looking at this one. You are absolutely right I should use spyClient 
instead of the client, I have fixed that in v2 patch. I tested if I remove the 
code fix, the UT will fail like following,

{code}
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.558 sec <<< 
FAILURE! - in org.apache.hadoop.yarn.client.api.impl.TestYarnClient
testTimelineClientInitFailure(org.apache.hadoop.yarn.client.api.impl.TestYarnClient)
  Time elapsed: 0.465 sec  <<< ERROR!
java.lang.NoClassDefFoundError: Mock a failure when init timeline instance
at 
org.apache.hadoop.yarn.client.api.impl.TestYarnClient.testTimelineClientInitFailure(TestYarnClient.java:170)
{code} 

 Also I have revised the warning message according to your comment. Thank you!

> ATS client doesn't work with Jersey 2 on the classpath
> --
>
> Key: YARN-5271
> URL: https://issues.apache.org/jira/browse/YARN-5271
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: client, timelineserver
>Affects Versions: 2.7.2
>Reporter: Steve Loughran
>Assignee: Weiwei Yang
>  Labels: oct16-medium
> Attachments: YARN-5271-branch-2.8.01.patch, YARN-5271.01.patch, 
> YARN-5271.02.patch, YARN-5271.branch-2.01.patch
>
>
> see SPARK-15343 : once Jersey 2 is on the CP, you can't instantiate a 
> timeline client, *even if the server is an ATS1.5 server and publishing is 
> via the FS*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (YARN-5271) ATS client doesn't work with Jersey 2 on the classpath

[Jo Desmet (JIRA)]

[ 
https://issues.apache.org/jira/browse/YARN-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576247#comment-15576247
 ] 

Jo Desmet edited comment on YARN-5271 at 10/14/16 7:23 PM:
---

Note that such tight coupling should not be required, not so that we have that 
library dependency between spark and Yarn. The idea of Jersey is exactly to 
avoid this type of tight coupling between two application frameworks. I think 
it is still a huge drawback of not having the History Server up. I think it is 
1./ Spark's job to have enough decoupling in place; 2./ Yarn to evolve fast 
enough, being able to use latest libraries and benefit from added features and 
improvements. That being said, most likely this fix is probably a good first 
step.


was (Author: jo_des...@yahoo.com):
Note that such tight coupling should not be required, not so that we have that 
library dependency between spark and Yarn. The idea of Jersey is exactly to 
avoid this type of tight coupling between two application frameworks. I think 
it is still a huge drawback of not having the History Server up. I think it is 
1./ Spark's job to have enough decoupling in place; 2./ Yarn to evolve fast 
enough, being able to use latest libraries and benefit from added features and 
improvements.

> ATS client doesn't work with Jersey 2 on the classpath
> --
>
> Key: YARN-5271
> URL: https://issues.apache.org/jira/browse/YARN-5271
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: client, timelineserver
>Affects Versions: 2.7.2
>Reporter: Steve Loughran
>Assignee: Weiwei Yang
> Attachments: YARN-5271.01.patch, YARN-5271.branch-2.01.patch
>
>
> see SPARK-15343 : once Jersey 2 is on the CP, you can't instantiate a 
> timeline client, *even if the server is an ATS1.5 server and publishing is 
> via the FS*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org