[ 
https://issues.apache.org/jira/browse/YARN-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397910#comment-16397910
 ] 

Suma Shivaprasad edited comment on YARN-7574 at 3/14/18 12:42 AM:
------------------------------------------------------------------

[~sunilg] Thanks for the review. Uploading patch after addressing comments for

{{1. map of queueName-> partition->{leaf queue's state}} seems not clean to me. 
(GuaranteedOrZeroCapacityOverTimePolicy). We should ideally derive queues from 
partition. 

 - Now maintaining a map of partition-> queueName->\{leaf queue's state} 

 

2. As we discussed - 
AutoCreatedQueueManagementPolicy.computeQueueManagementChnages does not update 
scheduler state or LeafQueueState and suggest a list of queue entitlement 
changes per partition which is later committed by scheduler after validation 
through commitQueueManagmentChanges

3. Also added validation to check if the node labels that are configured are 
also configued on ManagedParentQueue in 

GuaranteedOrZeroCapacityOverTimePolicy.initializeLeafQueueTemplate

 

 


was (Author: suma.shivaprasad):
[~sunilg] Thanks for the review. Uploading patch after addressing comments for

{{1. map of queueName-> partition->{leaf queue's state}} seems not clean to me. 
(GuaranteedOrZeroCapacityOverTimePolicy). We should ideally derive queues from 
partition. 

 - Now maintaining a map of partition-> queueName->\{leaf queue's state} 

 

2. As we discussed - 
AutoCreatedQueueManagementPolicy.computeQueueManagementChnages does not update 
scheduler state or LeafQueueState and suggest a list of queue entitlement 
changes per partition which is later committed by scheduler after validation 
through commitQueueManagmentChanges

 

 

> Add support for Node Labels on Auto Created Leaf Queue Template
> ---------------------------------------------------------------
>
>                 Key: YARN-7574
>                 URL: https://issues.apache.org/jira/browse/YARN-7574
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Suma Shivaprasad
>            Assignee: Suma Shivaprasad
>            Priority: Major
>         Attachments: YARN-7574.1.patch, YARN-7574.2.patch, YARN-7574.3.patch, 
> YARN-7574.4.patch
>
>
> YARN-7473 adds support for auto created leaf queues to inherit node labels 
> capacities from parent queues. Howebver there is no support for leaf queue 
> template to allow different configured capacities for different node labels. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to