[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756582#comment-13756582 ] Hudson commented on YARN-1077: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1511 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1511/]) YARN-1077. Fixed TestContainerLaunch test failure on Windows. Contributed by Chuan Liu. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519333) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainersLauncher.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainerLaunch.java TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Fix For: 2.1.1-beta Attachments: YARN-1077.2.patch, YARN-1077.3.patch, YARN-1077.4.patch, YARN-1077.5.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ... testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 2744 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756637#comment-13756637 ] Hudson commented on YARN-1077: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1538 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1538/]) YARN-1077. Fixed TestContainerLaunch test failure on Windows. Contributed by Chuan Liu. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519333) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainersLauncher.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainerLaunch.java TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Fix For: 2.1.1-beta Attachments: YARN-1077.2.patch, YARN-1077.3.patch, YARN-1077.4.patch, YARN-1077.5.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ... testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 2744 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756013#comment-13756013 ] Hudson commented on YARN-1077: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #320 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/320/]) YARN-1077. Fixed TestContainerLaunch test failure on Windows. Contributed by Chuan Liu. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519333) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainersLauncher.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainerLaunch.java TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Fix For: 2.1.1-beta Attachments: YARN-1077.2.patch, YARN-1077.3.patch, YARN-1077.4.patch, YARN-1077.5.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ... testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 2744 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755879#comment-13755879 ] Vinod Kumar Vavilapalli commented on YARN-1077: --- While committing the original patch that added the command not found message (YARN-814), I kind of felt that it'd break Windows. But alas, no pre-commit Windows builds. Assuming things are fine on Windows, +1 for the patch. Checking this in. TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Attachments: YARN-1077.2.patch, YARN-1077.3.patch, YARN-1077.4.patch, YARN-1077.5.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ... testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 2744 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testDelayedKill(TestContainerLaunch.java:601) ... {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752950#comment-13752950 ] Chuan Liu commented on YARN-1077: - In the new patch, I removed the following code because writer is writing to shellFile but later the file outputsteam opens the file without append mode. So the code is simply dead code. {code:java} shellFile = Shell.appendScriptExtension(tmpDir, hello); - String timeoutCommand = Shell.WINDOWS ? @echo \hello\ : -echo \hello\; - PrintWriter writer = new PrintWriter(new FileOutputStream(shellFile)); - FileUtil.setExecutable(shellFile, true); - writer.println(timeoutCommand); - writer.close(); MapPath, ListString resources = new HashMapPath, ListString(); FileOutputStream fos = new FileOutputStream(shellFile); {code} TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Attachments: YARN-1077.2.patch, YARN-1077.3.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ... testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 2744 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testDelayedKill(TestContainerLaunch.java:601) ... {noformat} -- This message is automatically generated by JIRA. If you think it was sent
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752993#comment-13752993 ] Hadoop QA commented on YARN-1077: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12600489/YARN-1077.5.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1786//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1786//console This message is automatically generated. TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Attachments: YARN-1077.2.patch, YARN-1077.3.patch, YARN-1077.4.patch, YARN-1077.5.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ...
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752129#comment-13752129 ] Vinod Kumar Vavilapalli commented on YARN-1077: --- Also, instead of the following {code} - ExitCode.TERMINATED.getExitCode(), + Shell.WINDOWS ? ExitCode.FORCE_KILLED.getExitCode() : +ExitCode.TERMINATED.getExitCode(), {code} Should we just change ExitCode.TERMINATED.getExitCode() to return the correct code depending on the OS? That way all future callers can simply work. I've seen that pattern in other patches too, so saying. TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Attachments: YARN-1077.2.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ... testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 2744 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testDelayedKill(TestContainerLaunch.java:601) ... {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13744024#comment-13744024 ] Hadoop QA commented on YARN-1077: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598710/YARN-1077.2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1739//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1739//console This message is automatically generated. TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Attachments: YARN-1077.2.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at
[jira] [Commented] (YARN-1077) TestContainerLaunch fails on Windows
[ https://issues.apache.org/jira/browse/YARN-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13744049#comment-13744049 ] Chuan Liu commented on YARN-1077: - bq. -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: I will take a look at the failure. TestContainerLaunch fails on Windows Key: YARN-1077 URL: https://issues.apache.org/jira/browse/YARN-1077 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.3.0 Reporter: Chuan Liu Assignee: Chuan Liu Priority: Minor Attachments: YARN-1077.2.patch, YARN-1077.patch Several cases in this unit tests fail on Windows. (Append error log at the end.) testInvalidEnvSyntaxDiagnostics fails because the difference between cmd and bash script error handling. If some command fails in the cmd script, cmd will continue execute the the rest of the script command. Error handling needs to be explicitly carried out in the script file. The error code of the last command will be returned as the error code of the whole script. In this test, some error happened in the middle of the cmd script, the test expect an exception and non-zero error code. In the cmd script, the intermediate errors are ignored. The last command call succeeded and there is no exception. testContainerLaunchStdoutAndStderrDiagnostics fails due to wrong cmd commands used by the test. testContainerEnvVariables and testDelayedKill fail due to a regression from YARN-906. {noformat} --- Test set: org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch --- Tests run: 7, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 11.526 sec FAILURE! testInvalidEnvSyntaxDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 583 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testInvalidEnvSyntaxDiagnostics(TestContainerLaunch.java:269) ... testContainerLaunchStdoutAndStderrDiagnostics(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 561 sec FAILURE! junit.framework.AssertionFailedError: Should catch exception at junit.framework.Assert.fail(Assert.java:50) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerLaunchStdoutAndStderrDiagnostics(TestContainerLaunch.java:314) ... testContainerEnvVariables(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 4136 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testContainerEnvVariables(TestContainerLaunch.java:500) ... testDelayedKill(org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch) Time elapsed: 2744 sec FAILURE! junit.framework.AssertionFailedError: expected:137 but was:143 at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.failNotEquals(Assert.java:287) at junit.framework.Assert.assertEquals(Assert.java:67) at junit.framework.Assert.assertEquals(Assert.java:199) at junit.framework.Assert.assertEquals(Assert.java:205) at org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch.testDelayedKill(TestContainerLaunch.java:601) ... {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira