[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076832#comment-18076832
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4335231289

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  14m 30s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  markdownlint  |   0m  1s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m  5s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  44m  4s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 47s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.11+10-LTS  |
   | +1 :green_heart: |  compile  |   7m 44s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.19+10-LTS  |
   | +1 :green_heart: |  checkstyle  |   3m 30s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   8m 46s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m 24s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.11+10-LTS  |
   | +1 :green_heart: |  javadoc  |   8m 22s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.19+10-LTS  |
   | +0 :ok: |  spotbugs  |   1m 55s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  33m 10s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m 55s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 51s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 25s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.11+10-LTS  |
   | +1 :green_heart: |  cc  |   6m 25s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 25s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 25s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 37s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.19+10-LTS  |
   | +1 :green_heart: |  cc  |   7m 37s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 37s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 37s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   3m  7s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   7m 41s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   7m 20s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.11+10-LTS  |
   | +1 :green_heart: |  javadoc  |   7m  5s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.19+10-LTS  |
   | +0 :ok: |  spotbugs  |   1m 35s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  31m 46s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 18s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 54s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  28m 19s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 40s |  |  hadoop-yarn-site in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   2m  6s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 285m 36s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/28/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang markdownlint |
   | uname | Linux b4e545ed7332 5.15.0-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076761#comment-18076761
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4333274110

   14 NodeManager test failures. 11 tests coming from 
`org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor` 
and 3 tests coming from 
`org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer.testExecutablePathWhenFileIsEmpty`.
 It is unlikely because of this PR since it is only add two new endpoints and 
did not modify any existing functionalities.
   
   ```
   [INFO] 
   [INFO] Results:
   [INFO] 
   [ERROR] Failures: 
   [ERROR] 
org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testBatchFinishApplicationMaster
   [ERROR]   Run 1: 
TestFederationInterceptor.testBatchFinishApplicationMaster:1074->lambda$testBatchFinishApplicationMaster$0:1097->getContainersAndAssert:253
 expected: <6> but was: <0>
   [ERROR]   Run 2: 
TestFederationInterceptor.testBatchFinishApplicationMaster:1074->lambda$testBatchFinishApplicationMaster$0:1097->getContainersAndAssert:253
 expected: <6> but was: <0>
   [ERROR]   Run 3: 
TestFederationInterceptor.testBatchFinishApplicationMaster:1074->lambda$testBatchFinishApplicationMaster$0:1097->getContainersAndAssert:253
 expected: <6> but was: <0>
   [INFO] 
   [ERROR] 
org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testLaunchUAMAndRegisterApplicationMasterRetry
   [ERROR]   Run 1: 
TestFederationInterceptor.testLaunchUAMAndRegisterApplicationMasterRetry:1420->lambda$testLaunchUAMAndRegisterApplicationMasterRetry$0:1439->getContainersAndAssert:253
 expected: <3> but was: <0>
   [ERROR]   Run 2: 
TestFederationInterceptor.testLaunchUAMAndRegisterApplicationMasterRetry:1420->lambda$testLaunchUAMAndRegisterApplicationMasterRetry$0:1439->getContainersAndAssert:253
 expected: <3> but was: <0>
   [ERROR]   Run 3: 
TestFederationInterceptor.testLaunchUAMAndRegisterApplicationMasterRetry:1420->lambda$testLaunchUAMAndRegisterApplicationMasterRetry$0:1439->getContainersAndAssert:253
 expected: <3> but was: <0>
   [INFO] 
   [ERROR] 
org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testMultipleSubClusters
   [ERROR]   Run 1: 
TestFederationInterceptor.testMultipleSubClusters:324->lambda$testMultipleSubClusters$0:345->getContainersAndAssert:253
 expected: <6> but was: <0>
   [ERROR]   Run 2: 
TestFederationInterceptor.testMultipleSubClusters:324->lambda$testMultipleSubClusters$0:345->getContainersAndAssert:253
 expected: <6> but was: <0>
   [ERROR]   Run 3: 
TestFederationInterceptor.testMultipleSubClusters:324->lambda$testMultipleSubClusters$0:345->getContainersAndAssert:253
 expected: <6> but was: <0>
   [INFO] 
   [ERROR] 
org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testRecoverBadSCWithAMRMProxyHA
   [ERROR]   Run 1: 
TestFederationInterceptor.testRecoverBadSCWithAMRMProxyHA:529->testRecoverWithBadSubCluster:1263->lambda$testRecoverWithBadSubCluster$0:1269->registerApplicationAndAssignContainers:1333->getContainersAndAssert:253
 expected: <9> but was: <3>
   [ERROR]   Run 2: 
TestFederationInterceptor.testRecoverBadSCWithAMRMProxyHA:529->testRecoverWithBadSubCluster:1263->lambda$testRecoverWithBadSubCluster$0:1269->registerApplicationAndAssignContainers:1333->getContainersAndAssert:253
 expected: <9> but was: <3>
   [ERROR]   Run 3: 
TestFederationInterceptor.testRecoverBadSCWithAMRMProxyHA:529->testRecoverWithBadSubCluster:1263->lambda$testRecoverWithBadSubCluster$0:1269->registerApplicationAndAssignContainers:1333->getContainersAndAssert:253
 expected: <9> but was: <3>
   [INFO] 
   [ERROR] 
org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testRecoverBadSCWithoutAMRMProxyHA
   [ERROR]   Run 1: 
TestFederationInterceptor.testRecoverBadSCWithoutAMRMProxyHA:534->testRecoverWithBadSubCluster:1263->lambda$testRecoverWithBadSubCluster$0:1269->registerApplicationAndAssignContainers:1333->getContainersAndAssert:253
 expected: <9> but was: <3>
   [ERROR]   Run 2: 
TestFederationInterceptor.testRecoverBadSCWithoutAMRMProxyHA:534->testRecoverWithBadSubCluster:1263->lambda$testRecoverWithBadSubCluster$0:1269->registerApplicationAndAssignContainers:1333->getContainersAndAssert:253
 expected: <9> but was: <3>
   [ERROR]   Run 3: 
TestFederationInterceptor.testRecoverBadSCWithoutAMRMProxyHA:534->testRecoverWithBadSubCluster:1263->lambda$testRecoverWithBadSubCluster$0:1269->registerApplicationAndAssignContainers:1333->getContainersAndAssert:253
 expected: <9> but was: <3>
   [INFO] 
   [ERROR] 
org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor.testRecoverWithAMRMProxyHA
   [ERROR]   Run 1: 
TestFederat

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076690#comment-18076690
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4330790339

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 26s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 53s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 54s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 19s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  5s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 58s |  |  trunk passed  |
   | +0 :ok: |  spotbugs  |   0m 22s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  19m 45s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  20m  6s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 50s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 49s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   3m 49s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 49s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 49s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/27/artifact/out/blanks-tabs.txt)
 |  The patch 6 line(s) with tabs.  |
   | -0 :warning: |  checkstyle  |   1m 22s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/27/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 164 unchanged 
- 0 fixed = 170 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m  2s |  |  the patch passed  |
   | +0 :ok: |  spotbugs  |   0m 21s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  21m 44s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 43s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 24s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  22m 46s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/27/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 20s |  |  hadoop-yarn-site in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 33s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 130m  7s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   |   | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/27/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsi

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076674#comment-18076674
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4330087337

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 24s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 53s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 42s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m 27s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   4m 32s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   2m 13s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   5m 51s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   5m 37s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 38s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +0 :ok: |  spotbugs  |   1m 19s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  18m 38s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  19m  5s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 30s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   3m 21s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 21s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m  7s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   4m  7s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   4m  7s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m  7s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/27/artifact/out/blanks-tabs.txt)
 |  The patch 6 line(s) with tabs.  |
   | -0 :warning: |  checkstyle  |   1m 59s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/27/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 164 unchanged 
- 0 fixed = 170 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   5m  1s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   4m 49s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   4m 51s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +0 :ok: |  spotbugs  |   1m  4s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  17m 43s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 33s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 10s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  24m 13s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m  6s |  |  hadoop-yarn-site in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   1m 22s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 175m 30s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076642#comment-18076642
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4328963272

   Hello @brumi1024!
   When you get time, may I ask you to review this PR?




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075859#comment-18075859
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4310318982

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 36s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  37m 13s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 41s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   6m 30s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   2m 31s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m 37s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   4m 11s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   4m 11s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +0 :ok: |  spotbugs  |   0m 47s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  28m 48s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 20s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 49s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 42s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 20s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 20s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/blanks-tabs.txt)
 |  The patch 6 line(s) with tabs.  |
   | -0 :warning: |  checkstyle  |   2m 19s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 165 unchanged 
- 0 fixed = 169 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   4m  4s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 29s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m 39s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  29m 25s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 22s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 55s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  26m 47s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 42s |  |  hadoop-yarn-site in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   1m  6s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 212m 16s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Dock

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075851#comment-18075851
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4309970296

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   8m 10s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  27m 38s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 47s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 23s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  9s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  1s |  |  trunk passed  |
   | +0 :ok: |  spotbugs  |   0m 22s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | -1 :x: |  shadedclient  |   8m 43s |  |  branch has errors when building 
and testing our client artifacts.  |
   | -0 :warning: |  patch  |   9m  4s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m  5s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m  5s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   4m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m  5s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/26/artifact/out/blanks-tabs.txt)
 |  The patch 6 line(s) with tabs.  |
   | -0 :warning: |  checkstyle  |   1m 25s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/26/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 164 unchanged 
- 0 fixed = 168 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m  7s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 57s |  |  the patch passed  |
   | +0 :ok: |  spotbugs  |   0m 19s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | -1 :x: |  shadedclient  |   4m 13s |  |  patch has errors when building 
and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  |   0m 37s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/26/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in the patch failed.  |
   | -1 :x: |  unit  |   1m  9s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/26/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt)
 |  hadoop-yarn-common in the patch failed.  |
   | -1 :x: |  unit  |   0m 30s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/26/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | +1 :green_heart: |  unit  |   0m 33s |  |  hadoop-yarn-site in the patch 
passed.  |
   | +0 :ok: |  asflicense  |   0m 22s |  |  ASF License check generated no 
output?  |
   |  |   |  86m  1s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.yarn.api.records.TestResource |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/j

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075844#comment-18075844
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4309621464

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   8m 22s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m  7s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m 56s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   5m  4s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   5m  0s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   2m 25s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   5m 47s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   5m 41s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 37s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +0 :ok: |  spotbugs  |   1m 12s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  22m 36s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  23m  2s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 19s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 43s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   3m 43s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 43s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 43s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 18s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   4m 18s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   4m 18s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 18s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/26/artifact/out/blanks-tabs.txt)
 |  The patch 6 line(s) with tabs.  |
   | -0 :warning: |  checkstyle  |   1m 55s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/26/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 164 unchanged 
- 0 fixed = 168 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   4m 50s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   4m 31s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   4m 37s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +0 :ok: |  spotbugs  |   0m 57s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  23m 26s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 30s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 51s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  23m 12s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 52s |  |  hadoop-yarn-site in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   1m  7s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 190m  6s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075832#comment-18075832
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4309009287

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  14m 20s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +0 :ok: |  markdownlint  |   0m  1s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  42m 10s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 10s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 29s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m  4s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 53s |  |  trunk passed  |
   | +0 :ok: |  spotbugs  |   0m 45s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  32m 29s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m  4s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 13s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   6m 13s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 13s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/blanks-tabs.txt)
 |  The patch 6 line(s) with tabs.  |
   | -0 :warning: |  checkstyle  |   2m 26s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 51s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 28s |  |  the patch passed  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  31m 33s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 23s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m  6s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  27m  0s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 38s |  |  hadoop-yarn-site in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   1m  8s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 216m  6s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   |   | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsi

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075811#comment-18075811
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4307405580

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  15m 24s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  markdownlint  |   0m  0s |  |  markdownlint was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 12s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  46m 13s |  |  trunk passed  |
   | -1 :x: |  compile  |   5m 33s | 
[/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in trunk failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  compile  |   5m 36s | 
[/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt)
 |  hadoop-yarn in trunk failed with JDK Red Hat, Inc.-17.0.18+8-LTS.  |
   | +1 :green_heart: |  checkstyle  |   3m 23s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   8m 27s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   7m 27s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   7m 45s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +0 :ok: |  spotbugs  |   1m 43s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  35m 49s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  36m 33s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 48s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 55s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 45s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   6m 45s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 45s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 45s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 50s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   7m 50s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 50s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 50s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/blanks-tabs.txt)
 |  The patch 6 line(s) with tabs.  |
   | -0 :warning: |  checkstyle  |   3m 11s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/25/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   6m 56s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   6m 33s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   6m 32s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +0 :ok: |  spotbugs  |   1m 27s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  32m 50s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 13s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075715#comment-18075715
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4305497867

   > Seems good!
   > 
   > May i ask one more improvement? The new 2 ep should added to the NM api doc
   
   Thanks! I have added the two new endpoints in the NM api doc 




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18075699#comment-18075699
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4304991132

   Seems good!
   
   May i ask one more improvement? The new 2 ep should added to the NM api doc.




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074425#comment-18074425
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4271239248

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 36s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 33s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 55s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 29s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   6m 28s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   2m 30s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 38s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 24s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m 23s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   6m 57s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  29m 28s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  30m  1s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 29s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 47s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 23s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   6m 23s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 23s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 15s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/24/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 24s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m  5s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m  3s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   7m 12s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  29m 22s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 21s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 54s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  26m 52s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  7s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 202m 26s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/24/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux 5b5de2ba68f3 5.15.0-173-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074328#comment-18074328
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4270079373

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  13m 10s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 21s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 24s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 26s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 42s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 31s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   6m 52s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  29m  5s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 39s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 33s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 33s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 19s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/24/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 12s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   7m 19s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  29m 25s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 23s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 56s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  26m 56s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/24/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  7s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 193m 42s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   |   | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/24/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux f038a0424df7 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 
13:29:34 UTC 2026 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 391abdd15887ff581eab37f8bb371f0a8bc84aa6 |
   | Default Java | Debian-25.0.2+10-Debian-1deb13u2 |
   |  Tes

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074256#comment-18074256
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4268890225

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  15m  5s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 15s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  43m  3s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 46s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   7m 45s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   3m 34s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   6m 30s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m 41s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   6m 28s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |  10m 14s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  32m 35s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m 19s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 51s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 25s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 20s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 31s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   7m 31s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 31s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   3m 15s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/24/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   6m  3s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   5m 43s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 37s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   9m 49s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  32m  9s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 18s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 51s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  28m 25s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  5s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 267m 45s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/24/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux d93c847ec97a 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070976#comment-18070976
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4186178748

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 33s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 43s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 51s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 17s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   6m 25s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   2m 25s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 42s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 24s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m 22s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   6m 59s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  29m  7s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 39s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 47s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 47s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 20s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 21s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/23/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 11s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m  7s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   7m 15s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  29m 22s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 23s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 55s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  26m 58s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  6s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 202m 12s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/23/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux f1504c05fe0c 5.15.0-173-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070944#comment-18070944
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4185728937

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  13m 12s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 34s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 30s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 27s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 48s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 33s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   7m  4s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  30m 23s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  30m 59s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 36s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 21s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/23/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 12s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   7m 17s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  29m 30s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 18s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 58s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  26m 51s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/23/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  8s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 195m 37s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   |   | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/23/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux 1dbaec9e89fb 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 
13:29:34 UTC 2026 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 26110e4979c449d5dff52ebb6e43ffe274a017d4 |
   | Default Java | Debian-25.0.2+10-Debian-1deb13u2 |
   |  Tes

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070913#comment-18070913
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4185141487

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  14m 59s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 55s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  43m 48s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 47s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   7m 42s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   3m 36s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   6m 50s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m 36s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   6m 30s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |  10m  4s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  32m 36s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m 21s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 50s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 24s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 16s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   6m 16s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 16s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 16s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 27s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   7m 27s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 27s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 27s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   3m 16s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/23/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 165 unchanged 
- 0 fixed = 182 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   5m 52s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   5m 45s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 44s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   9m 54s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  32m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 17s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 53s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  28m 18s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  5s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 269m 28s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/23/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux ef51ac721ba1 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070869#comment-18070869
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4184121879

   Hello @K0K0V0K,
   May I ask for your review again when you able to get time?
   Thanks!




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069463#comment-18069463
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4151191890

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m 12s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  20m 12s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 22s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   3m 28s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 19s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  4s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   2m  9s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   4m  2s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  16m  0s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  16m 18s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 57s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   2m 57s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   2m 57s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 23s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 23s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/22/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 21 new + 164 unchanged 
- 0 fixed = 185 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m  4s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 54s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 56s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   4m 10s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  15m 49s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 50s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 31s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  23m  7s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 40s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 129m 59s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/22/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux 681455a92f5e 5.15.0-173-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069454#comment-18069454
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4150984899

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m 30s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  19m  9s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 26s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 18s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 11s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  4s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   3m 54s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  15m 51s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  16m 11s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 29s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  3s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   3m  3s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m  3s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m  3s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 14s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/22/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 21 new + 164 unchanged 
- 0 fixed = 185 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 56s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   4m  6s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  16m 10s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 49s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 31s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  23m  5s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/22/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 39s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 117m  7s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   |   | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/22/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux 8bb60cfe963b 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 
13:29:34 UTC 2026 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 48f5ad4a5547aa05b4dbb16ce2aed96e027fe72c |
   | Default Java | Debian-25.0.2+10-Debian-1deb13u2 |
   |  Te

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069431#comment-18069431
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4150732624

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m 54s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 59s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  26m 38s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m 22s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   4m 23s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   2m 10s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m 25s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   4m 23s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   4m 18s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   6m 16s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 16s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  18m 44s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 39s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 17s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   3m 17s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 17s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 17s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 19s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   4m 19s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   4m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 19s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  1s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 55s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/22/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 21 new + 164 unchanged 
- 0 fixed = 185 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   3m 54s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   3m 44s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   3m 47s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   6m 10s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  17m 50s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 34s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m  8s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  24m  9s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m 24s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 168m 33s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/22/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux cc98b0165997 5.15.0-173-generic #183-Ubuntu SMP Fri Mar 6 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069177#comment-18069177
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4146348334

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 33s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 27s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 27s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 17s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   6m 26s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   2m 25s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 42s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 26s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m 19s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   6m 53s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  29m  8s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 40s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 41s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 36s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 42s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 23s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   6m 23s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 23s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 21s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/21/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 93 new + 165 unchanged 
- 0 fixed = 258 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 22s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 58s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m  4s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   2m  5s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/21/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  29m 12s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 21s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 54s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  26m 59s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  5s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 201m 11s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yar

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069151#comment-18069151
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4145710745

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 33s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 33s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  38m 32s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 27s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 26s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 44s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 31s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   6m 56s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  29m  4s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 36s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 33s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 51s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 16s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/21/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 93 new + 165 unchanged 
- 0 fixed = 258 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 24s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m  9s |  |  the patch passed  |
   | -1 :x: |  spotbugs  |   2m  6s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/21/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  29m 46s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 21s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m  2s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  26m 55s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/21/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  8s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 184m 47s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 |
   |  |  
org.apache.hadoop.yarn.server.nodemanager.webapp.DiagnosticJStackService.runJStack(Map,
 int) makes inefficient use of keySet iterator instead of entrySet iterator  At 
DiagnosticJStackService.java:of keySet iterator instead of entrySet iterator  
At DiagnosticJStackService.java:[line 155] |
   | Failed junit tests | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   |   | hadoop.yarn.server.nod

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069129#comment-18069129
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4144765542

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 46s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 33s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  44m  9s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 44s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   7m 48s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   3m 28s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   6m 49s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m 38s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 54s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   9m 49s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  32m 22s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m  6s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 51s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 20s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 15s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   6m 15s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 15s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 15s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 38s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   7m 38s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 38s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 38s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   3m 18s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/21/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 93 new + 165 unchanged 
- 0 fixed = 258 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   5m 55s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   5m 44s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 36s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | -1 :x: |  spotbugs  |   2m 55s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/21/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  32m 35s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 20s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 49s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  28m 23s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  5s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 254m 17s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-s

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069006#comment-18069006
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r3001427630


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+Map> containerPids = 
getApplicationContainerPids(applicationId);
+
+return runJStack(containerPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected Map> 
getApplicationContainerPids(ApplicationId appId){
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+Map> containerPids = new HashMap<>();
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long parentPid = Long.parseLong(pidForContainerIdStr);
+
+  List javaContainerPids = ProcessHandle.of(parentPid).stream()
+.flatMap(ProcessHandle::descendants)
+.filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))

Review Comment:
   I have updated in my newest commit to check the commandLine specifically to 
equals with `java` or end with `\java`. I don't think replacing 
`ProcessHandle.of` to run another command with `ShellCommandExecutor` and 
modify C file to run `jps` is a wise approach.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067907#comment-18067907
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4115280731

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 34s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 41s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 58s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 22s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   6m 30s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   2m 31s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 41s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 22s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m 19s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   1m  9s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in trunk failed.  |
   | -1 :x: |  spotbugs  |   1m  9s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt)
 |  hadoop-yarn-common in trunk failed.  |
   | -1 :x: |  spotbugs  |   1m 11s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |  44m 56s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  45m 28s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 32s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 38s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   5m 38s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 38s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 27s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   6m 27s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 27s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 27s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 22s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 117 new + 165 
unchanged - 0 fixed = 282 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m  2s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   2m 59s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   1m  6s | 
[/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/patch-spotbugs-hadoop-y

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067870#comment-18067870
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4114692326

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  13m  8s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 22s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 20s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 27s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 43s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 29s |  |  trunk passed  |
   | -1 :x: |  spotbugs  |   1m 12s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in trunk failed.  |
   | -1 :x: |  spotbugs  |   1m 12s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt)
 |  hadoop-yarn-common in trunk failed.  |
   | -1 :x: |  spotbugs  |   1m 10s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |  41m 18s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  41m 50s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 32s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 23s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 117 new + 165 
unchanged - 0 fixed = 282 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 24s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 10s |  |  the patch passed  |
   | -1 :x: |  spotbugs  |   1m  9s | 
[/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in the patch failed.  |
   | -1 :x: |  spotbugs  |   1m  4s | 
[/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt)
 |  hadoop-yarn-common in the patch failed.  |
   | -1 :x: |  spotbugs  |   1m  7s | 
[/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | +1 :green_heart: |  shadedcli

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067848#comment-18067848
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4113969417

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  14m 38s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m  1s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  44m 13s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 40s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   7m 40s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   3m 34s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   6m 47s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m 30s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   6m 31s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | -1 :x: |  spotbugs  |   2m 19s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in trunk failed.  |
   | -1 :x: |  spotbugs  |   2m 10s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt)
 |  hadoop-yarn-common in trunk failed.  |
   | -1 :x: |  spotbugs  |   2m 14s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |  50m  2s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  50m 46s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 50s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 25s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 20s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 30s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   7m 30s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 30s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 30s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   3m 17s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 117 new + 165 
unchanged - 0 fixed = 282 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   5m 53s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   5m 44s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 33s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | -1 :x: |  spotbugs  |   2m  0s | 
[/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/20/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067336#comment-18067336
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2970284174


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,198 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationAccessType;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import javax.servlet.http.HttpServletRequest;
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {

Review Comment:
   Hmm...I see, so only an admin should be able to run the jstack for NM?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067182#comment-18067182
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4100984830

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 22s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  19m 35s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 19s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   3m 24s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   1m 20s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 55s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   2m  3s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   0m 45s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
 |  hadoop-yarn-api in trunk failed.  |
   | -1 :x: |  spotbugs  |   0m 41s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt)
 |  hadoop-yarn-common in trunk failed.  |
   | -1 :x: |  spotbugs  |   0m 44s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |  25m  0s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  25m 18s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 19s | 
[/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | -1 :x: |  compile  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt)
 |  hadoop-yarn in the patch failed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04.  |
   | -1 :x: |  cc  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt)
 |  hadoop-yarn in the patch failed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04.  |
   | -1 :x: |  golang  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt)
 |  hadoop-yarn in the patch failed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04.  |
   | -1 :x: |  javac  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt](https://ci-hadoop.apache.org/job/hadoop-multib

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067174#comment-18067174
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4100660084

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m 14s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  18m 36s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 37s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 11s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  4s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   3m 50s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  16m 13s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  16m 32s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 18s | 
[/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | -1 :x: |  compile  |   0m 41s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | -1 :x: |  cc  |   0m 41s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | -1 :x: |  golang  |   0m 41s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | -1 :x: |  javac  |   0m 41s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 57s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 96 new + 164 unchanged 
- 0 fixed = 260 total (was 164)  |
   | -1 :x: |  mvnsite  |   0m 19s | 
[/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | +1 :green_heart: |  javadoc  |   1m 10s |  |  the patch passed  |
   | -1 :x: |  spotbugs  |   0m 20s | 
[/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | -1 :x: |  shadedclient  |   6m 38s |  |  patch has errors when building 
and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067167#comment-18067167
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2967590944


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,198 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationAccessType;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import javax.servlet.http.HttpServletRequest;
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {

Review Comment:
   In case of NM stack i think we should check user is admin or not





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067153#comment-18067153
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4100256869

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   8m 27s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 49s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m 21s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   4m 31s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   2m 10s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m 29s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   4m 24s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   4m 19s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   6m 21s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 35s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  19m  3s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 28s | 
[/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | -1 :x: |  compile  |   0m 54s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  cc  |   0m 54s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  golang  |   0m 54s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  javac  |   0m 54s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  compile  |   1m  1s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-17.0.18+8-LTS.  |
   | -1 :x: |  cc  |   1m  1s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/19/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-17.0.18+8-LTS.  |
   | -1 :x: |  golang  |   1m  1s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/h

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067123#comment-18067123
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4099515477

   ### Test in Secured Cluster
   
   ACL Checks for knox ui user not authorised
   
   
https://{nm}:8443/gateway/cdp-proxy/yarn-nm/ws/v1/node/apps/application_1774020354194_0001/jstack/3



   User knoxui is not authorized to view application 
application_1774020354194_0001
   
   
   
After adding ‘knoxui’ at ‘yarn.admin.acl’
   

   
```
   
=== Thread Dumps for ContainerId: 
container_e04_1774021720635_0004_01_000242, PID: 341961 ===
   -

> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064983#comment-18064983
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4035985042

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 43s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 29s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 19s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   6m 23s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   2m 27s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 35s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 26s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m 24s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   6m 51s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  28m 44s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 17s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 27s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 30s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 37s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   5m 37s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 37s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 37s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 20s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 20s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 17s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/18/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 86 new + 165 unchanged 
- 0 fixed = 251 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m  7s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m  2s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   2m  3s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/18/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  29m 48s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 22s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 52s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  26m 55s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  4s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 201m 47s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yar

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064965#comment-18064965
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4035280902

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  13m 16s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 31s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m  6s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 18s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 22s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 37s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 30s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   6m 51s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  29m 20s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 52s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 22s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/18/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 86 new + 165 unchanged 
- 0 fixed = 251 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 10s |  |  the patch passed  |
   | -1 :x: |  spotbugs  |   2m  1s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/18/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  28m 56s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 19s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 57s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  26m 48s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/18/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  3s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 192m 30s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 |
   |  |  
org.apache.hadoop.yarn.server.nodemanager.webapp.DiagnosticJStackService.runJStack(Map,
 int) makes inefficient use of keySet iterator instead of entrySet iterator  At 
DiagnosticJStackService.java:of keySet iterator instead of entrySet iterator  
At DiagnosticJStackService.java:[line 108] |
   | Failed junit tests | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   |   | hadoop.yarn.server.nod

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064803#comment-18064803
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4034415669

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  14m 29s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m 12s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  44m  7s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 41s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   7m 42s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   3m 34s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   6m 47s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m 33s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   6m 24s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   9m 56s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  32m 39s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m 23s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 50s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 17s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   6m 17s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 17s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 17s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 31s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   7m 31s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 31s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   3m 11s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/18/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 86 new + 165 unchanged 
- 0 fixed = 251 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   5m 57s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   5m 41s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 39s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | -1 :x: |  spotbugs  |   2m 57s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/18/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  32m 42s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 18s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 49s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  28m 14s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  8s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 270m  8s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-s

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064571#comment-18064571
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2913078343


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+Map> containerPids = 
getApplicationContainerPids(applicationId);
+
+return runJStack(containerPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected Map> 
getApplicationContainerPids(ApplicationId appId){
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+Map> containerPids = new HashMap<>();
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long parentPid = Long.parseLong(pidForContainerIdStr);
+
+  List javaContainerPids = ProcessHandle.of(parentPid).stream()
+.flatMap(ProcessHandle::descendants)
+.filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))

Review Comment:
   also maybe there is a more robust way to check what is java process:
   
   can you please check this?
   https://docs.oracle.com/javase/7/docs/technotes/tools/share/jps.html





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly u

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064556#comment-18064556
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2912974437


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);

Review Comment:
   Aha, user_b will become 'yarn' user to execute getting the jstack.
   I did not know that 'yarn' user would be privileged to get the jstack 
despite 'user_a' is running the application.
   I will impelment checking ACL here then.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064553#comment-18064553
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2912944794


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);

Review Comment:
   `String runningUser = processHandle.info().user().orElse(NM_USER)`
   I think this will be the user who started the application right?
   In this case User_A
   what happens if User_B calls tha API?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064552#comment-18064552
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2912939218


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +636,60 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+  .build();
+} catch (IOException e){
+  throw new WebAppException("Shell command has failed: " + e.getMessage() 
+ ". " +
+  "For more information please check the NodeManager logs.");
+} catch (Exception e) {
+  throw new WebAppException(
+  "Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+  "For more information please check the NodeManager 
logs.");
+}
+  }
+
+
+  @GET
+  @Path("/apps/{appid}/jstack/{numberOfJStack}")
+  @Produces({MediaType.TEXT_PLAIN})
+  public Response getApplicationJStack(@PathParam("appid") String appId,
+   @PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectApplicationThreadDump(appId, 
numberOfJStack))
+  .build();
+} catch (RuntimeException e){
+  throw new WebAppException(
+  "The applicationId is invalid: " + appId + "." + e.getMessage());
+} catch (IOException e){
+  throw new WebAppException("Shell command has failed: " + e.getMessage() 
+ ". " +
+  "For more information please check the NodeManager logs.");
+} catch (Exception e) {

Review Comment:
   Sure, I will remove catching the general exception in both endpoints.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064549#comment-18064549
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2912919764


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +636,60 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+  .build();
+} catch (IOException e){
+  throw new WebAppException("Shell command has failed: " + e.getMessage() 
+ ". " +
+  "For more information please check the NodeManager logs.");
+} catch (Exception e) {
+  throw new WebAppException(
+  "Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+  "For more information please check the NodeManager 
logs.");
+}
+  }
+
+
+  @GET
+  @Path("/apps/{appid}/jstack/{numberOfJStack}")
+  @Produces({MediaType.TEXT_PLAIN})
+  public Response getApplicationJStack(@PathParam("appid") String appId,
+   @PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectApplicationThreadDump(appId, 
numberOfJStack))
+  .build();
+} catch (RuntimeException e){

Review Comment:
   you are right, it is from the ApplicationId.fromString(). I have not updated 
the exceptions here.
   Thanks!





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064546#comment-18064546
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2912902586


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+Map> containerPids = 
getApplicationContainerPids(applicationId);
+
+return runJStack(containerPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected Map> 
getApplicationContainerPids(ApplicationId appId){
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+Map> containerPids = new HashMap<>();
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long parentPid = Long.parseLong(pidForContainerIdStr);
+
+  List javaContainerPids = ProcessHandle.of(parentPid).stream()
+.flatMap(ProcessHandle::descendants)
+.filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))

Review Comment:
   Good idea, i will put those non-java container in the response.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064548#comment-18064548
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2912909448


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +636,60 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")

Review Comment:
   thanks, i forgot about that.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064545#comment-18064545
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2912891688


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);

Review Comment:
   hmm..since User_B is not the one running the application, it should not able 
to run the jstack since it requires the running_user of the application. In 
that case, the jstack command will fail:
   
   ```
   String[] jstackCommand = {
 containerExecutorPath, "--run-jstack", runningUser, 
String.valueOf(pid), JSTACK_PATH
   };
   ```
   Let me know if this fix the case or need to check ACL permissions earlier?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064508#comment-18064508
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4032119724

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 24s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  22m 11s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 31s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   3m 41s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   1m 33s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 12s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  2s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   2m 12s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   4m  8s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m 31s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  17m 51s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 35s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 28s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   3m 28s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 28s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 38s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   3m 38s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 38s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 38s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 27s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/17/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 86 new + 164 unchanged 
- 0 fixed = 250 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   2m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 51s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 56s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   1m 12s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/17/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  17m 37s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 41s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 35s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  23m 24s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 41s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 130m 34s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yar

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064460#comment-18064460
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4031175094

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m 51s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  22m  7s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 43s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 25s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 13s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m  0s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   4m  7s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  17m 57s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  18m 18s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 37s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 33s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   3m 33s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 33s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 33s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 12s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/17/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 86 new + 164 unchanged 
- 0 fixed = 250 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   1m 52s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 54s |  |  the patch passed  |
   | -1 :x: |  spotbugs  |   1m 14s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/17/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  17m 30s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 50s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 39s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  23m 43s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/17/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 44s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 125m 57s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 |
   |  |  
org.apache.hadoop.yarn.server.nodemanager.webapp.DiagnosticJStackService.runJStack(Map,
 int) makes inefficient use of keySet iterator instead of entrySet iterator  At 
DiagnosticJStackService.java:of keySet iterator instead of entrySet iterator  
At DiagnosticJStackService.java:[line 108] |
   | Failed junit tests | 
hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   |   | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containerma

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064447#comment-18064447
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2911270255


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +636,60 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+  .build();
+} catch (IOException e){
+  throw new WebAppException("Shell command has failed: " + e.getMessage() 
+ ". " +
+  "For more information please check the NodeManager logs.");
+} catch (Exception e) {
+  throw new WebAppException(
+  "Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+  "For more information please check the NodeManager 
logs.");
+}
+  }
+
+
+  @GET
+  @Path("/apps/{appid}/jstack/{numberOfJStack}")
+  @Produces({MediaType.TEXT_PLAIN})
+  public Response getApplicationJStack(@PathParam("appid") String appId,
+   @PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectApplicationThreadDump(appId, 
numberOfJStack))
+  .build();
+} catch (RuntimeException e){

Review Comment:
   If i see right this should be IllegalArgumentException





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064443#comment-18064443
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2911258725


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +636,60 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+  .build();
+} catch (IOException e){
+  throw new WebAppException("Shell command has failed: " + e.getMessage() 
+ ". " +
+  "For more information please check the NodeManager logs.");
+} catch (Exception e) {
+  throw new WebAppException(
+  "Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+  "For more information please check the NodeManager 
logs.");
+}
+  }
+
+
+  @GET
+  @Path("/apps/{appid}/jstack/{numberOfJStack}")
+  @Produces({MediaType.TEXT_PLAIN})
+  public Response getApplicationJStack(@PathParam("appid") String appId,
+   @PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (!isJStackEndpointsEnable) {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+
+try {
+  return Response.status(Status.OK)
+  
.entity(diagnosticJStackService.collectApplicationThreadDump(appId, 
numberOfJStack))
+  .build();
+} catch (RuntimeException e){
+  throw new WebAppException(
+  "The applicationId is invalid: " + appId + "." + e.getMessage());
+} catch (IOException e){
+  throw new WebAppException("Shell command has failed: " + e.getMessage() 
+ ". " +
+  "For more information please check the NodeManager logs.");
+} catch (Exception e) {

Review Comment:
   collectApplicationThreadDump can only throw IO exception so i think this 
catch is not required here





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064441#comment-18064441
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2911240966


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +636,60 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")

Review Comment:
   Can you please add the mediatype annitation here also?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064439#comment-18064439
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2911203380


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+Map> containerPids = 
getApplicationContainerPids(applicationId);
+
+return runJStack(containerPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected Map> 
getApplicationContainerPids(ApplicationId appId){
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+Map> containerPids = new HashMap<>();
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long parentPid = Long.parseLong(pidForContainerIdStr);
+
+  List javaContainerPids = ProcessHandle.of(parentPid).stream()
+.flatMap(ProcessHandle::descendants)
+.filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))

Review Comment:
   Now only java based container checked with jstack what is good.
   However now if a container is not java proc, and user wants to debug it with 
the API, the container wont be present in the response what can be confusing.
   Instead if skipping non java based containers, can you please add them to 
the response and marked them there like not java containers so jstack can not 
be done for them?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>   

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064437#comment-18064437
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2911174540


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,148 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);

Review Comment:
   Is it possible to check acl permissions of the running user here?
   Now if User_A runs an app what can not be accessed by User_B, than with this 
API User_B can find out what User_A is doing.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064419#comment-18064419
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4030462829

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   9m 52s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m  4s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  30m 32s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m 57s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   4m 37s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   2m  4s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m  0s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 44s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   3m 45s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   6m 29s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  21m 42s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  22m  8s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  8s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 55s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   3m 55s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 55s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 55s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 53s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   4m 53s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   4m 53s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 53s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 26s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/17/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 86 new + 164 unchanged 
- 0 fixed = 250 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   3m 35s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   3m  6s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   3m 11s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | -1 :x: |  spotbugs  |   1m 54s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/17/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  19m 58s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 38s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 20s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  24m 26s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m 28s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 179m 26s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-s

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064115#comment-18064115
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4024003779

   
[ApplicationJStack_application_1772624045426.txt](https://github.com/user-attachments/files/25844226/ApplicationJStack_application_1772624045426.txt)
   New Response from 
`{nodemanager}/ws/v1/node/apps/application_1772624045426_0003/jstack/2`




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064054#comment-18064054
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2904672742


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,139 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+List applicationPids = getApplicationPids(applicationId);
+
+return runJStack(applicationPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected List getApplicationPids(ApplicationId appId){
+List pids = new ArrayList<>();
+
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long pidForContainerId = Long.parseLong(pidForContainerIdStr);
+
+  ProcessHandle.of(pidForContainerId).ifPresent(handle ->
+handle.descendants() // Get only the java processId of containerId's 
children
+  .filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))
+  .map(ProcessHandle::pid)
+  .forEach(pids::add)
+  );
+
+}
+
+LOG.info("Application PIDs: {}", pids);
+
+return pids;
+  }
+
+  private String runJStack(List pids, int numJStacks) throws IOException 
{
+StringBuilder result = new StringBuilder();
+
+for(Long pid : pids){
+  result.append(String.format(
+"=== Thread Dumps for PID: %d ===%n%s%n", pid, runJStack(pid, 
numJStacks)));
+}
+
+return result.toString();
+  }
+
+  private String runJStack(long pid, int numJStacks) throws IOException {
+ProcessHandle processHandle = ProcessHandle.of(pid)
+.orElseThrow(() -> new IOException("Process with PID " + pid + " 
is no longer exists"));
+
+String processOwner = processHandle.info().user().orElse(NM_USER);

Review Comment:
   True! I will change it 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064052#comment-18064052
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2904651080


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,139 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+List applicationPids = getApplicationPids(applicationId);
+
+return runJStack(applicationPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected List getApplicationPids(ApplicationId appId){
+List pids = new ArrayList<>();
+
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long pidForContainerId = Long.parseLong(pidForContainerIdStr);
+
+  ProcessHandle.of(pidForContainerId).ifPresent(handle ->
+handle.descendants() // Get only the java processId of containerId's 
children
+  .filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))
+  .map(ProcessHandle::pid)
+  .forEach(pids::add)
+  );
+
+}
+
+LOG.info("Application PIDs: {}", pids);
+
+return pids;
+  }
+
+  private String runJStack(List pids, int numJStacks) throws IOException 
{
+StringBuilder result = new StringBuilder();
+
+for(Long pid : pids){
+  result.append(String.format(
+"=== Thread Dumps for PID: %d ===%n%s%n", pid, runJStack(pid, 
numJStacks)));
+}
+
+return result.toString();
+  }
+
+  private String runJStack(long pid, int numJStacks) throws IOException {
+ProcessHandle processHandle = ProcessHandle.of(pid)
+.orElseThrow(() -> new IOException("Process with PID " + pid + " 
is no longer exists"));
+
+String processOwner = processHandle.info().user().orElse(NM_USER);
+String containerExecutorPath = 
Privil

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064026#comment-18064026
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2904410535


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +634,63 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (isJStackEndpointsEnable) {
+  try {
+DiagnosticJStackService diagnosticJStackService = new 
DiagnosticJStackService(this.nmContext);
+return Response.status(Status.OK)
+
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+.build();
+  } catch (IOException e){
+throw new WebAppException("Shell command has failed: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  } catch (Exception e) {
+throw new WebAppException(
+"Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  }
+} else {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+  }
+
+
+  @GET
+  @Path("/apps/{appid}/jstack/{numberOfJStack}")
+  @Produces({MediaType.TEXT_PLAIN})
+  public Response getApplicationJStack(@PathParam("appid") String appId,
+   @PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (isJStackEndpointsEnable) {
+  try {
+DiagnosticJStackService diagnosticJStackService = new 
DiagnosticJStackService(this.nmContext);

Review Comment:
   Thanks! That will make the code more cleaner.
   I will update in my new commit.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064023#comment-18064023
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2904355404


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +634,63 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (isJStackEndpointsEnable) {
+  try {
+DiagnosticJStackService diagnosticJStackService = new 
DiagnosticJStackService(this.nmContext);
+return Response.status(Status.OK)
+
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+.build();
+  } catch (IOException e){
+throw new WebAppException("Shell command has failed: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  } catch (Exception e) {
+throw new WebAppException(
+"Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  }
+} else {
+  return Response.status(Status.METHOD_NOT_ALLOWED)

Review Comment:
   Exactly! I overlooked about that. Thank you for pointing that!
   I will change in my new commit.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064019#comment-18064019
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2904303472


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,139 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+List applicationPids = getApplicationPids(applicationId);
+
+return runJStack(applicationPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected List getApplicationPids(ApplicationId appId){
+List pids = new ArrayList<>();
+
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long pidForContainerId = Long.parseLong(pidForContainerIdStr);
+
+  ProcessHandle.of(pidForContainerId).ifPresent(handle ->
+handle.descendants() // Get only the java processId of containerId's 
children
+  .filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))
+  .map(ProcessHandle::pid)
+  .forEach(pids::add)

Review Comment:
   Thanks! I am refactoring in my new commit with .toList()





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064008#comment-18064008
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2904128455


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -2315,6 +2315,11 @@ public static boolean isAclEnabled(Configuration conf) {
   public static final String LINUX_CONTAINER_RUNTIME_PREFIX = NM_PREFIX +
   "runtime.linux.";
 
+  /** Flag to turn on/off jstack endpoints for NodeManager. By default is True 
**/
+  public static final String NM_JSTACK_ENDPOINTS_ENABLED =
+  NM_PREFIX + "jstack-endpoints.enabled";

Review Comment:
   Okay, i see your point. I will keep it as it is since this is only for the 
jstack maybe in the future a new configuration shall be added or refactored to 
combine both together maybe jmap or something.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063688#comment-18063688
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4015333917

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  13m 36s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 27s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 42s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 32s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   6m 19s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   2m 31s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 43s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 24s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m 23s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   6m 54s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  28m 50s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 21s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 29s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 41s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   5m 41s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 41s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 41s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 19s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   6m 19s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 19s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 21s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/16/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 79 new + 165 unchanged 
- 0 fixed = 244 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m  5s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   3m  2s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   7m  5s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  29m  4s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 21s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 51s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  26m 40s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  6s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 214m 22s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/16/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux 64d647d22268 5.15.0-164-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063676#comment-18063676
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4014674334

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  13m  7s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  35m 26s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 25s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   2m 23s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 29s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 22s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   6m 55s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  29m 21s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  29m 53s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 33s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 42s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   2m 17s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/16/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 79 new + 165 unchanged 
- 0 fixed = 244 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   3m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m  9s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   7m 12s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  29m 25s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 18s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 56s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  27m  0s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/16/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  7s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 193m  9s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | TEST-cetest |
   |   | 
hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer
 |
   |   | hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/16/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux 9183f18b9a2b 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 
20:25:16 UTC 2025 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 0dd487086565553f5f5e72cc65ce0cee1cc9252c |
   | Default Java | Debian-25.0.2+10-Debian-1deb13u2 |
   |  Te

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063635#comment-18063635
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4013820452

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |  14m 36s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 35s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  45m 34s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   7m 39s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   7m 43s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   3m 30s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   6m 42s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   6m 32s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   6m 19s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |  10m  2s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  32m 58s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m 43s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 49s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 14s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  cc  |   6m 14s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   6m 14s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 14s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 24s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  cc  |   7m 24s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   7m 24s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   7m 24s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   3m 15s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/16/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 79 new + 165 unchanged 
- 0 fixed = 244 total (was 165)  |
   | +1 :green_heart: |  mvnsite  |   5m 59s |  |  the patch passed  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   5m 42s |  |  the patch passed with JDK 
Red Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   5m 30s |  |  the patch passed with JDK 
Red Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   9m 45s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  32m 29s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 17s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 50s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  28m 14s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  5s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 271m 32s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/16/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux 48e602706ace 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063605#comment-18063605
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4013068173

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 23s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  19m 54s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 22s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   3m 31s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   1m 19s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  8s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 49s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 51s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   3m 39s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  15m 39s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  15m 58s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 13s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  cc  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 19s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  cc  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  golang  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 10s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 79 new + 164 unchanged 
- 0 fixed = 243 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   1m 53s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 40s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   3m 54s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  15m 55s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 49s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 22s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  22m 43s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 121m 41s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.54 ServerAPI=1.54 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint cc 
golang |
   | uname | Linux dfbb62c95554 5.15.0-164-

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063594#comment-18063594
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2896716587


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,139 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+List applicationPids = getApplicationPids(applicationId);
+
+return runJStack(applicationPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected List getApplicationPids(ApplicationId appId){
+List pids = new ArrayList<>();
+
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long pidForContainerId = Long.parseLong(pidForContainerIdStr);
+
+  ProcessHandle.of(pidForContainerId).ifPresent(handle ->
+handle.descendants() // Get only the java processId of containerId's 
children
+  .filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))
+  .map(ProcessHandle::pid)
+  .forEach(pids::add)
+  );
+
+}
+
+LOG.info("Application PIDs: {}", pids);
+
+return pids;
+  }
+
+  private String runJStack(List pids, int numJStacks) throws IOException 
{
+StringBuilder result = new StringBuilder();
+
+for(Long pid : pids){
+  result.append(String.format(
+"=== Thread Dumps for PID: %d ===%n%s%n", pid, runJStack(pid, 
numJStacks)));
+}
+
+return result.toString();
+  }
+
+  private String runJStack(long pid, int numJStacks) throws IOException {
+ProcessHandle processHandle = ProcessHandle.of(pid)
+.orElseThrow(() -> new IOException("Process with PID " + pid + " 
is no longer exists"));
+
+String processOwner = processHandle.info().user().orElse(NM_USER);

Review Comment:
   maybe runningUser can be a bet

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063592#comment-18063592
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2896706819


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,139 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+List applicationPids = getApplicationPids(applicationId);
+
+return runJStack(applicationPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected List getApplicationPids(ApplicationId appId){
+List pids = new ArrayList<>();
+
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long pidForContainerId = Long.parseLong(pidForContainerIdStr);
+
+  ProcessHandle.of(pidForContainerId).ifPresent(handle ->
+handle.descendants() // Get only the java processId of containerId's 
children
+  .filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))
+  .map(ProcessHandle::pid)
+  .forEach(pids::add)

Review Comment:
   instead of foreach, can you just collect to list?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063590#comment-18063590
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2896690387


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -2315,6 +2315,11 @@ public static boolean isAclEnabled(Configuration conf) {
   public static final String LINUX_CONTAINER_RUNTIME_PREFIX = NM_PREFIX +
   "runtime.linux.";
 
+  /** Flag to turn on/off jstack endpoints for NodeManager. By default is True 
**/
+  public static final String NM_JSTACK_ENDPOINTS_ENABLED =
+  NM_PREFIX + "jstack-endpoints.enabled";

Review Comment:
   but yes, based on the property desc we can keep as it is





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063589#comment-18063589
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2896686394


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -2315,6 +2315,11 @@ public static boolean isAclEnabled(Configuration conf) {
   public static final String LINUX_CONTAINER_RUNTIME_PREFIX = NM_PREFIX +
   "runtime.linux.";
 
+  /** Flag to turn on/off jstack endpoints for NodeManager. By default is True 
**/
+  public static final String NM_JSTACK_ENDPOINTS_ENABLED =
+  NM_PREFIX + "jstack-endpoints.enabled";

Review Comment:
   If later someone would like to add other functionality to the endpoint a 
more generic name can be useful here.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063588#comment-18063588
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2896670582


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +634,63 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (isJStackEndpointsEnable) {
+  try {
+DiagnosticJStackService diagnosticJStackService = new 
DiagnosticJStackService(this.nmContext);
+return Response.status(Status.OK)
+
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+.build();
+  } catch (IOException e){
+throw new WebAppException("Shell command has failed: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  } catch (Exception e) {
+throw new WebAppException(
+"Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  }
+} else {
+  return Response.status(Status.METHOD_NOT_ALLOWED)
+  .build();
+}
+  }
+
+
+  @GET
+  @Path("/apps/{appid}/jstack/{numberOfJStack}")
+  @Produces({MediaType.TEXT_PLAIN})
+  public Response getApplicationJStack(@PathParam("appid") String appId,
+   @PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (isJStackEndpointsEnable) {
+  try {
+DiagnosticJStackService diagnosticJStackService = new 
DiagnosticJStackService(this.nmContext);

Review Comment:
   This should not be a class level variable?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063587#comment-18063587
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r289362


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java:
##
@@ -628,6 +634,63 @@ public Response syncYarnSysFS(@javax.ws.rs.core.Context
 return Response.ok().build();
   }
 
+
+  @GET
+  @Path("/jstack/{numberOfJStack}")
+  public Response getNodeThreadDump(@PathParam("numberOfJStack") int 
numberOfJStack)
+  {
+if (isJStackEndpointsEnable) {
+  try {
+DiagnosticJStackService diagnosticJStackService = new 
DiagnosticJStackService(this.nmContext);
+return Response.status(Status.OK)
+
.entity(diagnosticJStackService.collectNodeThreadDump(numberOfJStack))
+.build();
+  } catch (IOException e){
+throw new WebAppException("Shell command has failed: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  } catch (Exception e) {
+throw new WebAppException(
+"Unexpected error collection NodeManager JStack: " + 
e.getMessage() + ". " +
+"For more information please check the NodeManager logs.");
+  }
+} else {
+  return Response.status(Status.METHOD_NOT_ALLOWED)

Review Comment:
   I think an early return can reduce the method complexity here





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063586#comment-18063586
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2896659542


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,139 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.exceptions.YarnRuntimeException;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.privileged.PrivilegedOperationExecutor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  private static final String NM_USER = System.getProperty("user.name");
+  private static final String JSTACK_PATH = System.getProperty("java.home") + 
"/bin/jstack";
+  private final Context context;
+  private final Configuration conf;
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+this.conf = context.getConf();
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+checkShellNotWindows();
+
+ApplicationId applicationId = ApplicationId.fromString(appId);
+List applicationPids = getApplicationPids(applicationId);
+
+return runJStack(applicationPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  protected List getApplicationPids(ApplicationId appId){
+List pids = new ArrayList<>();
+
+Application app = context.getApplications().get(appId);
+if (app == null){
+  throw new YarnRuntimeException("Application " + appId + " does not 
exist");
+}
+
+for (ContainerId containerId : app.getContainers().keySet()){
+  String pidForContainerIdStr = 
context.getContainerExecutor().getProcessId(containerId);
+  long pidForContainerId = Long.parseLong(pidForContainerIdStr);
+
+  ProcessHandle.of(pidForContainerId).ifPresent(handle ->
+handle.descendants() // Get only the java processId of containerId's 
children
+  .filter(childProcess -> 
childProcess.info().command().orElse("").contains("java"))
+  .map(ProcessHandle::pid)
+  .forEach(pids::add)
+  );
+
+}
+
+LOG.info("Application PIDs: {}", pids);
+
+return pids;
+  }
+
+  private String runJStack(List pids, int numJStacks) throws IOException 
{
+StringBuilder result = new StringBuilder();
+
+for(Long pid : pids){
+  result.append(String.format(
+"=== Thread Dumps for PID: %d ===%n%s%n", pid, runJStack(pid, 
numJStacks)));
+}
+
+return result.toString();
+  }
+
+  private String runJStack(long pid, int numJStacks) throws IOException {
+ProcessHandle processHandle = ProcessHandle.of(pid)
+.orElseThrow(() -> new IOException("Process with PID " + pid + " 
is no longer exists"));
+
+String processOwner = processHandle.info().user().orElse(NM_USER);
+String containerExecutorPath = 
PrivilegedOpe

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063575#comment-18063575
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4012441713

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m 18s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  19m  5s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 20s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 17s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  4s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 59s |  |  trunk passed  |
   | +1 :green_heart: |  spotbugs  |   3m 42s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  16m 23s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  16m 43s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 19s | 
[/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | -1 :x: |  compile  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | -1 :x: |  cc  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | -1 :x: |  golang  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | -1 :x: |  javac  |   0m 42s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m  2s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 78 new + 164 unchanged 
- 0 fixed = 242 total (was 164)  |
   | -1 :x: |  mvnsite  |   0m 20s | 
[/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | +1 :green_heart: |  javadoc  |   1m  8s |  |  the patch passed  |
   | -1 :x: |  spotbugs  |   0m 19s | 
[/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | -1 :x: |  shadedclient  |   6m 27s |  |  patch has errors when building 
and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063574#comment-18063574
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4012391663

   > Will clean up the code:
   > 
   > * add the jstack at container-executor.c is not a good idea, probably need 
a new dependent file for it
   > * The complexity at DiagnosticJStackService.runJStack() shall be reduced
   > 
   > Beside that when testing, it works as expected
   
   Cleaned up the code.
   
   Since the container-executor is executing as privilege user and only already 
have other function like delete_as_user or delete_path. I think putting one 
function for running jstack here would not be a problem architecturally.




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063553#comment-18063553
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4012001942

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m 57s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 20s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 18s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m 17s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  compile  |   4m 27s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  checkstyle  |   2m 15s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   4m 37s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   4m 34s |  |  trunk passed with JDK Red 
Hat, Inc.-21.0.10+7-LTS  |
   | +1 :green_heart: |  javadoc  |   4m 25s |  |  trunk passed with JDK Red 
Hat, Inc.-17.0.18+8-LTS  |
   | +1 :green_heart: |  spotbugs  |   6m 19s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 23s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  18m 52s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 27s | 
[/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch failed.  |
   | -1 :x: |  compile  |   0m 52s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  cc  |   0m 52s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  golang  |   0m 52s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  javac  |   0m 52s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-21.0.10+7-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-21.0.10+7-LTS.  |
   | -1 :x: |  compile  |   0m 57s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-17.0.18+8-LTS.  |
   | -1 :x: |  cc  |   0m 57s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/15/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt)
 |  hadoop-yarn in the patch failed with JDK Red Hat, Inc.-17.0.18+8-LTS.  |
   | -1 :x: |  golang  |   0m 57s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkRedHat,Inc.-17.0.18+8-LTS.txt](https://ci-hadoop.apache.org/job/h

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062775#comment-18062775
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3998848580

   Will clean up the code:
   - add the jstack at container-executor.c is not a good idea, probably need a 
new dependent file for it
   - The complexity at DiagnosticJStackService.runJStack() shall be reduced
   
   Beside that when testing, it works as expected
   
   `
   Running JStack command: [/var/lib/yarn-ce/bin/container-executor, 
--run-jstack, yarn, 55844]
   `




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062240#comment-18062240
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3986187174

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   7m  6s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  27m 53s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   3m 20s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   1m 19s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  1s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 54s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   2m  2s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   3m 43s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  15m 46s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  16m  5s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  6s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javac  |   3m  6s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 19s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  javac  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 11s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/12/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 76 new + 164 unchanged 
- 0 fixed = 240 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   1m 55s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 43s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 46s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   3m 54s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  15m 36s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 46s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 20s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  22m 26s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 33s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 136m 15s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.53 ServerAPI=1.53 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/12/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
   | uname | Linux d75f2f64279f 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 
20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / cf2253b0d1335382c01c32ca1cd0e2a307c8afe7 |
   | Default Java | Ubuntu-17.0.18+8-Ubuntu-124.04.1

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062177#comment-18062177
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2872955310


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,135 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.classification.VisibleForTesting;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.container.Container;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private final Context context;
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+if(!appId.matches("application_\\d{13}_\\d{4}")) {
+  throw new RuntimeException("Invalid application id: " + appId);
+}
+checkShellNotWindows();
+
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+  }
+
+  private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+  throw new UnsupportedOperationException("Not implemented for Windows.");
+}
+  }
+
+  @VisibleForTesting
+  List getApplicationPids(String appId){

Review Comment:
   True, I will update it in my next commit.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062185#comment-18062185
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2873067277


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,139 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.classification.VisibleForTesting;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.container.Container;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+private final Context context;
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public DiagnosticJStackService(Context context) {
+this.context = context;
+}
+
+public String collectNodeThreadDump(int numberOfJStack)
+throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+}
+
+public String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws IOException {
+if(!appId.matches("application_\\d{13}_\\d{4}")) {
+throw new RuntimeException("Invalid application id: " + appId);
+}
+checkShellNotWindows();
+
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+private void checkShellNotWindows() {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+}
+
+@VisibleForTesting
+List getApplicationPids(String appId){
+List pids = new ArrayList<>();
+
+ApplicationId appIdObj = ApplicationId.fromString(appId);
+Application app = context.getApplications().get(appIdObj);
+if (app != null) {
+Map containers = app.getContainers();
+for (ContainerId containerId : containers.keySet()){
+long pidForContainerId = 
Long.parseLong(context.getContainerExecutor().getProcessId(containerId));
+
+ProcessHandle.of(pidForContainerId).ifPresent(parentProcess ->
+parentProcess.descendants()
+.filter(childProcess ->
+
childProcess.info().command().orElse("").contains("java"))
+.map(ProcessHandle::pid)
+.forEach(pids::add)
+);
+
+}
+}
+
+return pids;
+
+}
+
+private String runJStack(List pids, int numJStacks) throws 
IOException {
+StringBuilder result = new StringBuilder();
+
+for(Long pid : pids){
+result.append(runJStack(pid, numJStacks));
+}
+
+return result.toString();
+}
+
+private String runJStack(long pid, int numJStacks) throws IOException {
+Optional processHandle = ProcessHandle.of(pid);
+
+if (processHandle.isEmpty()){
+throw new IOException("Process with PID " + pid + " is no longer 
exists");
+}
+
+String processOwner = processHandle.get().info().user().orElse("root");
+String[] jstackCommand = {"sudo", "-u", processOw

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062100#comment-18062100
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2871620589


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,135 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+
+import org.apache.hadoop.classification.VisibleForTesting;
+import org.apache.hadoop.util.Shell;
+import org.apache.hadoop.yarn.api.records.ApplicationId;
+import org.apache.hadoop.yarn.api.records.ContainerId;
+import org.apache.hadoop.yarn.server.nodemanager.Context;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.Application;
+import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.container.Container;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Arrays;
+
+public class DiagnosticJStackService {
+
+  private final Context context;
+  private static final Logger LOG = 
LoggerFactory.getLogger(DiagnosticJStackService.class);
+
+  public DiagnosticJStackService(Context context) {
+this.context = context;
+  }
+
+  public String collectNodeThreadDump(int numberOfJStack) throws IOException {
+checkShellNotWindows();
+
+long nodeManagerPid = ProcessHandle.current().pid();
+
+return runJStack(nodeManagerPid, numberOfJStack);
+  }
+
+  public String collectApplicationThreadDump(String appId, int numberOfJStack) 
throws IOException {
+if(!appId.matches("application_\\d{13}_\\d{4}")) {

Review Comment:
   Nice!
   Thanks for the suggestions. The regular expression has already built-in there





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060824#comment-18060824
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3953978939

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 25s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m 22s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 52s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 52s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   3m 32s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  2s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 47s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 58s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   3m 43s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  15m 39s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  15m 58s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  7s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javac  |   3m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 29s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  javac  |   3m 29s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 17s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/9/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 70 new + 164 unchanged 
- 0 fixed = 234 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   1m 49s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 39s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 49s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   1m 11s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/9/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  16m  7s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 46s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 20s |  |  hadoop-yarn-common in the patch 
passed.  |
   | -1 :x: |  unit  |  22m 24s | 
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/9/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt)
 |  hadoop-yarn-server-nodemanager in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 37s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 131m 58s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-proje

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060789#comment-18060789
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3953299865

   Next step is to create unit-test for DiagnosticJstackService class:
   1. Check the applicationId, wrong format
   2. User should not be able to run more than 20 number of Jstack
   3. Test on getting the Process ID for specific applicationId
   4. Test when running jstack command on a ProcessId then the process is not 
alive anymore





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18060786#comment-18060786
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2848212461


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"

Review Comment:
   Updated it in my new commit.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059913#comment-18059913
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3934929665

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 21s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   7m 34s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 34s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 17s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  compile  |   3m 20s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  checkstyle  |   1m 20s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 53s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 57s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 54s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   3m 49s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  16m 14s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  16m 32s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 29s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  5s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javac  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  javac  |   3m 21s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 13s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/8/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: The patch generated 94 new + 164 unchanged 
- 0 fixed = 258 total (was 164)  |
   | +1 :green_heart: |  mvnsite  |   1m 44s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 45s |  |  the patch passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  |  the patch passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | -1 :x: |  spotbugs  |   1m  9s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/8/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  16m  9s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 47s |  |  hadoop-yarn-api in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   4m 16s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  22m 38s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 37s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 129m 12s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 |
   |  |  Format string should use %n rather than n in 
org.apache.hadoop.yarn.server.nodemanager.webapp.DiagnosticJStackService.runJStack(long,
 int)  At DiagnosticJStackService.java:rather than n in

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059388#comment-18059388
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3921935854

   All the endpoints failed with 404 as of now. Not sure why this is happening
   
   1. 
http://localhost:8044/ws/v1/node/apps/application_1771432292573_0002/jstack/3
   2. http://localhost:8044/ws/v1/node/jstack/4




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059143#comment-18059143
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3916702561

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 24s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  10m 12s |  |  Maven dependency ordering for branch  |
   | -1 :x: |  mvninstall  |  21m 31s | 
[/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/branch-mvninstall-root.txt)
 |  root in trunk failed.  |
   | -1 :x: |  compile  |   3m 28s | 
[/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt)
 |  hadoop-yarn in trunk failed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04.  |
   | -1 :x: |  compile  |   3m 36s | 
[/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-17.0.18+8-Ubuntu-124.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/branch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-17.0.18+8-Ubuntu-124.04.1.txt)
 |  hadoop-yarn in trunk failed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1.  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 57s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 59s |  |  trunk passed with JDK 
Ubuntu-21.0.10+7-Ubuntu-124.04  |
   | +1 :green_heart: |  javadoc  |   1m 50s |  |  trunk passed with JDK 
Ubuntu-17.0.18+8-Ubuntu-124.04.1  |
   | +1 :green_heart: |  spotbugs  |   3m 39s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  15m 45s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  16m  4s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 28s |  |  the patch passed  |
   | -1 :x: |  compile  |   3m 34s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt)
 |  hadoop-yarn in the patch failed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04.  |
   | -1 :x: |  javac  |   3m 34s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-21.0.10+7-Ubuntu-124.04.txt)
 |  hadoop-yarn in the patch failed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04.  |
   | -1 :x: |  compile  |   3m 28s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-17.0.18+8-Ubuntu-124.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-17.0.18+8-Ubuntu-124.04.1.txt)
 |  hadoop-yarn in the patch failed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1.  
|
   | -1 :x: |  javac  |   3m 28s | 
[/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-17.0.18+8-Ubuntu-124.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-17.0.18+8-Ubuntu-124.04.1.txt)
 |  hadoop-yarn in the patch failed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1.  
|
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 15s | 
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/7/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
 |  hadoop-yarn-project/hadoop-yarn: Th

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058189#comment-18058189
 ] 

ASF GitHub Bot commented on YARN-11823:
---

hadoop-yetus commented on PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#issuecomment-3892159641

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m  0s |  |  Docker mode activated.  |
   | -1 :x: |  docker  |   0m 19s |  |  Docker failed to build run-specific 
yetus/hadoop:tp-5346}.  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hadoop/pull/8123 |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8123/6/console |
   | versions | git=2.34.1 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058188#comment-18058188
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2800015120


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"

Review Comment:
   Ahh I see, I have not thought about that.
   Thank you for your suggestions!
   I will update it in a later commit





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058187#comment-18058187
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r288809


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {

Review Comment:
   Added in my new commit with IOException and add more catch statements at the 
Controller class





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058172#comment-18058172
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2799586567


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"

Review Comment:
   what if someone use a monitor process in the node and it has a 
org.apache.hadoop.yarn.server.nodemanager.NodeManager parameter?
   why dont you ask from java what is the current process id?
   something like
   ```
   long pid = ProcessHandle.current().pid();
   System.out.println("PID: " + pid);
   ```





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058170#comment-18058170
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2799529238


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"

Review Comment:
   With `ps aux | grep org.apache.hadoop.yarn.server.nodemanager.NodeManager | 
grep -v grep`





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058164#comment-18058164
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2799358146


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"

Review Comment:
   Ahh, I see your point!
   I will be more specified to get only the nodemanager process





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058140#comment-18058140
 ] 

ASF GitHub Bot commented on YARN-11823:
---

K0K0V0K commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798899654


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"

Review Comment:
   what if some AM container is runing on the node what is called like
   `java -jar mycorp.jar nodemanager`
   ?





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058138#comment-18058138
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798878418


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"
+},
+null,
+null,
+10_000
+);
+cmd.execute();
+return extractPids(cmd.getOutput());
+}
+
+public static List getApplicationPids(String appId) throws 
IOException {
+String psCmd = "ps aux | grep jvm/java | grep " + appId + " | grep -v 
-e /bin/bash -e grep";

Review Comment:
   Thanks for pointing for that out. My bad.
   I totally forgot about it.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058137#comment-18058137
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798875618


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows");
+}
+
+List nodeManagerPids = getNodeManagerPids();
+
+return runJStack(nodeManagerPids, numberOfJStack);
+
+}
+
+
+
+public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+throws Exception {
+if (Shell.WINDOWS) {
+throw new UnsupportedOperationException("Not implemented for 
Windows.");
+}
+List applicationPids = getApplicationPids(appId);
+
+return runJStack(applicationPids, numberOfJStack);
+}
+
+
+public static List getNodeManagerPids() throws IOException {
+Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+new String[]{
+"bash",
+"-c",
+"ps aux | grep nodemanager | grep -v grep"

Review Comment:
   The endpoint will be called from nodemanager. So only the nodemanagers 
processes only that host will be used





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058135#comment-18058135
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798856667


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+
+public static String collectNodeThreadDump(int numberOfJStack)
+throws Exception {

Review Comment:
   Thanks!
   I will update it in my new commit. 
   Probably a new exception class for this jstack endpoint.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058134#comment-18058134
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798853337


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+private static final Logger LOG = LoggerFactory
+.getLogger(DiagnosticJStackService.class);
+

Review Comment:
   Sure, I have not thought of that.
   Will update in my new commit.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058132#comment-18058132
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798830291


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -2315,6 +2315,11 @@ public static boolean isAclEnabled(Configuration conf) {
   public static final String LINUX_CONTAINER_RUNTIME_PREFIX = NM_PREFIX +
   "runtime.linux.";
 
+  /** Flag to turn on/off jstack endpoints for NodeManager. By default is True 
**/
+  public static final String NM_JSTACK_ENDPOINTS_ENABLED =
+  NM_PREFIX + "jstack-endpoints.enabled";

Review Comment:
   hmmm...since this configuration only control the jstack endpoints, so I 
think it is better to name it jstack instead of diagnostic.
   
   May I know why do you want to name it diagnostic-api?
   
   It seems to general to me.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058130#comment-18058130
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798812456


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -2315,6 +2315,11 @@ public static boolean isAclEnabled(Configuration conf) {
   public static final String LINUX_CONTAINER_RUNTIME_PREFIX = NM_PREFIX +
   "runtime.linux.";
 
+  /** Flag to turn on/off jstack endpoints for NodeManager. By default is True 
**/
+  public static final String NM_JSTACK_ENDPOINTS_ENABLED =
+  NM_PREFIX + "jstack-endpoints.enabled";
+  public static final boolean DEFAULT_NM_JSTACK_ENDPOINTS_ENABLED = true;

Review Comment:
   Yep, you are right!
   I will update in my next commit.





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-11823) New JStack endpoint for running containers and nodes

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058131#comment-18058131
 ] 

ASF GitHub Bot commented on YARN-11823:
---

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798813577


##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##
@@ -2315,6 +2315,11 @@ public static boolean isAclEnabled(Configuration conf) {
   public static final String LINUX_CONTAINER_RUNTIME_PREFIX = NM_PREFIX +
   "runtime.linux.";
 
+  /** Flag to turn on/off jstack endpoints for NodeManager. By default is True 
**/
+  public static final String NM_JSTACK_ENDPOINTS_ENABLED =

Review Comment:
   Sure, I forgot about that 





> New JStack endpoint for running containers and nodes
> 
>
> Key: YARN-11823
> URL: https://issues.apache.org/jira/browse/YARN-11823
> Project: Hadoop YARN
>  Issue Type: New Feature
>  Components: yarn
>Reporter: chhinlinghean
>Assignee: chhinlinghean
>Priority: Major
>  Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org