[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080716#comment-14080716 ] Junping Du commented on YARN-2051: -- Hi [~decster], thanks for working on this. I will

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080719#comment-14080719 ] Junping Du commented on YARN-2051: -- Forget to mention, +1 on the idea for testing these PB

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080727#comment-14080727 ] Junping Du commented on YARN-2051: -- Not sure if patch is still updated, manually kick off

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080750#comment-14080750 ] Hadoop QA commented on YARN-2051: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080780#comment-14080780 ] Junping Du commented on YARN-2051: -- Again, good work, [~decster]! Some comments below,

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080829#comment-14080829 ] Hadoop QA commented on YARN-2051: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080934#comment-14080934 ] Junping Du commented on YARN-2051: -- +1. Patch looks good to me. Will commit it tomorrow if

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061627#comment-14061627 ] Hadoop QA commented on YARN-2051: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061629#comment-14061629 ] Binglin Chang commented on YARN-2051: - The failed test is not related, see YARN-2270

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008623#comment-14008623 ] Wangda Tan commented on YARN-2051: -- Hi [~decster], I think in the future, we can consider

[jira] [Commented] (YARN-2051) Fix code bug and add more unit tests for PBImpls

[ https://issues.apache.org/jira/browse/YARN-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008654#comment-14008654 ] Binglin Chang commented on YARN-2051: - Hi [~wangda], thanks for the notice. Fix code