[jira] [Commented] (YARN-2121) TimelineAuthenticator#hasDelegationToken may throw NPE
[
https://issues.apache.org/jira/browse/YARN-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020779#comment-14020779
]
Hudson commented on YARN-2121:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #576 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/576/])
YARN-2121. Fixed NPE handling in Timeline Server's TimelineAuthenticator.
Contributed by Zhijie Shen. (vinodkv:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601000)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineAuthenticator.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineAuthenticator.java
TimelineAuthenticator#hasDelegationToken may throw NPE
--
Key: YARN-2121
URL: https://issues.apache.org/jira/browse/YARN-2121
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Fix For: 2.5.0
Attachments: YARN-2121.1.patch
{code}
private boolean hasDelegationToken(URL url) {
return url.getQuery().contains(
TimelineAuthenticationConsts.DELEGATION_PARAM + =);
}
{code}
If the given url doesn't have any params at all. It will throw NPE.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2121) TimelineAuthenticator#hasDelegationToken may throw NPE
[
https://issues.apache.org/jira/browse/YARN-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020807#comment-14020807
]
Hudson commented on YARN-2121:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1767 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1767/])
YARN-2121. Fixed NPE handling in Timeline Server's TimelineAuthenticator.
Contributed by Zhijie Shen. (vinodkv:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601000)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineAuthenticator.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineAuthenticator.java
TimelineAuthenticator#hasDelegationToken may throw NPE
--
Key: YARN-2121
URL: https://issues.apache.org/jira/browse/YARN-2121
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Fix For: 2.5.0
Attachments: YARN-2121.1.patch
{code}
private boolean hasDelegationToken(URL url) {
return url.getQuery().contains(
TimelineAuthenticationConsts.DELEGATION_PARAM + =);
}
{code}
If the given url doesn't have any params at all. It will throw NPE.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2121) TimelineAuthenticator#hasDelegationToken may throw NPE
[
https://issues.apache.org/jira/browse/YARN-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020832#comment-14020832
]
Hudson commented on YARN-2121:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1794 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1794/])
YARN-2121. Fixed NPE handling in Timeline Server's TimelineAuthenticator.
Contributed by Zhijie Shen. (vinodkv:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601000)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineAuthenticator.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineAuthenticator.java
TimelineAuthenticator#hasDelegationToken may throw NPE
--
Key: YARN-2121
URL: https://issues.apache.org/jira/browse/YARN-2121
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Fix For: 2.5.0
Attachments: YARN-2121.1.patch
{code}
private boolean hasDelegationToken(URL url) {
return url.getQuery().contains(
TimelineAuthenticationConsts.DELEGATION_PARAM + =);
}
{code}
If the given url doesn't have any params at all. It will throw NPE.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2121) TimelineAuthenticator#hasDelegationToken may throw NPE
[
https://issues.apache.org/jira/browse/YARN-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020324#comment-14020324
]
Vinod Kumar Vavilapalli commented on YARN-2121:
---
Tx for taking care of this.
The patch looks good. The test issue is tracked at YARN-2075.
+1, checking this in.
TimelineAuthenticator#hasDelegationToken may throw NPE
--
Key: YARN-2121
URL: https://issues.apache.org/jira/browse/YARN-2121
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Attachments: YARN-2121.1.patch
{code}
private boolean hasDelegationToken(URL url) {
return url.getQuery().contains(
TimelineAuthenticationConsts.DELEGATION_PARAM + =);
}
{code}
If the given url doesn't have any params at all. It will throw NPE.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2121) TimelineAuthenticator#hasDelegationToken may throw NPE
[
https://issues.apache.org/jira/browse/YARN-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020355#comment-14020355
]
Hudson commented on YARN-2121:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5659 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5659/])
YARN-2121. Fixed NPE handling in Timeline Server's TimelineAuthenticator.
Contributed by Zhijie Shen. (vinodkv:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601000)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineAuthenticator.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineAuthenticator.java
TimelineAuthenticator#hasDelegationToken may throw NPE
--
Key: YARN-2121
URL: https://issues.apache.org/jira/browse/YARN-2121
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Fix For: 2.5.0
Attachments: YARN-2121.1.patch
{code}
private boolean hasDelegationToken(URL url) {
return url.getQuery().contains(
TimelineAuthenticationConsts.DELEGATION_PARAM + =);
}
{code}
If the given url doesn't have any params at all. It will throw NPE.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2121) TimelineAuthenticator#hasDelegationToken may throw NPE
[
https://issues.apache.org/jira/browse/YARN-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016010#comment-14016010
]
Hadoop QA commented on YARN-2121:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648019/YARN-2121.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:
org.apache.hadoop.yarn.client.TestRMAdminCLI
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3894//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3894//console
This message is automatically generated.
TimelineAuthenticator#hasDelegationToken may throw NPE
--
Key: YARN-2121
URL: https://issues.apache.org/jira/browse/YARN-2121
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Zhijie Shen
Assignee: Zhijie Shen
Attachments: YARN-2121.1.patch
{code}
private boolean hasDelegationToken(URL url) {
return url.getQuery().contains(
TimelineAuthenticationConsts.DELEGATION_PARAM + =);
}
{code}
If the given url doesn't have any params at all. It will throw NPE.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
