[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020781#comment-14020781
 ] 

Hudson commented on YARN-2122:
--

FAILURE: Integrated in Hadoop-Yarn-trunk #576 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/576/])
YARN-2122. In AllocationFileLoaderService, the reloadThread should be created 
in init() and started in start(). (Robert Kanter via kasha) (kasha: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601045)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java


 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Fix For: 2.5.0

 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020809#comment-14020809
 ] 

Hudson commented on YARN-2122:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk #1767 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1767/])
YARN-2122. In AllocationFileLoaderService, the reloadThread should be created 
in init() and started in start(). (Robert Kanter via kasha) (kasha: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601045)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java


 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Fix For: 2.5.0

 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020834#comment-14020834
 ] 

Hudson commented on YARN-2122:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1794 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1794/])
YARN-2122. In AllocationFileLoaderService, the reloadThread should be created 
in init() and started in start(). (Robert Kanter via kasha) (kasha: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601045)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java


 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Fix For: 2.5.0

 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-06 Thread Tsuyoshi OZAWA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020310#comment-14020310
 ] 

Tsuyoshi OZAWA commented on YARN-2122:
--

[~rkanter], thank you for updating a patch! Minor nits comments from me:

Should we call {{super.serviceInit(conf)}} at the end of this method instead of 
at the start of this method?

{code}
+super.serviceInit(conf);
+if (allocFile != null) {
+  reloadThread = new Thread() {
{code}

Otherwise code looks good to me.

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-06 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020349#comment-14020349
 ] 

Hadoop QA commented on YARN-2122:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12648705/YARN-2122.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3929//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3929//console

This message is automatically generated.

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-06 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020403#comment-14020403
 ] 

Hadoop QA commented on YARN-2122:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12648712/YARN-2122.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3930//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3930//console

This message is automatically generated.

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-06 Thread Tsuyoshi OZAWA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020478#comment-14020478
 ] 

Tsuyoshi OZAWA commented on YARN-2122:
--

+1(non-binding). [~kkambatl], do you have additional comments?

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-06 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020594#comment-14020594
 ] 

Karthik Kambatla commented on YARN-2122:


Looks good to me. +1. Committing this shortly.

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-06 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020600#comment-14020600
 ] 

Karthik Kambatla commented on YARN-2122:


Thanks Robert for the contribution and Tsuyoshi for the review. Just committed 
this to trunk and branch-2.






 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Fix For: 2.5.0

 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020603#comment-14020603
 ] 

Hudson commented on YARN-2122:
--

SUCCESS: Integrated in Hadoop-trunk-Commit #5662 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/5662/])
YARN-2122. In AllocationFileLoaderService, the reloadThread should be created 
in init() and started in start(). (Robert Kanter via kasha) (kasha: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1601045)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java


 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Fix For: 2.5.0

 Attachments: YARN-2122.patch, YARN-2122.patch, YARN-2122.patch, 
 YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-05 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019565#comment-14019565
 ] 

Karthik Kambatla commented on YARN-2122:


{code}
  public void serviceInit(Configuration conf) {
this.allocFile = getAllocationFile(conf);
super.init(conf);
reloadThread = new Thread() {
  public void run() {
{code}
- We should call super.serviceInit instead of super.init, and that call should 
be the last statement of the method.
- Creation of reloadThread should be guarded by if (allocFile != null)

{code}
  public void serviceStart() {
if (allocFile == null) {
  return;
}
reloadThread.start();
super.start();
  }
{code}
- It is good practice to call super.serviceStart() at the end of this method 
(not super.start()). So, we should probably not check for (allocFile == null) 
and instead call reloadThread.start() after checking (allocFile != null).

- super.serviceStop instead of super.stop
- For the findbugs warning, I see why we don't have to do any additional 
synchronization. Can we add a findbugs exclusion? 

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-02 Thread Tsuyoshi OZAWA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015986#comment-14015986
 ] 

Tsuyoshi OZAWA commented on YARN-2122:
--

Thank you for taking this JIRA, [~rkanter]. I think your patch fixes the issue 
itself.

I have one comment - how about overriding 
serviceInit()/serviceStart()/serviceStop() instead of init()/start()/stop()? 
Should we do this on another JIRA? [~kkambatl], what do you think?

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016032#comment-14016032
 ] 

Hadoop QA commented on YARN-2122:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12648023/YARN-2122.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3895//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3895//console

This message is automatically generated.

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-02 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016035#comment-14016035
 ] 

Karthik Kambatla commented on YARN-2122:


Good point, [~ozawa]. It would definitely be better to override serviceInit, 
serivceStart, serviceStop. 

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016075#comment-14016075
 ] 

Hadoop QA commented on YARN-2122:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12648031/YARN-2122.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3896//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-YARN-Build/3896//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3896//console

This message is automatically generated.

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2122) In AllocationFileLoaderService, the reloadThread should be created in init() and started in start()

2014-06-02 Thread Robert Kanter (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016097#comment-14016097
 ] 

Robert Kanter commented on YARN-2122:
-

Findbugs is complaining that the three methods are no synchronized.  This isn't 
a problem because all three methods have a javadoc comment in AbstractService 
that says something like this:
{noformat}
   * This method will only ever be called once during the lifecycle of
   * a specific service instance.
   *
   * Implementations do not need to be synchronized as the logic
   * in {@link #init(Configuration)} prevents re-entrancy.
{noformat}

 In AllocationFileLoaderService, the reloadThread should be created in init() 
 and started in start()
 ---

 Key: YARN-2122
 URL: https://issues.apache.org/jira/browse/YARN-2122
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Robert Kanter
 Attachments: YARN-2122.patch, YARN-2122.patch


 AllcoationFileLoaderService has this reloadThread that is currently created 
 and started in start(). Instead, it should be created in init() and started 
 in start().



--
This message was sent by Atlassian JIRA
(v6.2#6252)