[jira] [Commented] (YARN-2155) FairScheduler: Incorrect check when trigger a preemption

2014-06-12 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029514#comment-14029514
 ] 

Hadoop QA commented on YARN-2155:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12650080/YARN-2155.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3971//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3971//console

This message is automatically generated.

 FairScheduler: Incorrect check when trigger a preemption
 

 Key: YARN-2155
 URL: https://issues.apache.org/jira/browse/YARN-2155
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Wei Yan
Assignee: Wei Yan
 Attachments: YARN-2155.patch


 {code}
 private boolean shouldAttemptPreemption() {
   if (preemptionEnabled) {
 return (preemptionUtilizationThreshold  Math.max(
 (float) rootMetrics.getAvailableMB() / clusterResource.getMemory(),
 (float) rootMetrics.getAvailableVirtualCores() /
 clusterResource.getVirtualCores()));
   }
   return false;
 }
 {code}
 preemptionUtilizationThreshould should be compared with allocatedResource 
 instead of availableResource.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2155) FairScheduler: Incorrect check when trigger a preemption

2014-06-12 Thread Karthik Kambatla (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029792#comment-14029792
 ] 

Karthik Kambatla commented on YARN-2155:


Good catch [~octo47]. Thanks for fixing it, Wei.

The fix looks good to me. +1. 

 FairScheduler: Incorrect check when trigger a preemption
 

 Key: YARN-2155
 URL: https://issues.apache.org/jira/browse/YARN-2155
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Wei Yan
Assignee: Wei Yan
 Attachments: YARN-2155.patch


 {code}
 private boolean shouldAttemptPreemption() {
   if (preemptionEnabled) {
 return (preemptionUtilizationThreshold  Math.max(
 (float) rootMetrics.getAvailableMB() / clusterResource.getMemory(),
 (float) rootMetrics.getAvailableVirtualCores() /
 clusterResource.getVirtualCores()));
   }
   return false;
 }
 {code}
 preemptionUtilizationThreshould should be compared with allocatedResource 
 instead of availableResource.



--
This message was sent by Atlassian JIRA
(v6.2#6252)