[jira] [Commented] (YARN-2234) Incorrect description in RM audit logs while refreshing Admin ACL
[ https://issues.apache.org/jira/browse/YARN-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060366#comment-14060366 ] Kenji Kikushima commented on YARN-2234: --- This patch contains log message modification only. I think no additional test needed. And I tried failed tests locally, no error occurred. {noformat} Running org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.42 sec - in org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices Running org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps Tests run: 40, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 168.308 sec - in org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps Running org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.725 sec - in org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler Running org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 75.733 sec - in org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification Running org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.253 sec - in org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Running org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.783 sec - in org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched Results : Tests run: 105, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 4:51.743s [INFO] Finished at: Mon Jul 14 14:56:46 UTC 2014 [INFO] Final Memory: 31M/375M [INFO] {noformat} Incorrect description in RM audit logs while refreshing Admin ACL - Key: YARN-2234 URL: https://issues.apache.org/jira/browse/YARN-2234 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.4.0 Reporter: Varun Saxena Assignee: Kenji Kikushima Attachments: YARN-2234.patch In method, AdminService#refreshAdminAcls(AdminService.java:446), failure RM audit log, which is generated when RM is not active, has following description : ResourceManager is not active. Can not refresh user-groups. This should instead be changed to ResourceManager is not active. Can not refresh admin ACLs'. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2234) Incorrect description in RM audit logs while refreshing Admin ACL
[ https://issues.apache.org/jira/browse/YARN-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060341#comment-14060341 ] Hadoop QA commented on YARN-2234: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655491/YARN-2234.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/4289//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4289//console This message is automatically generated. Incorrect description in RM audit logs while refreshing Admin ACL - Key: YARN-2234 URL: https://issues.apache.org/jira/browse/YARN-2234 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.4.0 Reporter: Varun Saxena Assignee: Kenji Kikushima Attachments: YARN-2234.patch In method, AdminService#refreshAdminAcls(AdminService.java:446), failure RM audit log, which is generated when RM is not active, has following description : ResourceManager is not active. Can not refresh user-groups. This should instead be changed to ResourceManager is not active. Can not refresh admin ACLs'. -- This message was sent by Atlassian JIRA (v6.2#6252)