[jira] [Commented] (YARN-2500) [YARN-796] Miscellaneous changes in ResourceManager to support labels

2014-10-06 Thread Wangda Tan (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160858#comment-14160858
 ] 

Wangda Tan commented on YARN-2500:
--

Regarding comments from [~vinodkv],
bq. As with other patches, Labels -> NodeLabels. You'll need to change all of 
the following:...
Addressed
bq. ApplicationMasterService: There are multiple 
this.rmContext.getRMApps().get(appAttemptId.getApplicationId() calls in the the 
allocate method. Refactor to avoid dup calls.
Addressed
bq. TestSchedulerUtils: testValidateResourceRequestWithErrorLabelsPermission: 
Why are "" and " " accepted when only x and y are recognized labels?
Empty label expression "" should be accept by any queue, and " " will be 
trimmed to empty.
bq. Given we don't support yet other features in ResourceRequest for the AM 
container like priority, locality, shall we also hard-code them to 
AM_CONTAINER_PRIORITY, ResourceRequest.ANY respectively too?
Agree, now set values to default for 
priority/#container/resource-name/relax-locality
bq. Can we add test-case for num-containers, priority, locality for AM 
container?
Added test "testScheduleTransitionReplaceAMContainerRequestWithDefaults" in 
RMAppAttemptImpl.

Please kindly review,

Thanks,
Wangda

> [YARN-796] Miscellaneous changes in ResourceManager to support labels
> -
>
> Key: YARN-2500
> URL: https://issues.apache.org/jira/browse/YARN-2500
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Reporter: Wangda Tan
>Assignee: Wangda Tan
> Attachments: YARN-2500.patch, YARN-2500.patch, YARN-2500.patch, 
> YARN-2500.patch, YARN-2500.patch
>
>
> This patches contains changes in ResourceManager to support labels



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2500) [YARN-796] Miscellaneous changes in ResourceManager to support labels

2014-09-18 Thread Wangda Tan (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138720#comment-14138720
 ] 

Wangda Tan commented on YARN-2500:
--

Highlight major changes for easier review:
* Properly setup and check label expression according to ResourceRequest, 
ApplicationSubmissionContext and queue default label expression
** Located in {{ApplicationMasterService}}, 
{{RMServerUtils#validateResourceRequest}}
* In the past, ResourceRequest of AM container created in two places (one in 
{{RMAppManager}}, another one in {{RMAppAttemptImpl}}), when trying to allocate 
resource from YarnScheduler, the 2nd ResourceRequest doesn't normalized. Now 
reduced this to only one: ResourceRequest will be created in {{RMAppManager}} 
only, and it will pass ResourceRequest to RMAppImpl to allocate resource
* Check if a queue has permission to access all labels in label-expression of a 
ResourceRequest, located in {{SchedulerUtils.validateResourceRequest}}
* Added getLabels() and getDefaultLabelExpression to Queue
* Added get/set NodeLabelManager in RMContext

> [YARN-796] Miscellaneous changes in ResourceManager to support labels
> -
>
> Key: YARN-2500
> URL: https://issues.apache.org/jira/browse/YARN-2500
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Reporter: Wangda Tan
>Assignee: Wangda Tan
> Attachments: YARN-2500.patch, YARN-2500.patch, YARN-2500.patch
>
>
> This patches contains changes in ResourceManager to support labels



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2500) [YARN-796] Miscellaneous changes in ResourceManager to support labels

2014-09-12 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131634#comment-14131634
 ] 

Hadoop QA commented on YARN-2500:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12668347/YARN-2500.patch
  against trunk revision 78b0483.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 10 new 
or modified test files.

{color:red}-1 javac{color:red}.  The patch appears to cause the build to 
fail.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4923//console

This message is automatically generated.

> [YARN-796] Miscellaneous changes in ResourceManager to support labels
> -
>
> Key: YARN-2500
> URL: https://issues.apache.org/jira/browse/YARN-2500
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Reporter: Wangda Tan
>Assignee: Wangda Tan
> Attachments: YARN-2500.patch, YARN-2500.patch, YARN-2500.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2500) [YARN-796] Miscellaneous changes in ResourceManager to support labels

2014-09-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129877#comment-14129877
 ] 

Hadoop QA commented on YARN-2500:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12668004/YARN-2500.patch
  against trunk revision 4be9517.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified test files.

{color:red}-1 javac{color:red}.  The patch appears to cause the build to 
fail.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4889//console

This message is automatically generated.

> [YARN-796] Miscellaneous changes in ResourceManager to support labels
> -
>
> Key: YARN-2500
> URL: https://issues.apache.org/jira/browse/YARN-2500
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Reporter: Wangda Tan
>Assignee: Wangda Tan
> Attachments: YARN-2500.patch, YARN-2500.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2500) [YARN-796] Miscellaneous changes in ResourceManager to support labels

2014-09-09 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127167#comment-14127167
 ] 

Hadoop QA commented on YARN-2500:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12667432/YARN-2500.patch
  against trunk revision 90c8ece.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified test files.

{color:red}-1 javac{color:red}.  The patch appears to cause the build to 
fail.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4856//console

This message is automatically generated.

> [YARN-796] Miscellaneous changes in ResourceManager to support labels
> -
>
> Key: YARN-2500
> URL: https://issues.apache.org/jira/browse/YARN-2500
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Reporter: Wangda Tan
>Assignee: Wangda Tan
> Attachments: YARN-2500.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)