[jira] [Commented] (YARN-2635) TestRMRestart should run with all schedulers
[ https://issues.apache.org/jira/browse/YARN-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156963#comment-14156963 ] Karthik Kambatla commented on YARN-2635: Just saw YARN-2638 as well. On second thought, it might be better to club the two JIRAs and implement a base class for RM tests that run against all schedulers. And, schedulerType in these tests should probably be an enum so subclasses don't have to know the order. TestRMRestart should run with all schedulers Key: YARN-2635 URL: https://issues.apache.org/jira/browse/YARN-2635 Project: Hadoop YARN Issue Type: Bug Reporter: Wei Yan Assignee: Wei Yan Attachments: YARN-2635-1.patch If we change the scheduler from Capacity Scheduler to Fair Scheduler, the TestRMRestart would fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2635) TestRMRestart should run with all schedulers
[ https://issues.apache.org/jira/browse/YARN-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157246#comment-14157246 ] Ray Chiang commented on YARN-2635: -- Tested TestRM/TestRMRestart/TestClientToAMTokens. All three tests now pass cleanly using FairScheduler. +1 TestRMRestart should run with all schedulers Key: YARN-2635 URL: https://issues.apache.org/jira/browse/YARN-2635 Project: Hadoop YARN Issue Type: Bug Reporter: Wei Yan Assignee: Wei Yan Attachments: YARN-2635-1.patch, YARN-2635-2.patch If we change the scheduler from Capacity Scheduler to Fair Scheduler, the TestRMRestart would fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2635) TestRMRestart should run with all schedulers
[ https://issues.apache.org/jira/browse/YARN-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157274#comment-14157274 ] Ray Chiang commented on YARN-2635: -- Oops, pending Jenkins of course. TestRMRestart should run with all schedulers Key: YARN-2635 URL: https://issues.apache.org/jira/browse/YARN-2635 Project: Hadoop YARN Issue Type: Bug Reporter: Wei Yan Assignee: Wei Yan Attachments: YARN-2635-1.patch, YARN-2635-2.patch If we change the scheduler from Capacity Scheduler to Fair Scheduler, the TestRMRestart would fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2635) TestRMRestart should run with all schedulers
[
https://issues.apache.org/jira/browse/YARN-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157296#comment-14157296
]
Hadoop QA commented on YARN-2635:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672637/YARN-2635-2.patch
against trunk revision 6ac1051.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5242//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5242//console
This message is automatically generated.
TestRMRestart should run with all schedulers
Key: YARN-2635
URL: https://issues.apache.org/jira/browse/YARN-2635
Project: Hadoop YARN
Issue Type: Bug
Reporter: Wei Yan
Assignee: Wei Yan
Attachments: YARN-2635-1.patch, YARN-2635-2.patch
If we change the scheduler from Capacity Scheduler to Fair Scheduler, the
TestRMRestart would fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2635) TestRMRestart should run with all schedulers
[ https://issues.apache.org/jira/browse/YARN-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157515#comment-14157515 ] Karthik Kambatla commented on YARN-2635: By the way, these tests take a long time to run. Do we want to run against all three schedulers? Or, would it be enough to run against CS and FS? TestRMRestart should run with all schedulers Key: YARN-2635 URL: https://issues.apache.org/jira/browse/YARN-2635 Project: Hadoop YARN Issue Type: Bug Reporter: Wei Yan Assignee: Wei Yan Attachments: YARN-2635-1.patch, YARN-2635-2.patch, yarn-2635-3.patch If we change the scheduler from Capacity Scheduler to Fair Scheduler, the TestRMRestart would fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2635) TestRMRestart should run with all schedulers
[
https://issues.apache.org/jira/browse/YARN-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157579#comment-14157579
]
Hadoop QA commented on YARN-2635:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12672709/yarn-2635-3.patch
against trunk revision 054f285.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5247//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5247//console
This message is automatically generated.
TestRMRestart should run with all schedulers
Key: YARN-2635
URL: https://issues.apache.org/jira/browse/YARN-2635
Project: Hadoop YARN
Issue Type: Bug
Reporter: Wei Yan
Assignee: Wei Yan
Attachments: YARN-2635-1.patch, YARN-2635-2.patch, yarn-2635-3.patch
If we change the scheduler from Capacity Scheduler to Fair Scheduler, the
TestRMRestart would fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2635) TestRMRestart should run with all schedulers
[
https://issues.apache.org/jira/browse/YARN-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157624#comment-14157624
]
Sandy Ryza commented on YARN-2635:
--
This seems like a good idea. A few stylistic comments.
Can we rename RMSchedulerParametrizedTestBase to
ParameterizedSchedulerTestBase? The former confuses me a little because it
like something that happened, rather than a noun, and RM doesn't seem
necessary. Also, Parameterized as spelled in the JUnit class name has three
e's. Lastly, can the class include some header comments on what it's doing?
{code}
+ protected void configScheduler(YarnConfiguration conf) throws IOException {
+// Configure scheduler
{code}
Just name the method configureScheduler instead of an abbreviation then comment.
{code}
+ private void configFifoScheduler(YarnConfiguration conf) {
+conf.set(YarnConfiguration.RM_SCHEDULER, FifoScheduler.class.getName());
+ }
+
+ private void configCapacityScheduler(YarnConfiguration conf) {
+conf.set(YarnConfiguration.RM_SCHEDULER,
CapacityScheduler.class.getName());
+ }
{code}
These are only one line - can we just inline them?
{code}
+ protected YarnConfiguration conf = null;
{code}
I think better to make this private and expose it through a getConfig method.
Running the tests without FIFO seems reasonable to me.
One last thought - not sure how feasible this is, but the code might be simpler
if we get rid of SchedulerType and just have the parameters be Configuration
objects?
TestRMRestart should run with all schedulers
Key: YARN-2635
URL: https://issues.apache.org/jira/browse/YARN-2635
Project: Hadoop YARN
Issue Type: Bug
Reporter: Wei Yan
Assignee: Wei Yan
Attachments: YARN-2635-1.patch, YARN-2635-2.patch, yarn-2635-3.patch
If we change the scheduler from Capacity Scheduler to Fair Scheduler, the
TestRMRestart would fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
