[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193228#comment-14193228
]
Hudson commented on YARN-2701:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1944 (See
[htt
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193196#comment-14193196
]
Hudson commented on YARN-2701:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1919 (See
[https://
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193110#comment-14193110
]
Hudson commented on YARN-2701:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #730 (See
[https://b
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192544#comment-14192544
]
Xuan Gong commented on YARN-2701:
-
Committed to trunk/branch-2/branch-2.6. Thanks for the r
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192543#comment-14192543
]
Hudson commented on YARN-2701:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6413 (See
[https:
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192327#comment-14192327
]
Hadoop QA commented on YARN-2701:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192239#comment-14192239
]
Xuan Gong commented on YARN-2701:
-
Thanks for the reviews. Will commit it once Jenkins give
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189117#comment-14189117
]
Allen Wittenauer commented on YARN-2701:
OK, this compiled without incident, so I'm
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184687#comment-14184687
]
Xuan Gong commented on YARN-2701:
-
[~aw] Do you have any other comments ?
> Potential race
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183808#comment-14183808
]
Hadoop QA commented on YARN-2701:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183681#comment-14183681
]
Allen Wittenauer commented on YARN-2701:
OK, a simple test I did moved these functi
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183678#comment-14183678
]
Xuan Gong commented on YARN-2701:
-
so, how about moving the function declarations into cont
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183663#comment-14183663
]
Allen Wittenauer commented on YARN-2701:
Sorry, I copied the wrong message, but yes
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183656#comment-14183656
]
zhihai xu commented on YARN-2701:
-
I think the warning is because we should add definition
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183638#comment-14183638
]
Allen Wittenauer commented on YARN-2701:
I'm blowing an error:
{code}
container-ex
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181616#comment-14181616
]
Jian He commented on YARN-2701:
---
lgtm too, thanks Binglin and Zhihai for reviewing the patch
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181090#comment-14181090
]
Hadoop QA commented on YARN-2701:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181041#comment-14181041
]
Xuan Gong commented on YARN-2701:
-
Thanks for the review. [~decster].
Uploaded a new patch
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180955#comment-14180955
]
Binglin Chang commented on YARN-2701:
-
Hi Xuan Gong, thank for the patch. Path lgtm, ju
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180592#comment-14180592
]
Xuan Gong commented on YARN-2701:
-
[~aw] Do you have any other comments for this patch ?
>
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180174#comment-14180174
]
Xuan Gong commented on YARN-2701:
-
[~zxu] Thanks for reviewing this patch again. New patch
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180119#comment-14180119
]
zhihai xu commented on YARN-2701:
-
One nit in the addendum patch:
Can we change
{code}
if
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179560#comment-14179560
]
Xuan Gong commented on YARN-2701:
-
[~aw] Thanks for the summary. Let us not revert the curr
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178708#comment-14178708
]
Allen Wittenauer commented on YARN-2701:
So let's summarize the current situation:
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178494#comment-14178494
]
Hudson commented on YARN-2701:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1933 (See
[htt
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178424#comment-14178424
]
Hudson commented on YARN-2701:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1908 (See
[https://
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178305#comment-14178305
]
Hudson commented on YARN-2701:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #719 (See
[https://b
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178007#comment-14178007
]
Allen Wittenauer commented on YARN-2701:
FWIW, I've re-opened this JIRA because I'm
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177866#comment-14177866
]
Hudson commented on YARN-2701:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6297 (See
[https:
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177834#comment-14177834
]
zhihai xu commented on YARN-2701:
-
thanks [~jianhe], The latest patch LGTM.
> Potential ra
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177814#comment-14177814
]
Jian He commented on YARN-2701:
---
+1
> Potential race condition in startLocalizer when using
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177799#comment-14177799
]
Hadoop QA commented on YARN-2701:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177765#comment-14177765
]
Jian He commented on YARN-2701:
---
since the previous method has been used/tested thoroughly, I
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177761#comment-14177761
]
Xuan Gong commented on YARN-2701:
-
Sorry. Online discussion with [~jianhe]. And thanks for
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177750#comment-14177750
]
Xuan Gong commented on YARN-2701:
-
Had some off line discussion with [~jianhan]. We think t
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177675#comment-14177675
]
Hadoop QA commented on YARN-2701:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177655#comment-14177655
]
zhihai xu commented on YARN-2701:
-
thanks [~xgong], The latest patch LGTM.
> Potential rac
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177636#comment-14177636
]
Xuan Gong commented on YARN-2701:
-
Good catch Fixed
> Potential race condition in star
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177627#comment-14177627
]
zhihai xu commented on YARN-2701:
-
thanks [~xgong], the latest patch looks most good to me,
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177601#comment-14177601
]
Hadoop QA commented on YARN-2701:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177562#comment-14177562
]
Xuan Gong commented on YARN-2701:
-
addressed all comments
> Potential race condition in st
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177477#comment-14177477
]
zhihai xu commented on YARN-2701:
-
Hi [~xgong], thanks for the details explanation. The exp
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177322#comment-14177322
]
Xuan Gong commented on YARN-2701:
-
[~zxu] Thanks for the feedback.
bq. Do we need to check
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176202#comment-14176202
]
zhihai xu commented on YARN-2701:
-
thanks [~xgong], I want to discuss about check_permissi
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175919#comment-14175919
]
Hadoop QA commented on YARN-2701:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175917#comment-14175917
]
Hadoop QA commented on YARN-2701:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175907#comment-14175907
]
Xuan Gong commented on YARN-2701:
-
Thanks for the review. Addressed all comments
> Potenti
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175821#comment-14175821
]
zhihai xu commented on YARN-2701:
-
Thanks [~xgong], [~vinodkv] Couple comments:
1. Should
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175359#comment-14175359
]
Hadoop QA commented on YARN-2701:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175344#comment-14175344
]
Hadoop QA commented on YARN-2701:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174544#comment-14174544
]
Hadoop QA commented on YARN-2701:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174496#comment-14174496
]
Xuan Gong commented on YARN-2701:
-
To solve this problem, we need to change the native code
52 matches
Mail list logo
