[jira] [Commented] (YARN-2707) Potential null dereference in FSDownload
[
https://issues.apache.org/jira/browse/YARN-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193224#comment-14193224
]
Hudson commented on YARN-2707:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1944 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1944/])
YARN-2707. Potential null dereference in FSDownload. Contributed by Gera
Shegalov (jlowe: rev 7bc179f9f5e1e270fd5e6f1ad29b0f32fe371d15)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
> Potential null dereference in FSDownload
>
>
> Key: YARN-2707
> URL: https://issues.apache.org/jira/browse/YARN-2707
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: YARN-2707.v01.patch
>
>
> Here is related code in call():
> {code}
> Pattern pattern = null;
> String p = resource.getPattern();
> if (p != null) {
> pattern = Pattern.compile(p);
> }
> unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);
> {code}
> In unpack():
> {code}
> RunJar.unJar(localrsrc, dst, pattern);
> {code}
> unJar() would dereference the pattern without checking whether it is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2707) Potential null dereference in FSDownload
[
https://issues.apache.org/jira/browse/YARN-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193192#comment-14193192
]
Hudson commented on YARN-2707:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1919 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1919/])
YARN-2707. Potential null dereference in FSDownload. Contributed by Gera
Shegalov (jlowe: rev 7bc179f9f5e1e270fd5e6f1ad29b0f32fe371d15)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
> Potential null dereference in FSDownload
>
>
> Key: YARN-2707
> URL: https://issues.apache.org/jira/browse/YARN-2707
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: YARN-2707.v01.patch
>
>
> Here is related code in call():
> {code}
> Pattern pattern = null;
> String p = resource.getPattern();
> if (p != null) {
> pattern = Pattern.compile(p);
> }
> unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);
> {code}
> In unpack():
> {code}
> RunJar.unJar(localrsrc, dst, pattern);
> {code}
> unJar() would dereference the pattern without checking whether it is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2707) Potential null dereference in FSDownload
[
https://issues.apache.org/jira/browse/YARN-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193106#comment-14193106
]
Hudson commented on YARN-2707:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #730 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/730/])
YARN-2707. Potential null dereference in FSDownload. Contributed by Gera
Shegalov (jlowe: rev 7bc179f9f5e1e270fd5e6f1ad29b0f32fe371d15)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
> Potential null dereference in FSDownload
>
>
> Key: YARN-2707
> URL: https://issues.apache.org/jira/browse/YARN-2707
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: YARN-2707.v01.patch
>
>
> Here is related code in call():
> {code}
> Pattern pattern = null;
> String p = resource.getPattern();
> if (p != null) {
> pattern = Pattern.compile(p);
> }
> unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);
> {code}
> In unpack():
> {code}
> RunJar.unJar(localrsrc, dst, pattern);
> {code}
> unJar() would dereference the pattern without checking whether it is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2707) Potential null dereference in FSDownload
[
https://issues.apache.org/jira/browse/YARN-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192687#comment-14192687
]
Hudson commented on YARN-2707:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6415 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6415/])
YARN-2707. Potential null dereference in FSDownload. Contributed by Gera
Shegalov (jlowe: rev 7bc179f9f5e1e270fd5e6f1ad29b0f32fe371d15)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestFSDownload.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/FSDownload.java
* hadoop-yarn-project/CHANGES.txt
> Potential null dereference in FSDownload
>
>
> Key: YARN-2707
> URL: https://issues.apache.org/jira/browse/YARN-2707
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Gera Shegalov
>Priority: Minor
> Fix For: 2.6.0
>
> Attachments: YARN-2707.v01.patch
>
>
> Here is related code in call():
> {code}
> Pattern pattern = null;
> String p = resource.getPattern();
> if (p != null) {
> pattern = Pattern.compile(p);
> }
> unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);
> {code}
> In unpack():
> {code}
> RunJar.unJar(localrsrc, dst, pattern);
> {code}
> unJar() would dereference the pattern without checking whether it is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2707) Potential null dereference in FSDownload
[
https://issues.apache.org/jira/browse/YARN-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192663#comment-14192663
]
Jason Lowe commented on YARN-2707:
--
+1 lgtm. Committing this.
> Potential null dereference in FSDownload
>
>
> Key: YARN-2707
> URL: https://issues.apache.org/jira/browse/YARN-2707
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: YARN-2707.v01.patch
>
>
> Here is related code in call():
> {code}
> Pattern pattern = null;
> String p = resource.getPattern();
> if (p != null) {
> pattern = Pattern.compile(p);
> }
> unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);
> {code}
> In unpack():
> {code}
> RunJar.unJar(localrsrc, dst, pattern);
> {code}
> unJar() would dereference the pattern without checking whether it is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2707) Potential null dereference in FSDownload
[
https://issues.apache.org/jira/browse/YARN-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178026#comment-14178026
]
Hadoop QA commented on YARN-2707:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12676034/YARN-2707.v01.patch
against trunk revision 171f237.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5479//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5479//console
This message is automatically generated.
> Potential null dereference in FSDownload
>
>
> Key: YARN-2707
> URL: https://issues.apache.org/jira/browse/YARN-2707
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Gera Shegalov
>Priority: Minor
> Attachments: YARN-2707.v01.patch
>
>
> Here is related code in call():
> {code}
> Pattern pattern = null;
> String p = resource.getPattern();
> if (p != null) {
> pattern = Pattern.compile(p);
> }
> unpack(new File(dTmp.toUri()), new File(dFinal.toUri()), pattern);
> {code}
> In unpack():
> {code}
> RunJar.unJar(localrsrc, dst, pattern);
> {code}
> unJar() would dereference the pattern without checking whether it is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
