[jira] [Commented] (YARN-2731) RegisterApplicationMasterResponsePBImpl: not properly initialized builder

2015-01-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284553#comment-14284553
 ] 

Hadoop QA commented on YARN-2731:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12676492/YARN-2731.patch
  against trunk revision dd0228b.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6368//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6368//console

This message is automatically generated.

> RegisterApplicationMasterResponsePBImpl: not properly initialized builder
> -
>
> Key: YARN-2731
> URL: https://issues.apache.org/jira/browse/YARN-2731
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Carlo Curino
>Assignee: Carlo Curino
> Fix For: 2.7.0
>
> Attachments: YARN-2731.patch
>
>
> If I am not mistaken in RegisterApplicationMasterResponsePBImpl we are 
> missing to initialize the builder in  setNMTokensFromPreviousAttempts(), and 
> we initialize the builder in the wrong place in:  setClientToAMTokenMasterKey



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2731) RegisterApplicationMasterResponsePBImpl: not properly initialized builder

2015-01-20 Thread Wangda Tan (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284491#comment-14284491
 ] 

Wangda Tan commented on YARN-2731:
--

Good finding, [~curino]! LGTM, will commit once Jenkins get back.

> RegisterApplicationMasterResponsePBImpl: not properly initialized builder
> -
>
> Key: YARN-2731
> URL: https://issues.apache.org/jira/browse/YARN-2731
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Carlo Curino
>Assignee: Carlo Curino
> Fix For: 2.7.0
>
> Attachments: YARN-2731.patch
>
>
> If I am not mistaken in RegisterApplicationMasterResponsePBImpl we are 
> missing to initialize the builder in  setNMTokensFromPreviousAttempts(), and 
> we initialize the builder in the wrong place in:  setClientToAMTokenMasterKey



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2731) RegisterApplicationMasterResponsePBImpl: not properly initialized builder

2014-10-22 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180881#comment-14180881
 ] 

Hadoop QA commented on YARN-2731:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12676492/YARN-2731.patch
  against trunk revision f729ecf.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5510//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5510//console

This message is automatically generated.

> RegisterApplicationMasterResponsePBImpl: not properly initialized builder
> -
>
> Key: YARN-2731
> URL: https://issues.apache.org/jira/browse/YARN-2731
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Carlo Curino
>Assignee: Carlo Curino
> Fix For: 2.6.0
>
> Attachments: YARN-2731.patch
>
>
> If I am not mistaken in RegisterApplicationMasterResponsePBImpl we are 
> missing to initialize the builder in  setNMTokensFromPreviousAttempts(), and 
> we initialize the builder in the wrong place in:  setClientToAMTokenMasterKey



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2731) RegisterApplicationMasterResponsePBImpl: not properly initialized builder

2014-10-22 Thread Carlo Curino (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180837#comment-14180837
 ] 

Carlo Curino commented on YARN-2731:


Simple fix, invoking maybeInitBuilder() in setNMTokensFromPreviousAttempts() 
and moved it in setClientToAMTokenMasterKey... eyeballing the other methods 
they look ok, beside the invocation of maybeInitBuilder() in a getter: 
getClientToAMTokenMasterKey() which seems odd.

> RegisterApplicationMasterResponsePBImpl: not properly initialized builder
> -
>
> Key: YARN-2731
> URL: https://issues.apache.org/jira/browse/YARN-2731
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Carlo Curino
>Assignee: Carlo Curino
> Attachments: YARN-2731.patch
>
>
> If I am not mistaken in RegisterApplicationMasterResponsePBImpl we are 
> missing to initialize the builder in  setNMTokensFromPreviousAttempts(), and 
> we initialize the builder in the wrong place in:  setClientToAMTokenMasterKey



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)