[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233127#comment-14233127
]
Hudson commented on YARN-2894:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #24 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/24/])
YARN-2894. Fixed a bug regarding application view acl when RM fails over.
Contributed by Rohith Sharmaks (jianhe: rev
392c3aaea8e8f156b76e418157fa347256283c56)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DefaultSchedulerPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#r
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233112#comment-14233112
]
Hudson commented on YARN-2894:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1978 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1978/])
YARN-2894. Fixed a bug regarding application view acl when RM fails over.
Contributed by Rohith Sharmaks (jianhe: rev
392c3aaea8e8f156b76e418157fa347256283c56)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DefaultSchedulerPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render be
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233057#comment-14233057
]
Hudson commented on YARN-2894:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #24 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/24/])
YARN-2894. Fixed a bug regarding application view acl when RM fails over.
Contributed by Rohith Sharmaks (jianhe: rev
392c3aaea8e8f156b76e418157fa347256283c56)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DefaultSchedulerPage.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render belo
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233041#comment-14233041
]
Hudson commented on YARN-2894:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1955 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1955/])
YARN-2894. Fixed a bug regarding application view acl when RM fails over.
Contributed by Rohith Sharmaks (jianhe: rev
392c3aaea8e8f156b76e418157fa347256283c56)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DefaultSchedulerPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232913#comment-14232913
]
Hudson commented on YARN-2894:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #24 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/24/])
YARN-2894. Fixed a bug regarding application view acl when RM fails over.
Contributed by Rohith Sharmaks (jianhe: rev
392c3aaea8e8f156b76e418157fa347256283c56)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DefaultSchedulerPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render belo
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232900#comment-14232900
]
Hudson commented on YARN-2894:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #763 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/763/])
YARN-2894. Fixed a bug regarding application view acl when RM fails over.
Contributed by Rohith Sharmaks (jianhe: rev
392c3aaea8e8f156b76e418157fa347256283c56)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DefaultSchedulerPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check ma
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232427#comment-14232427
]
Hudson commented on YARN-2894:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6635 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6635/])
YARN-2894. Fixed a bug regarding application view acl when RM fails over.
Contributed by Rohith Sharmaks (jianhe: rev
392c3aaea8e8f156b76e418157fa347256283c56)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesFairScheduler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodeLabels.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesDelegationTokens.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/DefaultSchedulerPage.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/MetricsOverviewTable.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebApp.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below ch
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232151#comment-14232151
]
Jian He commented on YARN-2894:
---
looks good, +1
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231076#comment-14231076
]
Hadoop QA commented on YARN-2894:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12684562/YARN-2894.1.patch
against trunk revision 9fa2990.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5970//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5970//console
This message is automatically generated.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231028#comment-14231028
]
Rohith commented on YARN-2894:
--
Updated the patch with following changes.
# Removed the binding of RMContext ,aclManager and queueAclManager in RMWebApp
and other test cases.
# Did clean up where both RM instance and RMContext instance were passed to
{{MetricsOverviewTable}} {{ClusterMetricsInfo}} {{UserMetricsInfo}} classes
which never used. I do not think it breaks compatability. What do you think?
# I ran test locally which all are passing. But many tests failed in previous
QA result because of reason "address bind exception". I am analyzing it, will
fix in another jira.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.1.patch, YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231016#comment-14231016
]
Rohith commented on YARN-2894:
--
It is around 18 classes to be changed. However I have done changes. Will upload
patch soon
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230986#comment-14230986
]
Jian He commented on YARN-2894:
---
bq. The changes are very big for getting RMContext from rm object
How big that can be ? I'm fine to stay as is, if that's too big change.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230919#comment-14230919
]
Rohith commented on YARN-2894:
--
The changes are very big for getting RMContext from rm object. Given for
future-proof, I will change it.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230880#comment-14230880
]
Rohith commented on YARN-2894:
--
bq. Could you also check if binding to RMContext has similar problem ? It seems
fine to me
This particular scenario I verified. This will not cuase any problem since
RMContext created per JVM and activeservice instaces are updated.
bq. we can also getRMContext from the rm object for future-proof
Agree.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230425#comment-14230425
]
Hadoop QA commented on YARN-2894:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683865/YARN-2894.patch
against trunk revision c732ed7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels
org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5961//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5961//console
This message is automatically generated.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230345#comment-14230345
]
Jian He commented on YARN-2894:
---
Minor comment: unused imports in RMWebApp.java
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230341#comment-14230341
]
Jian He commented on YARN-2894:
---
make sense. patch looks good.
Could you also check if binding to RMContext has similar problem ? It seems
fine to me. Or we can also getRMContext from the rm object for future-proof.
{{bind(RMContext.class).toInstance(rm.getRMContext());}}
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226540#comment-14226540
]
Hadoop QA commented on YARN-2894:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683865/YARN-2894.patch
against trunk revision aa7dac3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestRM
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5946//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5946//console
This message is automatically generated.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226406#comment-14226406
]
Rohith commented on YARN-2894:
--
Attached patch without test. Did not get much idea how to write test for RMWeb
in RMHA. I have verified fix manually testing. It is working fine. Kindly
review.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
> Attachments: YARN-2894.patch
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224855#comment-14224855
]
Rohith commented on YARN-2894:
--
The fix for the issue is
1. Do not inject aclManager and queueAclManger instances rather make use of
ResourceManger instance to get aclManager and queueAclManager which always get
ActiveService instance
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224851#comment-14224851
]
Rohith commented on YARN-2894:
--
The problem is due to RMWebApp is started and kept for thought jvm life time
nevertheless of RM state change to active or standby. For AppBlock rendering ,
aclManager and queueAclManager instance are injected at the time of web service
start for checkAccess users per application. {{aclManager}} does not find the
application id in its and throw NPE. For the user, web page can not be
accessible.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2894) When ACL's are enabled, if RM switches then application can not be viewed from web.
[
https://issues.apache.org/jira/browse/YARN-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224844#comment-14224844
]
Rohith commented on YARN-2894:
--
Consider scenario in following
1. Yarn RM HA cluster is started with enabling ACL's. RM is in Active state.
2. Submit yarn application(app1), access this application from RM web ui.User
is able to view the app1
3. Do transition ACTIVE --> STANDBY --> ACTIVE.
4. Submit another yarn application(app2). Try to access app2 link from RM web
UI. It can not be viewed and throw NPE at RM log.
> When ACL's are enabled, if RM switches then application can not be viewed
> from web.
> ---
>
> Key: YARN-2894
> URL: https://issues.apache.org/jira/browse/YARN-2894
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Rohith
>Assignee: Rohith
> Fix For: 2.7.0
>
>
> Binding aclManager to RMWebApp would cause problem if RM is switched. There
> could be some validation check may fail.
> I think , we should not bind aclManager for RMWebApp, instead we should get
> from RM instance.
> In RMWebApp,
> {code}
> if (rm != null) {
> bind(ResourceManager.class).toInstance(rm);
> bind(RMContext.class).toInstance(rm.getRMContext());
> bind(ApplicationACLsManager.class).toInstance(
> rm.getApplicationACLsManager());
> bind(QueueACLsManager.class).toInstance(rm.getQueueACLsManager());
> }
> {code}
> and in AppBlock#render below check may fail(Need to test and confirm)
> {code}
>if (callerUGI != null
> && !(this.aclsManager.checkAccess(callerUGI,
> ApplicationAccessType.VIEW_APP, app.getUser(), appID) ||
> this.queueACLsManager.checkAccess(callerUGI,
> QueueACL.ADMINISTER_QUEUE, app.getQueue( {
> puts("You (User " + remoteUser
> + ") are not authorized to view application " + appID);
> return;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
