[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262251#comment-14262251 ] Hudson commented on YARN-2987: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2009 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2009/]) YARN-2987. Fixed ClientRMService#getQueueInfo to check against queue and app ACLs. Contributed by Varun Saxena (jianhe: rev e2351c7ae24cea9b217af4174512d279c55e8efd) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * hadoop-yarn-project/CHANGES.txt > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262241#comment-14262241 ] Hudson commented on YARN-2987: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #59 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/59/]) YARN-2987. Fixed ClientRMService#getQueueInfo to check against queue and app ACLs. Contributed by Varun Saxena (jianhe: rev e2351c7ae24cea9b217af4174512d279c55e8efd) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * hadoop-yarn-project/CHANGES.txt > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262220#comment-14262220 ] Hudson commented on YARN-2987: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #55 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/55/]) YARN-2987. Fixed ClientRMService#getQueueInfo to check against queue and app ACLs. Contributed by Varun Saxena (jianhe: rev e2351c7ae24cea9b217af4174512d279c55e8efd) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262205#comment-14262205 ] Hudson commented on YARN-2987: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1990 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1990/]) YARN-2987. Fixed ClientRMService#getQueueInfo to check against queue and app ACLs. Contributed by Varun Saxena (jianhe: rev e2351c7ae24cea9b217af4174512d279c55e8efd) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262096#comment-14262096 ] Hudson commented on YARN-2987: -- FAILURE: Integrated in Hadoop-Yarn-trunk #792 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/792/]) YARN-2987. Fixed ClientRMService#getQueueInfo to check against queue and app ACLs. Contributed by Varun Saxena (jianhe: rev e2351c7ae24cea9b217af4174512d279c55e8efd) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262091#comment-14262091 ] Hudson commented on YARN-2987: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #58 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/58/]) YARN-2987. Fixed ClientRMService#getQueueInfo to check against queue and app ACLs. Contributed by Varun Saxena (jianhe: rev e2351c7ae24cea9b217af4174512d279c55e8efd) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261769#comment-14261769 ] Hudson commented on YARN-2987: -- FAILURE: Integrated in Hadoop-trunk-Commit #6798 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6798/]) YARN-2987. Fixed ClientRMService#getQueueInfo to check against queue and app ACLs. Contributed by Varun Saxena (jianhe: rev e2351c7ae24cea9b217af4174512d279c55e8efd) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Fix For: 2.7.0 > > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261259#comment-14261259 ] Varun Saxena commented on YARN-2987: [~jianhe], test failure is unrelated. Passing in my local > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[
https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260662#comment-14260662
]
Hadoop QA commented on YARN-2987:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689406/YARN-2987.002.patch
against trunk revision 249cc90.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
The following test timeouts occurred in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6209//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6209//console
This message is automatically generated.
> ClientRMService#getQueueInfo doesn't check app ACLs
> ---
>
> Key: YARN-2987
> URL: https://issues.apache.org/jira/browse/YARN-2987
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jian He
>Assignee: Varun Saxena
> Attachments: YARN-2987.001.patch, YARN-2987.002.patch
>
>
> ClientRMService#getQueueInfo can return a list of applications belonging to
> the queue, but doesn't actually check if the user has the permission to view
> the applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260602#comment-14260602 ] Jian He commented on YARN-2987: --- looks good, +1 > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260576#comment-14260576 ] Varun Saxena commented on YARN-2987: bq. could you add a test case that a non-authorized user not able to get the application report ? [~jianhe], added the case. Kindly review. > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Attachments: YARN-2987.001.patch, YARN-2987.002.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260457#comment-14260457 ] Jian He commented on YARN-2987: --- looks good overall, could you add a test case that a non-authorized user not able to get the application report ? > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Attachments: YARN-2987.001.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260430#comment-14260430 ] Varun Saxena commented on YARN-2987: [~jianhe] / [~zjshen], kindly review > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > Attachments: YARN-2987.001.patch > > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[
https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259297#comment-14259297
]
Hadoop QA commented on YARN-2987:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689209/YARN-2987.001.patch
against trunk revision 1454efe.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 15 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6197//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6197//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6197//console
This message is automatically generated.
> ClientRMService#getQueueInfo doesn't check app ACLs
> ---
>
> Key: YARN-2987
> URL: https://issues.apache.org/jira/browse/YARN-2987
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jian He
>Assignee: Varun Saxena
> Attachments: YARN-2987.001.patch
>
>
> ClientRMService#getQueueInfo can return a list of applications belonging to
> the queue, but doesn't actually check if the user has the permission to view
> the applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2987) ClientRMService#getQueueInfo doesn't check app ACLs
[ https://issues.apache.org/jira/browse/YARN-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257685#comment-14257685 ] Zhijie Shen commented on YARN-2987: --- Queue ACLs needs to be checked too. > ClientRMService#getQueueInfo doesn't check app ACLs > --- > > Key: YARN-2987 > URL: https://issues.apache.org/jira/browse/YARN-2987 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Varun Saxena > > ClientRMService#getQueueInfo can return a list of applications belonging to > the queue, but doesn't actually check if the user has the permission to view > the applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
