[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-07 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267991#comment-14267991 ] Zhijie Shen commented on YARN-2996: --- Almost good to me. Just one nit: can we reuse getFil

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267388#comment-14267388 ] Hadoop QA commented on YARN-2996: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-06 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267322#comment-14267322 ] Zhijie Shen commented on YARN-2996: --- My bad. I mean MemoryRMStateStore#updateRMDelegation

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-06 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267065#comment-14267065 ] Yi Liu commented on YARN-2996: -- Yes, Zhijie {quote} Good catch! It seems that MemoryRMStateSt

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-06 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266536#comment-14266536 ] Zhijie Shen commented on YARN-2996: --- bq. we missed synchronized for updateRMDelegationTok

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-06 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265835#comment-14265835 ] Yi Liu commented on YARN-2996: -- Test failure and findbugs are not related. > Refine some fs o

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265760#comment-14265760 ] Hadoop QA commented on YARN-2996: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-05 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265707#comment-14265707 ] Yi Liu commented on YARN-2996: -- Thanks [~zjshen] for review. You are right, for *.new* and *.t

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-05 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264901#comment-14264901 ] Zhijie Shen commented on YARN-2996: --- bq. we can merge them to save one RPC call It sound

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2015-01-03 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263743#comment-14263743 ] Yi Liu commented on YARN-2996: -- The 3 tests failures are not related. > Refine some fs operat

[jira] [Commented] (YARN-2996) Refine some fs operations in FileSystemRMStateStore to improve performance

2014-12-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260891#comment-14260891 ] Hadoop QA commented on YARN-2996: - {color:red}-1 overall{color}. Here are the results of t