[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503551#comment-14503551
]
Junping Du commented on YARN-3046:
--
Thanks [~sjlee0] for review and comments!
bq. So am I
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503175#comment-14503175
]
Junping Du commented on YARN-3046:
--
bq. Shall we do nullcheck in TimelineEvent.
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503133#comment-14503133
]
Zhijie Shen commented on YARN-3046:
---
Another issue:
Shall we do nullcheck in
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503363#comment-14503363
]
Sangjin Lee commented on YARN-3046:
---
Sorry my review is late for this [~djp]!
Some high
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500037#comment-14500037
]
Junping Du commented on YARN-3046:
--
Thanks [~rkanter] and [~zjshen] for review and
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500998#comment-14500998
]
Zhijie Shen commented on YARN-3046:
---
In the new patch, the task entity ID is set
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501015#comment-14501015
]
Junping Du commented on YARN-3046:
--
bq. In the new patch, the task entity ID is set
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497872#comment-14497872
]
Junping Du commented on YARN-3046:
--
Hi [~zjshen] and [~rkanter], any comments on latest
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499087#comment-14499087
]
Robert Kanter commented on YARN-3046:
-
LGTM +1
But let's wait on any additional
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494233#comment-14494233
]
Junping Du commented on YARN-3046:
--
Thanks [~zjshen] for review and comments!
bq. I'm not
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495534#comment-14495534
]
Junping Du commented on YARN-3046:
--
Also, verify end-to-end test for putting MR history
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495462#comment-14495462
]
Robert Kanter commented on YARN-3046:
-
Sure, another JIRA sounds fine.
[Event
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495191#comment-14495191
]
Junping Du commented on YARN-3046:
--
Thanks [~rkanter] for review and comments!
bq. I think
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495097#comment-14495097
]
Robert Kanter commented on YARN-3046:
-
I think something that really hasn't been
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492823#comment-14492823
]
Zhijie Shen commented on YARN-3046:
---
Junping, thanks for the patch. Overall it looks good
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483588#comment-14483588
]
Junping Du commented on YARN-3046:
--
Linked with MAPREDUCE-6189 - the test failure on trunk
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393089#comment-14393089
]
Junping Du commented on YARN-3046:
--
Also, looks like no YARN changes get involved in this
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391142#comment-14391142
]
Junping Du commented on YARN-3046:
--
Hi [~rkanter], as I mentioned offline early, can I
[
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391436#comment-14391436
]
Junping Du commented on YARN-3046:
--
Thanks [~rkanter]! I will try to deliver a patch soon.
19 matches
Mail list logo