[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-20 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503551#comment-14503551 ] Junping Du commented on YARN-3046: -- Thanks [~sjlee0] for review and comments! bq. So am I

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-20 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503175#comment-14503175 ] Junping Du commented on YARN-3046: -- bq. Shall we do nullcheck in TimelineEvent.

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-20 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503133#comment-14503133 ] Zhijie Shen commented on YARN-3046: --- Another issue: Shall we do nullcheck in

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-20 Thread Sangjin Lee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14503363#comment-14503363 ] Sangjin Lee commented on YARN-3046: --- Sorry my review is late for this [~djp]! Some high

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-17 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500037#comment-14500037 ] Junping Du commented on YARN-3046: -- Thanks [~rkanter] and [~zjshen] for review and

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-17 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500998#comment-14500998 ] Zhijie Shen commented on YARN-3046: --- In the new patch, the task entity ID is set

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-17 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501015#comment-14501015 ] Junping Du commented on YARN-3046: -- bq. In the new patch, the task entity ID is set

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-16 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497872#comment-14497872 ] Junping Du commented on YARN-3046: -- Hi [~zjshen] and [~rkanter], any comments on latest

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-16 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499087#comment-14499087 ] Robert Kanter commented on YARN-3046: - LGTM +1 But let's wait on any additional

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-14 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494233#comment-14494233 ] Junping Du commented on YARN-3046: -- Thanks [~zjshen] for review and comments! bq. I'm not

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-14 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495534#comment-14495534 ] Junping Du commented on YARN-3046: -- Also, verify end-to-end test for putting MR history

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-14 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495462#comment-14495462 ] Robert Kanter commented on YARN-3046: - Sure, another JIRA sounds fine. [Event

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-14 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495191#comment-14495191 ] Junping Du commented on YARN-3046: -- Thanks [~rkanter] for review and comments! bq. I think

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-14 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14495097#comment-14495097 ] Robert Kanter commented on YARN-3046: - I think something that really hasn't been

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-13 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492823#comment-14492823 ] Zhijie Shen commented on YARN-3046: --- Junping, thanks for the patch. Overall it looks good

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-07 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483588#comment-14483588 ] Junping Du commented on YARN-3046: -- Linked with MAPREDUCE-6189 - the test failure on trunk

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-02 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393089#comment-14393089 ] Junping Du commented on YARN-3046: -- Also, looks like no YARN changes get involved in this

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-01 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391142#comment-14391142 ] Junping Du commented on YARN-3046: -- Hi [~rkanter], as I mentioned offline early, can I

[jira] [Commented] (YARN-3046) [Event producers] Implement MapReduce AM writing some MR metrics to ATS

2015-04-01 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391436#comment-14391436 ] Junping Du commented on YARN-3046: -- Thanks [~rkanter]! I will try to deliver a patch soon.