[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289379#comment-14289379 ] Hudson commented on YARN-3082: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2033 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2033/]) YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot. (ozawa: rev 3aab354e664a3ce09e0d638bf0c1e7d273d40579) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289344#comment-14289344 ] Hudson commented on YARN-3082: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #83 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/83/]) YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot. (ozawa: rev 3aab354e664a3ce09e0d638bf0c1e7d273d40579) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289281#comment-14289281 ] Hudson commented on YARN-3082: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #79 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/79/]) YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot. (ozawa: rev 3aab354e664a3ce09e0d638bf0c1e7d273d40579) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289187#comment-14289187 ] Hudson commented on YARN-3082: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2014 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2014/]) YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot. (ozawa: rev 3aab354e664a3ce09e0d638bf0c1e7d273d40579) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java * hadoop-yarn-project/CHANGES.txt > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289109#comment-14289109 ] Hudson commented on YARN-3082: -- FAILURE: Integrated in Hadoop-Yarn-trunk #816 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/816/]) YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot. (ozawa: rev 3aab354e664a3ce09e0d638bf0c1e7d273d40579) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java * hadoop-yarn-project/CHANGES.txt > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289073#comment-14289073 ] Hudson commented on YARN-3082: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #82 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/82/]) YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot. (ozawa: rev 3aab354e664a3ce09e0d638bf0c1e7d273d40579) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288890#comment-14288890 ] Hudson commented on YARN-3082: -- FAILURE: Integrated in Hadoop-trunk-Commit #6916 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6916/]) YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot. (ozawa: rev 3aab354e664a3ce09e0d638bf0c1e7d273d40579) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NodeHeartbeatResponsePBImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1423#comment-1423 ] Tsuyoshi OZAWA commented on YARN-3082: -- Committing this to trunk and branch-2. Thanks [~adhoot] for your report and contribution. > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[ https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1420#comment-1420 ] Tsuyoshi OZAWA commented on YARN-3082: -- +1 > Non thread safe access to systemCredentials in NodeHeartbeatResponse > processing > --- > > Key: YARN-3082 > URL: https://issues.apache.org/jira/browse/YARN-3082 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3082.001.patch, YARN-3082.002.patch > > > When you use system credentials via feature added in YARN-2704, the proto > conversion code throws exception in converting ByteBuffer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[
https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288099#comment-14288099
]
Hadoop QA commented on YARN-3082:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12693959/YARN-3082.002.patch
against trunk revision 825923f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6390//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6390//console
This message is automatically generated.
> Non thread safe access to systemCredentials in NodeHeartbeatResponse
> processing
> ---
>
> Key: YARN-3082
> URL: https://issues.apache.org/jira/browse/YARN-3082
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Anubhav Dhoot
>Assignee: Anubhav Dhoot
> Attachments: YARN-3082.001.patch, YARN-3082.002.patch
>
>
> When you use system credentials via feature added in YARN-2704, the proto
> conversion code throws exception in converting ByteBuffer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[
https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287117#comment-14287117
]
Hadoop QA commented on YARN-3082:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12693790/YARN-3082.001.patch
against trunk revision 786dbdf.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6385//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6385//console
This message is automatically generated.
> Non thread safe access to systemCredentials in NodeHeartbeatResponse
> processing
> ---
>
> Key: YARN-3082
> URL: https://issues.apache.org/jira/browse/YARN-3082
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Anubhav Dhoot
>Assignee: Anubhav Dhoot
> Attachments: YARN-3082.001.patch
>
>
> When you use system credentials via feature added in YARN-2704, the proto
> conversion code throws exception in converting ByteBuffer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[
https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287095#comment-14287095
]
Tsuyoshi OZAWA commented on YARN-3082:
--
Looks good to me overall. Minor nits:
{code}
+}
+finally {
+ threadPool.shutdownNow();
{code}
This finally statement should be moved after a brace in the line like this:
{code}
} finally {
threadPool.shutdownNow();
{code}
> Non thread safe access to systemCredentials in NodeHeartbeatResponse
> processing
> ---
>
> Key: YARN-3082
> URL: https://issues.apache.org/jira/browse/YARN-3082
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Anubhav Dhoot
>Assignee: Anubhav Dhoot
> Attachments: YARN-3082.001.patch
>
>
> When you use system credentials via feature added in YARN-2704, the proto
> conversion code throws exception in converting ByteBuffer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3082) Non thread safe access to systemCredentials in NodeHeartbeatResponse processing
[
https://issues.apache.org/jira/browse/YARN-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286860#comment-14286860
]
Anubhav Dhoot commented on YARN-3082:
-
We have seen examples with running on a secure cluster,
{noformat}
2014-12-09 11:22:57,540 ERROR
org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Caught
exception in status-updater
org.apache.hadoop.ipc.RemoteException(java.nio.BufferUnderflowException):
java.nio.BufferUnderflowException
at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:145)
at java.nio.ByteBuffer.get(ByteBuffer.java:694)
at com.google.protobuf.ByteString.copyFrom(ByteString.java:217)
at com.google.protobuf.ByteString.copyFrom(ByteString.java:229)
at
org.apache.hadoop.yarn.api.records.impl.pb.ProtoUtils.convertToProtoFormat(ProtoUtils.java:195)
at
org.apache.hadoop.yarn.server.api.protocolrecords.impl.pb.NodeHeartbeatResponsePBImpl.addSystemCredentialsToProto(NodeHeartbeatResponsePBImpl.java:105)
at
org.apache.hadoop.yarn.server.api.protocolrecords.impl.pb.NodeHeartbeatResponsePBImpl.mergeLocalToBuilder(NodeHeartbeatResponsePBImpl.java:97)
at
org.apache.hadoop.yarn.server.api.protocolrecords.impl.pb.NodeHeartbeatResponsePBImpl.mergeLocalToProto(NodeHeartbeatResponsePBImpl.java:114)
at
org.apache.hadoop.yarn.server.api.protocolrecords.impl.pb.NodeHeartbeatResponsePBImpl.getProto(NodeHeartbeatResponsePBImpl.java:72)
at
org.apache.hadoop.yarn.server.api.impl.pb.service.ResourceTrackerPBServiceImpl.nodeHeartbeat(ResourceTrackerPBServiceImpl.java:69)
{noformat}
> Non thread safe access to systemCredentials in NodeHeartbeatResponse
> processing
> ---
>
> Key: YARN-3082
> URL: https://issues.apache.org/jira/browse/YARN-3082
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Anubhav Dhoot
>Assignee: Anubhav Dhoot
>
> When you use system credentials via feature added in YARN-2704, the proto
> conversion code throws exception in converting ByteBuffer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
