[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1760#comment-1760
]
Wangda Tan commented on YARN-3139:
--
Thanks [~asuresh] and [~jianhe] for review and commit!
> Improve
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550275#comment-15550275
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547212#comment-15547212
]
Hudson commented on YARN-3139:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10542 (See
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544092#comment-15544092
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543868#comment-15543868
]
Jian He commented on YARN-3139:
---
latest patch looks good
> Improve locks in
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543810#comment-15543810
]
Wangda Tan commented on YARN-3139:
--
[~templedf],
Do you have chance to look at the latest patch?
Thanks
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531876#comment-15531876
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529409#comment-15529409
]
Jian He commented on YARN-3139:
---
Patch looks good to me.
bq. Instead of taking readLock, I think we can
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527604#comment-15527604
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527489#comment-15527489
]
Wangda Tan commented on YARN-3139:
--
[~templedf],
bq. but there are a large number of line break changes
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527279#comment-15527279
]
Daniel Templeton commented on YARN-3139:
I've started reviewing the patch, but there are a large
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525475#comment-15525475
]
Jian He commented on YARN-3139:
---
- I remember previous intention was trying avoid lock. Instead of taking
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523993#comment-15523993
]
Wangda Tan commented on YARN-3139:
--
Test failure is not related.
> Improve locks in
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518191#comment-15518191
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517555#comment-15517555
]
Arun Suresh commented on YARN-3139:
---
Thanks for addressing the comments [~leftnoteasy]
w.r.t to the
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517520#comment-15517520
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517172#comment-15517172
]
Wangda Tan commented on YARN-3139:
--
Thanks [~asuresh] for the review, actually I'm working on the patch :)
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517073#comment-15517073
]
Arun Suresh commented on YARN-3139:
---
Thanks for the patch [~templedf]..
AbstractYarnScheduler:
#
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513883#comment-15513883
]
Karthik Kambatla commented on YARN-3139:
Sorry [~leftnoteasy]. I will be traveling and won't have a
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513827#comment-15513827
]
Wangda Tan commented on YARN-3139:
--
Thanks [~templedf], but I really want to get this done sooner as it
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513822#comment-15513822
]
Wangda Tan commented on YARN-3139:
--
[~ozawa],
Yeah we plan to add multi-threading scheduling
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513815#comment-15513815
]
Wangda Tan commented on YARN-3139:
--
Actually we need to hold application's lock when this is called. Will
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513717#comment-15513717
]
Daniel Templeton commented on YARN-3139:
Yep. I added it to my todo list, but I won't get there
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513703#comment-15513703
]
Tsuyoshi Ozawa commented on YARN-3139:
--
[~leftnoteasy] [~jianhe] thanks for taking this issue.
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513402#comment-15513402
]
Jian He commented on YARN-3139:
---
There are also similar comments like this... I just couldn't remember why
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513416#comment-15513416
]
Jian He commented on YARN-3139:
---
May be it's related to some consistency issues with respect to queue stats？
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513407#comment-15513407
]
Jian He commented on YARN-3139:
---
[~templedf], would you like to check the FairScheduler changes?
> Improve
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511346#comment-15511346
]
Wangda Tan commented on YARN-3139:
--
Failed tests aren't related to this changes, YARN-5548/YARN-5349 are
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1555#comment-1555
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510954#comment-15510954
]
Wangda Tan commented on YARN-3139:
--
Thanks [~jianhe] for review:
bq. Is removing these locks ok?..
The
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509412#comment-15509412
]
Jian He commented on YARN-3139:
---
- Is removing these locks ok?
{code}
// It is crucial to acquire leaf
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508947#comment-15508947
]
Wangda Tan commented on YARN-3139:
--
[~jianhe], [~kasha], [~templedf], could you take a look at the patch?
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508902#comment-15508902
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508019#comment-15508019
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491678#comment-15491678
]
Wangda Tan commented on YARN-3139:
--
I just tried to use SLS to benchmark the performance after applied
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488730#comment-15488730
]
Hadoop QA commented on YARN-3139:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530272#comment-14530272
]
Xianyin Xin commented on YARN-3139:
---
Any progress? or any plans?
Improve locks in
37 matches
Mail list logo
