[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317868#comment-14317868
]
Tsuyoshi OZAWA commented on YARN-3157:
--
+1
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.1.patch, YARN-3157.2.patch, YARN-3157.patch,
> YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317572#comment-14317572
]
Hadoop QA commented on YARN-3157:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698285/YARN-3157.2.patch
against trunk revision 67efab9.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6606//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6606//console
This message is automatically generated.
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.1.patch, YARN-3157.2.patch, YARN-3157.patch,
> YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317419#comment-14317419
]
Tsuyoshi OZAWA commented on YARN-3157:
--
[~bibinchundatt] thank you for updating. Could you check and update the
indentation in following lines too?
{code}
public static ContainerId toContainerId(String containerIdStr) {
-return ContainerId.fromString(containerIdStr);
+ try {
+return ContainerId.fromString(containerIdStr);
+ } catch (NoSuchElementException e){
+ throw new IllegalArgumentException("Invalid ContainerId: "
+ + containerIdStr, e);
+ }
}
{code}
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.1.patch, YARN-3157.patch, YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315778#comment-14315778
]
Hadoop QA commented on YARN-3157:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12697985/YARN-3157.1.patch
against trunk revision 7c6b654.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6589//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6589//console
This message is automatically generated.
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.1.patch, YARN-3157.patch, YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314718#comment-14314718
]
Hadoop QA commented on YARN-3157:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12697492/YARN-3157.patch
against trunk revision 3f5431a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6581//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6581//console
This message is automatically generated.
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.patch, YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314583#comment-14314583
]
Tsuyoshi OZAWA commented on YARN-3157:
--
[~bibinchundatt], change itself looks good to me.
Minor nits: could you pudate indentation in a patch? Tab and spaces look
mixing: please use 2 spaces.
http://wiki.apache.org/hadoop/HowToContribute#Making_Changes
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.patch, YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312161#comment-14312161
]
Bibin A Chundatt commented on YARN-3157:
Naga, Thank you for the comment. I had missed container check will add that too
{quote}
public static ContainerId toContainerId(String containerIdStr)
return ContainerId.fromString(containerIdStr);
{quote}
Need to add catch block here too.
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312129#comment-14312129
]
Tsuyoshi OZAWA commented on YARN-3157:
--
Bibin, thank you for taknig this JIRA. Yes, I'll check it since I'd like to
look at the patch before committing.
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3157) Wrong format for application id / attempt id not handled completely
[
https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312068#comment-14312068
]
Naganarasimha G R commented on YARN-3157:
-
Hi [~bibinchundatt],
Thanks for raising this issue , its good to have a proper error message on
improper input than having some stack trace,
* can you also add some test code for the same
* Need to do the same check for container id too.
* may be modify title "Better Error message handling for invalid application
id or attempt id or container Id" (in these lines)
> Wrong format for application id / attempt id not handled completely
> ---
>
> Key: YARN-3157
> URL: https://issues.apache.org/jira/browse/YARN-3157
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.6.0
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Minor
> Attachments: YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to
> console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop
> library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
> at
> com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
> at
> org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
> at
> org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
