[jira] [Commented] (YARN-3183) Some classes define hashcode() but not equals()

2015-02-12 Thread Rohith (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318776#comment-14318776 ] Rohith commented on YARN-3183: -- I'd suggest for returning 0 in hashCode() if null. > Some cla

[jira] [Commented] (YARN-3183) Some classes define hashcode() but not equals()

2015-02-12 Thread Robert Kanter (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318719#comment-14318719 ] Robert Kanter commented on YARN-3183: - That's a good point, though I'm not sure what we

[jira] [Commented] (YARN-3183) Some classes define hashcode() but not equals()

2015-02-11 Thread Rohith (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317582#comment-14317582 ] Rohith commented on YARN-3183: -- Thanks for providing patch!! It looks good to me overall. In a

[jira] [Commented] (YARN-3183) Some classes define hashcode() but not equals()

2015-02-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317564#comment-14317564 ] Hadoop QA commented on YARN-3183: - {color:red}-1 overall{color}. Here are the results of t