[jira] [Commented] (YARN-3256) TestClientToAMToken#testClientTokenRace is not running against all Schedulers even when using ParameterizedSchedulerTestBase
[ https://issues.apache.org/jira/browse/YARN-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338174#comment-14338174 ] Devaraj K commented on YARN-3256: - +1, lgtm, will commit it shortly. > TestClientToAMToken#testClientTokenRace is not running against all Schedulers > even when using ParameterizedSchedulerTestBase > > > Key: YARN-3256 > URL: https://issues.apache.org/jira/browse/YARN-3256 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3256.001.patch > > > The test testClientTokenRace was not using the base class conf causing it to > run twice on the same Scheduler configured in the default. > All tests deriving from ParameterizedSchedulerTestBase should use the conf > created in the base class instead of newing up inside the test and hiding the > member. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3256) TestClientToAMToken#testClientTokenRace is not running against all Schedulers even when using ParameterizedSchedulerTestBase
[
https://issues.apache.org/jira/browse/YARN-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336370#comment-14336370
]
Hadoop QA commented on YARN-3256:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12700710/YARN-3256.001.patch
against trunk revision ad8ed3e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6729//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6729//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6729//console
This message is automatically generated.
> TestClientToAMToken#testClientTokenRace is not running against all Schedulers
> even when using ParameterizedSchedulerTestBase
>
>
> Key: YARN-3256
> URL: https://issues.apache.org/jira/browse/YARN-3256
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Anubhav Dhoot
>Assignee: Anubhav Dhoot
> Attachments: YARN-3256.001.patch
>
>
> The test testClientTokenRace was not using the base class conf causing it to
> run twice on the same Scheduler configured in the default.
> All tests deriving from ParameterizedSchedulerTestBase should use the conf
> created in the base class instead of newing up inside the test and hiding the
> member.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3256) TestClientToAMToken#testClientTokenRace is not running against all Schedulers even when using ParameterizedSchedulerTestBase
[ https://issues.apache.org/jira/browse/YARN-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336333#comment-14336333 ] Rohith commented on YARN-3256: -- Good catch!! +1(non-binding) lgtm > TestClientToAMToken#testClientTokenRace is not running against all Schedulers > even when using ParameterizedSchedulerTestBase > > > Key: YARN-3256 > URL: https://issues.apache.org/jira/browse/YARN-3256 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Anubhav Dhoot >Assignee: Anubhav Dhoot > Attachments: YARN-3256.001.patch > > > The test testClientTokenRace was not using the base class conf causing it to > run twice on the same Scheduler configured in the default. > All tests deriving from ParameterizedSchedulerTestBase should use the conf > created in the base class instead of newing up inside the test and hiding the > member. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
