[jira] [Commented] (YARN-3330) Implement a protobuf compatibility checker to check if a patch breaks the compatibility with existing client and internal protocols

2015-03-12 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358792#comment-14358792
 ] 

Allen Wittenauer commented on YARN-3330:


This shouldn't be yarn specific.  I'd HIGHLY recommend bumping this up to a 
full issue into the HADOOP project so that:

a) goes into common

b) has higher visibility

 Implement a protobuf compatibility checker to check if a patch breaks the 
 compatibility with existing client and internal protocols
 ---

 Key: YARN-3330
 URL: https://issues.apache.org/jira/browse/YARN-3330
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Li Lu
Assignee: Li Lu
 Attachments: pdiff_patch.py


 Per YARN-3292, we may want to start YARN rolling upgrade test compatibility 
 verification tool by a simple script to check protobuf compatibility. The 
 script may work on incoming patch files, check if there are any changes to 
 protobuf files, and report any potentially incompatible changes (line 
 removals, etc,.). We may want the tool to be conservative: it may report 
 false positives, but we should minimize its chance to have false negatives. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3330) Implement a protobuf compatibility checker to check if a patch breaks the compatibility with existing client and internal protocols

2015-03-12 Thread Li Lu (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359254#comment-14359254
 ] 

Li Lu commented on YARN-3330:
-

Hi [~aw], thanks for the suggestion! I will definitely bump this up after I 
finished the two issues raised above. 

 Implement a protobuf compatibility checker to check if a patch breaks the 
 compatibility with existing client and internal protocols
 ---

 Key: YARN-3330
 URL: https://issues.apache.org/jira/browse/YARN-3330
 Project: Hadoop YARN
  Issue Type: Sub-task
Reporter: Li Lu
Assignee: Li Lu
 Attachments: pdiff_patch.py


 Per YARN-3292, we may want to start YARN rolling upgrade test compatibility 
 verification tool by a simple script to check protobuf compatibility. The 
 script may work on incoming patch files, check if there are any changes to 
 protobuf files, and report any potentially incompatible changes (line 
 removals, etc,.). We may want the tool to be conservative: it may report 
 false positives, but we should minimize its chance to have false negatives. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)