[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369720#comment-15369720
]
Hudson commented on YARN-3367:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139217#comment-15139217
]
Sangjin Lee commented on YARN-3367:
---
The latest patch LGTM. Committing shortly.
> Replace starting a
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139289#comment-15139289
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for the review can commit [~sjlee0], It was nice
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137425#comment-15137425
]
Sangjin Lee commented on YARN-3367:
---
OK I think it's real close now. I ran all the tests that are timing
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137524#comment-15137524
]
Sangjin Lee commented on YARN-3367:
---
LGTM. I'll commit it soon unless I hear additional feedback.
>
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137617#comment-15137617
]
Sangjin Lee commented on YARN-3367:
---
Hi [~Naganarasimha], I realized that the patch needs to be rebased
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138179#comment-15138179
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135746#comment-15135746
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135305#comment-15135305
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135321#comment-15135321
]
Sangjin Lee commented on YARN-3367:
---
The reason you're not seeing that is because
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1512#comment-1512
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130015#comment-15130015
]
Varun Saxena commented on YARN-3367:
testSyncCall is failing again.
I think instead of a fixed sleep
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130336#comment-15130336
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~varun_saxena],
True will update the patch
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130065#comment-15130065
]
Varun Saxena commented on YARN-3367:
A couple of comments.
# When we are stopping the dispatcher, we
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131212#comment-15131212
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130971#comment-15130971
]
Sangjin Lee commented on YARN-3367:
---
I agree it might be slightly better to try to drain the queue when
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129193#comment-15129193
]
Sangjin Lee commented on YARN-3367:
---
My local test for TestDistributedShell was not conclusive. On my
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129511#comment-15129511
]
Sangjin Lee commented on YARN-3367:
---
It looks good to me. I don't think the unit test failures are
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128620#comment-15128620
]
Sangjin Lee commented on YARN-3367:
---
Regarding TestDistributedShell, I'll try to reproduce it locally and
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126957#comment-15126957
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126233#comment-15126233
]
Naganarasimha G R commented on YARN-3367:
-
Test case failures and hanging is not related to the
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126270#comment-15126270
]
Varun Saxena commented on YARN-3367:
bq. TimelineClient class becoming bulky and little clumsy.
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127767#comment-15127767
]
Varun Saxena commented on YARN-3367:
bq. TestDistributedShell: what is the status of this test on our
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127773#comment-15127773
]
Naganarasimha G R commented on YARN-3367:
-
I have been trying for sometime now and i was
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126765#comment-15126765
]
Sangjin Lee commented on YARN-3367:
---
Thanks [~Naganarasimha] for the updated patch! I'll take a closer
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126446#comment-15126446
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126734#comment-15126734
]
Sangjin Lee commented on YARN-3367:
---
I agree it may be a good idea to create separate implementation
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125601#comment-15125601
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120497#comment-15120497
]
Sangjin Lee commented on YARN-3367:
---
Thanks for the latest patch [~Naganarasimha]! I'm going over it, and
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120757#comment-15120757
]
Naganarasimha G R (Naga) commented on YARN-3367:
Hi Sangjin,
Skimmed throught the
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120951#comment-15120951
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120627#comment-15120627
]
Sangjin Lee commented on YARN-3367:
---
I went over the patch in some more detail, and it's definitely much
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120646#comment-15120646
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~sjlee0], for sharing these points:
bq. First
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117078#comment-15117078
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117513#comment-15117513
]
Naganarasimha G R commented on YARN-3367:
-
test case failures are not related to the patch,
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116506#comment-15116506
]
Naganarasimha G R commented on YARN-3367:
-
Have cross verified the patch in TestDistributedShell
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116517#comment-15116517
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116555#comment-15116555
]
Naganarasimha G R commented on YARN-3367:
-
Need to rebase the patch... uploading shortly !
>
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107105#comment-15107105
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for comments [~sjlee0], Working on the patch.
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087811#comment-15087811
]
Sangjin Lee commented on YARN-3367:
---
[~Naganarasimha] and I spoke offline about this, but wanted to
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070009#comment-15070009
]
Naganarasimha G R commented on YARN-3367:
-
thanks [~djp] for looking into this issue.
bq. Sounds
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069952#comment-15069952
]
Junping Du commented on YARN-3367:
--
Thanks Naga for updating the patch! Quickly go through your patch but
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070652#comment-15070652
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for the comments [~sjlee0],
bq. I would very much
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070715#comment-15070715
]
Sangjin Lee commented on YARN-3367:
---
I haven't fully digested the code so I might be off-base. But when I
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070611#comment-15070611
]
Sangjin Lee commented on YARN-3367:
---
Thanks for the patch [~Naganarasimha]! I took a fairly quick look at
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068468#comment-15068468
]
Naganarasimha G R commented on YARN-3367:
-
check style issues some cannot be handled(line lengths >
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068355#comment-15068355
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067436#comment-15067436
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044081#comment-15044081
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041824#comment-15041824
]
Junping Du commented on YARN-3367:
--
bq. Can you share your thoughts on why events are required to be in
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004506#comment-15004506
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970108#comment-14970108
]
Naganarasimha G R commented on YARN-3367:
-
Hi [~djp],
Can you share your thoughts on why events
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947620#comment-14947620
]
Sangjin Lee commented on YARN-3367:
---
{quote}
You mean that flush need not be coupled with the sync call ?
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948044#comment-14948044
]
Naganarasimha G R commented on YARN-3367:
-
bq. There is still no hard guarantee that they will be
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947261#comment-14947261
]
Naganarasimha G R commented on YARN-3367:
-
Hi [~sjlee0] , Thanks for the comments,
Went through
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943760#comment-14943760
]
Sangjin Lee commented on YARN-3367:
---
Sorry for my late reply.
{quote}
Timelineclient async calls are
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14943849#comment-14943849
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for the feed back [~sjlee0],
bq. If the client is
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944028#comment-14944028
]
Sangjin Lee commented on YARN-3367:
---
bq. Yes i agree with this, but what should be the behavior of Sync
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939324#comment-14939324
]
Naganarasimha G R commented on YARN-3367:
-
Hi [~gtCarrera] & [~sjlee0], Any thoughts on my
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903754#comment-14903754
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~gtCarrera9],
For looking into this, There were
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903461#comment-14903461
]
Li Lu commented on YARN-3367:
-
Hi [~Naganarasimha], I'm trying to go over all pending JIRAs for 2928 branch,
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903527#comment-14903527
]
Li Lu commented on YARN-3367:
-
Also, I looked at the patch. One general comment is that, the logic of
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14732079#comment-14732079
]
Hadoop QA commented on YARN-3367:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701302#comment-14701302
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~djp], Assigning this jira to
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653651#comment-14653651
]
Junping Du commented on YARN-3367:
--
We need to implement a separated API -
65 matches
Mail list logo
